)]}'
{"keystone/common/dependency.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b85b7775868b219516ee68896f2f61ba91b52986","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    If any required dependencies are unresolvable, this function will raise an"},{"line_number":221,"context_line":"    UnresolvableDependencyException."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    Outside of this module, this function should be called with no arguments;"},{"line_number":224,"context_line":"    the optional argument is used internally, and should be treated as an"},{"line_number":225,"context_line":"    implementation detail."},{"line_number":226,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_21a0b142","line":223,"updated":"2014-09-10 14:19:12.000000000","message":"the test directly conflicts with this - how can you test this without reaching into it\u0027s implementation details?","commit_id":"e9b88247d6aa50b9a68fc34a808f0f3ea6b8babb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"958f552a8bbaf96b2dcfdb442b165956d5c1d0a6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            setattr(target, provider_name, REGISTRY[provider_name])"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        return"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    # Resolve optional dependencies, sets the attribute to None if there\u0027s no"},{"line_number":240,"context_line":"    # provider registered."},{"line_number":241,"context_line":"    for dependency, targets in six.iteritems(_future_optionals.copy()):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_9c127455","line":238,"updated":"2014-09-03 15:30:00.000000000","message":"This is where the attribute is set to None.\n\nGiven the change above, this should be removed.","commit_id":"e9b88247d6aa50b9a68fc34a808f0f3ea6b8babb"}],"keystone/tests/test_injection.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"466b43659dccefa13df4f45e35622997212c44af","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        c1_inst \u003d C1()"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        dependency.resolve_future_dependencies(\u0027provider_name\u0027)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        self.assertIsNone(getattr(c1_inst, requirement_name))"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_f619da7a","line":235,"updated":"2014-08-28 14:10:14.000000000","message":"even though provider_name is the only parameter in the resolve_future_dependencies method signature, we should pass it in as a kwarg: \n\n    dependency.resolve_future_dependencies(provider_name\u003d\u0027some_provider\u0027)","commit_id":"9cbceabaf55ae946984076a1c00c219e62a22d50"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"b85b7775868b219516ee68896f2f61ba91b52986","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        c1_inst \u003d C1()"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        dependency.resolve_future_dependencies("},{"line_number":236,"context_line":"            provider_name\u003d\u0027some_provider\u0027)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self.assertIsNone(getattr(c1_inst, requirement_name))"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_41ba156f","line":236,"updated":"2014-09-10 14:19:12.000000000","message":"from the function\u0027s docstr: \"the optional argument is used internally, and should be treated as an implementation detail\"","commit_id":"e9b88247d6aa50b9a68fc34a808f0f3ea6b8babb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"02c7ab42fabc5840381763e1e556ed9df7cd669b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        c1_inst \u003d C1()"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        dependency.resolve_future_dependencies("},{"line_number":236,"context_line":"            provider_name\u003d\u0027some_provider\u0027)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self.assertIsNone(getattr(c1_inst, requirement_name))"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_21323f5f","line":236,"in_reply_to":"fa98f980_4197433a","updated":"2014-09-11 19:59:47.000000000","message":"http://git.openstack.org/cgit/openstack/keystone/tree/bin/keystone-all#n151\n\nhttp://git.openstack.org/cgit/openstack/keystone/tree/httpd/keystone.py#n61\n\nhttp://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/core.py#n509","commit_id":"e9b88247d6aa50b9a68fc34a808f0f3ea6b8babb"},{"author":{"_account_id":11434,"name":"werner mendizabal","email":"nonameentername@gmail.com","username":"nonameentername"},"change_message_id":"62916d3b08d1d4bbc27d89291d08685cd0dc53a1","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        c1_inst \u003d C1()"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        dependency.resolve_future_dependencies("},{"line_number":236,"context_line":"            provider_name\u003d\u0027some_provider\u0027)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        self.assertIsNone(getattr(c1_inst, requirement_name))"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_4197433a","line":236,"in_reply_to":"fa98f980_41ba156f","updated":"2014-09-11 19:57:20.000000000","message":"Where in the code is resolve_future_dependencies called without an argument in the keystone code?  I only see this in test_injection","commit_id":"e9b88247d6aa50b9a68fc34a808f0f3ea6b8babb"}]}