)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"75d6685d17ddfe0b373d7bf82670f83f047dc397","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Stanek \u003cdstanek@dstanek.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-26 17:06:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds tests that show how update with validation work"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some production code was changed to correctly validate. A function to"},{"line_number":10,"context_line":"convert property types to nullable property types was added. The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_a97cbcec","line":7,"updated":"2014-08-26 17:58:47.000000000","message":"works?","commit_id":"9d9a01499fe7cf0d01ffad395c7f2a732d3fb088"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fd46c00463ce82dfb441a1bd5badcddee7041f36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Stanek \u003cdstanek@dstanek.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-26 17:06:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds tests that show how update with validation work"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some production code was changed to correctly validate. A function to"},{"line_number":10,"context_line":"convert property types to nullable property types was added. The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_0d185b74","line":7,"in_reply_to":"1abeadc6_a97cbcec","updated":"2014-08-26 18:09:38.000000000","message":"Done","commit_id":"9d9a01499fe7cf0d01ffad395c7f2a732d3fb088"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some production code was changed to correctly validate. A function to"},{"line_number":10,"context_line":"convert property types to nullable property types was added. The"},{"line_number":11,"context_line":"description property schema was altered to not be nullable by default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1172271b80b4cc4f766403429eb88e304d251d3c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1abeadc6_0058e788","line":12,"updated":"2014-08-29 01:20:10.000000000","message":"is this related to a bug or blueprint?","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"}],"keystone/common/validation/__init__.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    return add_validator"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def nullable(property_schema):"},{"line_number":42,"context_line":"    \"\"\"Clone a property schema into one that is nullable."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    :param dict property_schema: schema to clone into a nullable schema"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_bb9bb464","line":41,"updated":"2014-08-29 01:20:10.000000000","message":"I think \"optional\" would be a better name. That you can use null is an implementation detail.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"ff8c4c71bffafce25902443f73614bc1c0c60f2a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    :param dict property_schema: schema to clone into a nullable schema"},{"line_number":45,"context_line":"    :returns: a new dict schema"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    # TODO(dstanek): deal with the case where type is already a list; we don\u0027t"},{"line_number":48,"context_line":"    #                do that yet so I\u0027m not wasting time on it"},{"line_number":49,"context_line":"    new_schema \u003d property_schema.copy()"},{"line_number":50,"context_line":"    new_schema[\u0027type\u0027] \u003d [property_schema[\u0027type\u0027], \u0027null\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_96c27d51","line":47,"updated":"2014-08-28 01:16:52.000000000","message":"++","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"}],"keystone/common/validation/parameter_types.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1b8948dd4cd15b8229d3032a4b6cefc546639c90","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"Common parameter types for validating a request reference.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"boolean \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_4fadb0e8","line":12,"updated":"2014-08-27 21:29:57.000000000","message":"Unrelated Whitespace change","commit_id":"91120de021ff96c50560fa379db1fe5800826d55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2aa3598d7ab4bdd485a66fda8868037c6988dec7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"Common parameter types for validating a request reference.\"\"\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"boolean \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_a2a2dbab","line":12,"in_reply_to":"1abeadc6_4fadb0e8","updated":"2014-08-27 22:16:10.000000000","message":"Done","commit_id":"91120de021ff96c50560fa379db1fe5800826d55"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"ff8c4c71bffafce25902443f73614bc1c0c60f2a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"description \u003d {"},{"line_number":39,"context_line":"    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"url \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_d6c07552","side":"PARENT","line":39,"updated":"2014-08-28 01:16:52.000000000","message":"for other reviewers, because this caught me off guard and it took me a minute to follow along: description is still nullable at the controller layer thanks to validation.nullable() (in which case the manager maps description\u003dNone to description\u003d\u0027\u0027 for the backend)","commit_id":"0b5432137977ff1642efc5daa0c278107acd8396"}],"keystone/tests/test_validation.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4910b45492af55b53c7b994f28bf39d2570e5e4a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_update_entity_with_a_valid_required_parameter_succeeds(self):"},{"line_number":209,"context_line":"        \"\"\"Succeed if a valid required parameter is proviced.\"\"\""},{"line_number":210,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":211,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_6e538a39","line":209,"updated":"2014-08-26 17:37:19.000000000","message":"provided*","commit_id":"9d9a01499fe7cf0d01ffad395c7f2a732d3fb088"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fd46c00463ce82dfb441a1bd5badcddee7041f36","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_update_entity_with_a_valid_required_parameter_succeeds(self):"},{"line_number":209,"context_line":"        \"\"\"Succeed if a valid required parameter is proviced.\"\"\""},{"line_number":210,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":211,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_cd0d8337","line":209,"in_reply_to":"1abeadc6_6e538a39","updated":"2014-08-26 18:09:38.000000000","message":"Done","commit_id":"9d9a01499fe7cf0d01ffad395c7f2a732d3fb088"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c72bd34d1eda8d7d6cb761842ddf681101a9da9c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from keystone.assignment import schema as assignment_schema"},{"line_number":19,"context_line":"from keystone.common import validation"},{"line_number":20,"context_line":"from keystone.common.validation import parameter_types"},{"line_number":21,"context_line":"from keystone.common.validation import validators"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_3631e40b","line":18,"updated":"2014-08-26 19:54:38.000000000","message":"assignment_schema isn\u0027t used in this patch set, this will probably fail pep8.","commit_id":"bfd3f05578a9e902b46e83153f487823349be811"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1b8948dd4cd15b8229d3032a4b6cefc546639c90","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#     description \u003d sql.Column(sql.Text(), nullable\u003dTrue)"},{"line_number":30,"context_line":"#     enabled \u003d sql.Column(sql.Boolean, default\u003dTrue, nullable\u003dFalse)"},{"line_number":31,"context_line":"#     url \u003d sql.Column(sql.String(225), nullable\u003dTrue)"},{"line_number":32,"context_line":"#     email \u003d sql.Column(sql.String(64), nullable\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Test schema to validate create requests against"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_4f94d08a","line":32,"updated":"2014-08-27 21:29:57.000000000","message":"Commented out code like this shouldn\u0027t remain in the code base. if it\u0027s docstring worthy it should be converted.\n\nSuggest removing.","commit_id":"91120de021ff96c50560fa379db1fe5800826d55"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2aa3598d7ab4bdd485a66fda8868037c6988dec7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#     description \u003d sql.Column(sql.Text(), nullable\u003dTrue)"},{"line_number":30,"context_line":"#     enabled \u003d sql.Column(sql.Boolean, default\u003dTrue, nullable\u003dFalse)"},{"line_number":31,"context_line":"#     url \u003d sql.Column(sql.String(225), nullable\u003dTrue)"},{"line_number":32,"context_line":"#     email \u003d sql.Column(sql.String(64), nullable\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Test schema to validate create requests against"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_c2951734","line":32,"in_reply_to":"1abeadc6_4f94d08a","updated":"2014-08-27 22:16:10.000000000","message":"Done","commit_id":"91120de021ff96c50560fa379db1fe5800826d55"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1b8948dd4cd15b8229d3032a4b6cefc546639c90","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u0027description\u0027: validation.nullable(parameter_types.description),"},{"line_number":39,"context_line":"    \u0027enabled\u0027: parameter_types.boolean,"},{"line_number":40,"context_line":"    \u0027url\u0027: validation.nullable(parameter_types.url),"},{"line_number":41,"context_line":"    \u0027email\u0027: validation.nullable(parameter_types.email)"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"entity_create \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_0ff658f9","line":41,"updated":"2014-08-27 21:29:57.000000000","message":"This is a nice way to handle nullable.","commit_id":"91120de021ff96c50560fa379db1fe5800826d55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.common.validation import validators"},{"line_number":19,"context_line":"from keystone import exception"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\"\"\"Example model to validate create requests against"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class Entity(sql.ModelBase):"},{"line_number":24,"context_line":"    __tablename__ \u003d \u0027entity\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_bbdf3439","line":21,"updated":"2014-08-29 01:20:10.000000000","message":"I don\u0027t entirely follow why this is here. Keystone supports multiple backends so the sql model is interesting but it\u0027s not everything you need to know.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.common.validation import validators"},{"line_number":19,"context_line":"from keystone import exception"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\"\"\"Example model to validate create requests against"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class Entity(sql.ModelBase):"},{"line_number":24,"context_line":"    __tablename__ \u003d \u0027entity\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_2914a24b","line":21,"in_reply_to":"1abeadc6_bbdf3439","updated":"2014-08-29 13:11:00.000000000","message":"Done, I\u0027ve updated the comment. I think this is important because it details the mapping between the schema and how we came up with it. This would be useful for someone looking to validate an extension they are looking to contribute to Keystone.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"ff8c4c71bffafce25902443f73614bc1c0c60f2a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    attributes \u003d [\u0027id\u0027, \u0027name\u0027, \u0027domain_id\u0027, \u0027description\u0027]"},{"line_number":26,"context_line":"    id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":27,"context_line":"    name \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":28,"context_line":"    description \u003d sql.Column(sql.Text(), nullable\u003dTrue)"},{"line_number":29,"context_line":"    enabled \u003d sql.Column(sql.Boolean, default\u003dTrue, nullable\u003dFalse)"},{"line_number":30,"context_line":"    url \u003d sql.Column(sql.String(225), nullable\u003dTrue)"},{"line_number":31,"context_line":"    email \u003d sql.Column(sql.String(64), nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_16858d06","line":28,"updated":"2014-08-28 01:16:52.000000000","message":"not sure if it\u0027s a discrepancy, but it\u0027s nullable here","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_entity_properties \u003d {"},{"line_number":37,"context_line":"    \u0027name\u0027: parameter_types.name,"},{"line_number":38,"context_line":"    \u0027description\u0027: validation.nullable(parameter_types.description),"},{"line_number":39,"context_line":"    \u0027enabled\u0027: parameter_types.boolean,"},{"line_number":40,"context_line":"    \u0027url\u0027: validation.nullable(parameter_types.url),"},{"line_number":41,"context_line":"    \u0027email\u0027: validation.nullable(parameter_types.email)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_fbf52c83","line":38,"updated":"2014-08-29 01:20:10.000000000","message":"why not have a parameter_types.nullable_description?","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_entity_properties \u003d {"},{"line_number":37,"context_line":"    \u0027name\u0027: parameter_types.name,"},{"line_number":38,"context_line":"    \u0027description\u0027: validation.nullable(parameter_types.description),"},{"line_number":39,"context_line":"    \u0027enabled\u0027: parameter_types.boolean,"},{"line_number":40,"context_line":"    \u0027url\u0027: validation.nullable(parameter_types.url),"},{"line_number":41,"context_line":"    \u0027email\u0027: validation.nullable(parameter_types.email)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7c32d6f2","line":38,"in_reply_to":"1abeadc6_fbf52c83","updated":"2014-08-29 13:11:00.000000000","message":"This allows us to have a basic schema type for `description`. By using nullable, we have one type of description and tweak it for different cases, instead of having multiple versions of the same type.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"entity_update \u003d {"},{"line_number":52,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":53,"context_line":"    \u0027properties\u0027: _entity_properties,"},{"line_number":54,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":55,"context_line":"    \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_5b1380b7","line":52,"updated":"2014-08-29 01:20:10.000000000","message":"there\u0027s a lot of things that are copy-pasted from entity_create, and they have to be the same (such as the type and properties are going to be the same. So these should be put in a variable and shared.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"entity_update \u003d {"},{"line_number":52,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":53,"context_line":"    \u0027properties\u0027: _entity_properties,"},{"line_number":54,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":55,"context_line":"    \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7c91f6ef","line":52,"in_reply_to":"1abeadc6_5b1380b7","updated":"2014-08-29 13:11:00.000000000","message":"This representation of the schema is similar to how the schemas are defined for other Keystone resources.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.update_schema_validator \u003d validators.SchemaValidator("},{"line_number":75,"context_line":"            entity_update)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_create_entity_with_all_valid_parameters_succeeds(self):"},{"line_number":78,"context_line":"        \"\"\"Validate correct for all parameter values against test schema.\"\"\""},{"line_number":79,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":80,"context_line":"                               \u0027description\u0027: self.description,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_db54f055","line":77,"updated":"2014-08-29 01:20:10.000000000","message":"I always consider success to be the default in tests. Also, \"succeeds\" can be confusing since something can be working as designed when it \"fails\". So \"validates\" would be a better term here.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.update_schema_validator \u003d validators.SchemaValidator("},{"line_number":75,"context_line":"            entity_update)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_create_entity_with_all_valid_parameters_succeeds(self):"},{"line_number":78,"context_line":"        \"\"\"Validate correct for all parameter values against test schema.\"\"\""},{"line_number":79,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":80,"context_line":"                               \u0027description\u0027: self.description,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_dc4f6a90","line":77,"in_reply_to":"1abeadc6_db54f055","updated":"2014-08-29 13:11:00.000000000","message":"Done","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            entity_update)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_create_entity_with_all_valid_parameters_succeeds(self):"},{"line_number":78,"context_line":"        \"\"\"Validate correct for all parameter values against test schema.\"\"\""},{"line_number":79,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":80,"context_line":"                               \u0027description\u0027: self.description,"},{"line_number":81,"context_line":"                               \u0027enabled\u0027: self.valid_enabled,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_bba1f447","line":78,"updated":"2014-08-29 01:20:10.000000000","message":"this sentence doesn\u0027t make sense to me.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            entity_update)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_create_entity_with_all_valid_parameters_succeeds(self):"},{"line_number":78,"context_line":"        \"\"\"Validate correct for all parameter values against test schema.\"\"\""},{"line_number":79,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":80,"context_line":"                               \u0027description\u0027: self.description,"},{"line_number":81,"context_line":"                               \u0027enabled\u0027: self.valid_enabled,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_9c517232","line":78,"in_reply_to":"1abeadc6_bba1f447","updated":"2014-08-29 13:11:00.000000000","message":"Done","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                   \u0027enabled\u0027: format}"},{"line_number":128,"context_line":"            self.assertRaises(exception.SchemaValidationError,"},{"line_number":129,"context_line":"                              self.create_schema_validator.validate,"},{"line_number":130,"context_line":"                              request_to_validate)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_create_entity_with_valid_enabled_formats(self):"},{"line_number":133,"context_line":"        \"\"\"Validate valid enabled formats."}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_3b524435","line":130,"updated":"2014-08-29 01:20:10.000000000","message":"this assert should print out the format if it fails so that we can tell which one failed.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e4276c97dd435666363cb7a68e6cef5fed083c55","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                                   \u0027enabled\u0027: format}"},{"line_number":128,"context_line":"            self.assertRaises(exception.SchemaValidationError,"},{"line_number":129,"context_line":"                              self.create_schema_validator.validate,"},{"line_number":130,"context_line":"                              request_to_validate)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_create_entity_with_valid_enabled_formats(self):"},{"line_number":133,"context_line":"        \"\"\"Validate valid enabled formats."}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_ff3fb884","line":130,"in_reply_to":"1abeadc6_3b524435","updated":"2014-08-29 13:12:26.000000000","message":"Not sure how we\u0027d do that, if the request_to_validate succeeds validation without raising an exception it should be available in the trace.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":140,"context_line":"                                   \u0027enabled\u0027: valid_enabled}"},{"line_number":141,"context_line":"            # Make sure validation doesn\u0027t raise a validation exception"},{"line_number":142,"context_line":"            self.create_schema_validator.validate(request_to_validate)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_create_entity_with_valid_urls(self):"},{"line_number":145,"context_line":"        \"\"\"Test that proper urls are successfully validated.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_bb3d74df","line":142,"updated":"2014-08-29 01:20:10.000000000","message":"this assert should print out the format if it fails so that we can tell which one failed.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            # Make sure validation doesn\u0027t raise a validation exception"},{"line_number":142,"context_line":"            self.create_schema_validator.validate(request_to_validate)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_create_entity_with_valid_urls(self):"},{"line_number":145,"context_line":"        \"\"\"Test that proper urls are successfully validated.\"\"\""},{"line_number":146,"context_line":"        valid_urls \u003d [\u0027https://169.254.0.1\u0027, \u0027https://example.com\u0027,"},{"line_number":147,"context_line":"                      \u0027https://EXAMPLE.com\u0027, \u0027https://127.0.0.1:35357\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_3b29649b","line":144,"updated":"2014-08-29 01:20:10.000000000","message":"this method should have \"_succeeds\" to be consistent.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            # Make sure validation doesn\u0027t raise a validation exception"},{"line_number":142,"context_line":"            self.create_schema_validator.validate(request_to_validate)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_create_entity_with_valid_urls(self):"},{"line_number":145,"context_line":"        \"\"\"Test that proper urls are successfully validated.\"\"\""},{"line_number":146,"context_line":"        valid_urls \u003d [\u0027https://169.254.0.1\u0027, \u0027https://example.com\u0027,"},{"line_number":147,"context_line":"                      \u0027https://EXAMPLE.com\u0027, \u0027https://127.0.0.1:35357\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_1f59d434","line":144,"in_reply_to":"1abeadc6_3b29649b","updated":"2014-08-29 13:11:00.000000000","message":"Done","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_update_entity_with_a_valid_required_parameter_succeeds(self):"},{"line_number":207,"context_line":"        \"\"\"Succeed if a valid required parameter is provided.\"\"\""},{"line_number":208,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":209,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_b60bcb22","line":207,"updated":"2014-08-29 01:20:10.000000000","message":"\u0027name\u0027 isn\u0027t required.","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def test_update_entity_with_a_valid_required_parameter_succeeds(self):"},{"line_number":207,"context_line":"        \"\"\"Succeed if a valid required parameter is provided.\"\"\""},{"line_number":208,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":209,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_bf7620a2","line":207,"in_reply_to":"1abeadc6_b60bcb22","updated":"2014-08-29 13:11:00.000000000","message":"Done","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def test_update_entity_with_a_null_optional_parameter_succeeds(self):"},{"line_number":224,"context_line":"        \"\"\"Optional parameters can be null to removed the value.\"\"\""},{"line_number":225,"context_line":"        request_to_validate \u003d {\u0027email\u0027: None}"},{"line_number":226,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_3617bb46","line":224,"updated":"2014-08-29 01:20:10.000000000","message":"there should be a test for setting \u0027name\u0027 to None, too (should fail)","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def test_update_entity_with_a_null_optional_parameter_succeeds(self):"},{"line_number":224,"context_line":"        \"\"\"Optional parameters can be null to removed the value.\"\"\""},{"line_number":225,"context_line":"        request_to_validate \u003d {\u0027email\u0027: None}"},{"line_number":226,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_1fa7140c","line":224,"in_reply_to":"1abeadc6_3617bb46","updated":"2014-08-29 13:11:00.000000000","message":"Done","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5e80c01ed6aa97f95ab25daa6aaf675a0f98484e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        request_to_validate \u003d {\u0027email\u0027: None}"},{"line_number":226,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_update_entity_with_a_valid_optional_parameter_succeeds(self):"},{"line_number":229,"context_line":"        \"\"\"Succeeds with only a single valid optional parameter.\"\"\""},{"line_number":230,"context_line":"        request_to_validate \u003d {\u0027email\u0027: self.valid_email}"},{"line_number":231,"context_line":"        self.update_schema_validator.validate(request_to_validate)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_d641273a","line":228,"updated":"2014-08-29 01:20:10.000000000","message":"this is a copy of test_update_entity_with_missing_required_parameter_succeeds","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"261b69ca9a75d4595f7ad91dee020db08b566aa3","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        request_to_validate \u003d {\u0027email\u0027: None}"},{"line_number":226,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_update_entity_with_a_valid_optional_parameter_succeeds(self):"},{"line_number":229,"context_line":"        \"\"\"Succeeds with only a single valid optional parameter.\"\"\""},{"line_number":230,"context_line":"        request_to_validate \u003d {\u0027email\u0027: self.valid_email}"},{"line_number":231,"context_line":"        self.update_schema_validator.validate(request_to_validate)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_fff17801","line":228,"in_reply_to":"1abeadc6_d641273a","updated":"2014-08-29 13:11:00.000000000","message":"Done","commit_id":"295e4f845ec3c3f7908d5128b1e9d54c302bb54b"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9ee246ea6bb5c05060b7ec5477253cb7e3803158","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                               \u0027email\u0027: self.valid_email}"},{"line_number":209,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_update_entity_with_a_valid_parameter_validates(self):"},{"line_number":212,"context_line":"        \"\"\"Succeed if a valid required parameter is provided.\"\"\""},{"line_number":213,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":214,"context_line":"        self.update_schema_validator.validate(request_to_validate)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_5a927a57","line":211,"updated":"2014-08-29 13:48:44.000000000","message":"I actually think it was clearer stating that the parameter was required. The entity that we are modeling does require a name and this test is for the usecase of updating the name.","commit_id":"76b7a3acc98c1996c26cba4374318946d6430c1d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"22c21782b5a80f379304f8893b84b9dc1afedf41","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                               \u0027email\u0027: self.valid_email}"},{"line_number":209,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_update_entity_with_a_valid_parameter_validates(self):"},{"line_number":212,"context_line":"        \"\"\"Succeed if a valid required parameter is provided.\"\"\""},{"line_number":213,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":214,"context_line":"        self.update_schema_validator.validate(request_to_validate)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_afe50ddd","line":211,"in_reply_to":"1abeadc6_5a927a57","updated":"2014-08-29 15:23:50.000000000","message":"Done","commit_id":"76b7a3acc98c1996c26cba4374318946d6430c1d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9ee246ea6bb5c05060b7ec5477253cb7e3803158","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        request_to_validate \u003d {\u0027email\u0027: None}"},{"line_number":226,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_update_entity_name_with_a_null_parameter_fails(self):"},{"line_number":229,"context_line":"        \"\"\"The `name` parameter can\u0027t be null.\"\"\""},{"line_number":230,"context_line":"        request_to_validate \u003d {\u0027name\u0027: None}"},{"line_number":231,"context_line":"        self.assertRaises(exception.SchemaValidationError,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_da092a96","line":228,"updated":"2014-08-29 13:48:44.000000000","message":"I\u0027d actually prefer this to say required parameter instead of name. This is primarily because the usecase is actually trying to remove a required field.","commit_id":"76b7a3acc98c1996c26cba4374318946d6430c1d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"22c21782b5a80f379304f8893b84b9dc1afedf41","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        request_to_validate \u003d {\u0027email\u0027: None}"},{"line_number":226,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_update_entity_name_with_a_null_parameter_fails(self):"},{"line_number":229,"context_line":"        \"\"\"The `name` parameter can\u0027t be null.\"\"\""},{"line_number":230,"context_line":"        request_to_validate \u003d {\u0027name\u0027: None}"},{"line_number":231,"context_line":"        self.assertRaises(exception.SchemaValidationError,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_cfffa964","line":228,"in_reply_to":"1abeadc6_da092a96","updated":"2014-08-29 15:23:50.000000000","message":"Done","commit_id":"76b7a3acc98c1996c26cba4374318946d6430c1d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"07d8224fbe5db1f17d60b106ad5f7e2133dec924","unresolved":false,"context_lines":[{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"entity_update \u003d {"},{"line_number":57,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":58,"context_line":"    \u0027properties\u0027: _entity_properties,"},{"line_number":59,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":60,"context_line":"    \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_b5339c60","line":57,"updated":"2014-08-29 16:06:08.000000000","message":"I still think these should not be copy-pasted.","commit_id":"1a164379d17ef4b2b301a468f4258ee21ee381a8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"07d8224fbe5db1f17d60b106ad5f7e2133dec924","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_update_entity_with_a_valid_required_parameter_validates(self):"},{"line_number":212,"context_line":"        \"\"\"Succeed if a valid required parameter is provided.\"\"\""},{"line_number":213,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name}"},{"line_number":214,"context_line":"        self.update_schema_validator.validate(request_to_validate)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_95bb00c3","line":212,"updated":"2014-08-29 16:06:08.000000000","message":"\u0027name\u0027 isn\u0027t required.","commit_id":"1a164379d17ef4b2b301a468f4258ee21ee381a8"}]}
