)]}'
{"keystone/common/config.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f42069c0bfbfdc31d8c9137eca300c1f515bd7a4","unresolved":false,"context_lines":[{"line_number":819,"context_line":"    for method_name in conf.auth.methods:"},{"line_number":820,"context_line":"        if method_name not in _DEFAULT_AUTH_METHODS:"},{"line_number":821,"context_line":"            opt \u003d cfg.StrOpt(method_name)"},{"line_number":822,"context_line":"            _register_auth_plugin_opt(conf, opt)"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"def configure(conf\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_56619737","line":822,"updated":"2014-08-29 01:36:52.000000000","message":"opt should be method_name, right? since _register does cfg.StrOpt on it.","commit_id":"49e46edacd1875c6cc08bd5c63266b613294fe37"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"bb8633c2cdb47436493aa93ae4e4304755733040","unresolved":false,"context_lines":[{"line_number":819,"context_line":"    for method_name in conf.auth.methods:"},{"line_number":820,"context_line":"        if method_name not in _DEFAULT_AUTH_METHODS:"},{"line_number":821,"context_line":"            opt \u003d cfg.StrOpt(method_name)"},{"line_number":822,"context_line":"            _register_auth_plugin_opt(conf, opt)"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"def configure(conf\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_dfb853ca","line":822,"in_reply_to":"1abeadc6_56619737","updated":"2014-08-29 04:26:21.000000000","message":"ah this would be a major issue in the real world, register shouldn\u0027t make a config option it should just register it. but yes this is an issue. The implementation in the tests.core is the correct one (mocked to use the config_fixture)","commit_id":"49e46edacd1875c6cc08bd5c63266b613294fe37"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"45ef7f42baabfa4316ef60035838999dee22cfc8","unresolved":false,"context_lines":[{"line_number":808,"context_line":"messaging.set_transport_defaults(control_exchange\u003d\u0027keystone\u0027)"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"def _register_auth_plugin_opt(conf, option):"},{"line_number":812,"context_line":"    conf.register_opt(option, group\u003d\u0027auth\u0027)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_518a531b","line":811,"updated":"2014-08-29 20:34:41.000000000","message":"not sure why we need a separate method for this. Anyway, not a big deal.","commit_id":"945d8c7d2162ae51515216352a3a382d4c5f2fc5"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"176eea3fac70b99a9a157d37e8e06dd95cdeff49","unresolved":false,"context_lines":[{"line_number":808,"context_line":"messaging.set_transport_defaults(control_exchange\u003d\u0027keystone\u0027)"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"def _register_auth_plugin_opt(conf, option):"},{"line_number":812,"context_line":"    conf.register_opt(option, group\u003d\u0027auth\u0027)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_4ce0fa25","line":811,"in_reply_to":"1abeadc6_518a531b","updated":"2014-08-29 21:04:53.000000000","message":"it\u0027s mocked in tests to behave differently, hence it\u0027s segregated out","commit_id":"945d8c7d2162ae51515216352a3a382d4c5f2fc5"}],"keystone/tests/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d809a5a162c2390d12d2198cca916690a528dd7e","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                saml2\u003d\u0027keystone.auth.plugins.saml2.Saml2\u0027,"},{"line_number":391,"context_line":"            )"},{"line_number":392,"context_line":"        if methods is None:"},{"line_number":393,"context_line":"            methods \u003d [\u0027external\u0027, \u0027password\u0027, \u0027token\u0027, \u0027oauth1\u0027, \u0027saml2\u0027]"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        self.config_fixture.config(group\u003d\u0027auth\u0027, methods\u003dmethods)"},{"line_number":396,"context_line":"        common_cfg.setup_authentication()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_48a49d4a","line":393,"updated":"2014-08-28 21:32:09.000000000","message":"so, this could have methods that aren\u0027t in method_classes? or should this just be method_classes.keys() ?","commit_id":"49e46edacd1875c6cc08bd5c63266b613294fe37"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"ad9b563cdea1832840172b537a3024f81e46a0ed","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                saml2\u003d\u0027keystone.auth.plugins.saml2.Saml2\u0027,"},{"line_number":391,"context_line":"            )"},{"line_number":392,"context_line":"        if methods is None:"},{"line_number":393,"context_line":"            methods \u003d [\u0027external\u0027, \u0027password\u0027, \u0027token\u0027, \u0027oauth1\u0027, \u0027saml2\u0027]"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        self.config_fixture.config(group\u003d\u0027auth\u0027, methods\u003dmethods)"},{"line_number":396,"context_line":"        common_cfg.setup_authentication()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_338d127d","line":393,"in_reply_to":"1abeadc6_48a49d4a","updated":"2014-08-28 21:37:34.000000000","message":"oh, i forgot that order of appearance matters in conf. disregard ^","commit_id":"49e46edacd1875c6cc08bd5c63266b613294fe37"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"5aba157da8d1fafa5c1fe34267e066856b483345","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        self.config_fixture.config(group\u003d\u0027auth\u0027, methods\u003dmethods)"},{"line_number":396,"context_line":"        common_cfg.setup_authentication()"},{"line_number":397,"context_line":"        if method_classes:"},{"line_number":398,"context_line":"            self.config_fixture.config(group\u003d\u0027auth\u0027, **method_classes)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_b31da264","line":397,"updated":"2014-08-28 21:34:55.000000000","message":"looks like this will only be skipped if method_classes is falsey and methods is not None? what\u0027s the use case for that?","commit_id":"49e46edacd1875c6cc08bd5c63266b613294fe37"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1fcade9366d08dc558bc49cfd3eae4ecd4d817e4","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        self.config_fixture.config(group\u003d\u0027auth\u0027, methods\u003dmethods)"},{"line_number":396,"context_line":"        common_cfg.setup_authentication()"},{"line_number":397,"context_line":"        if method_classes:"},{"line_number":398,"context_line":"            self.config_fixture.config(group\u003d\u0027auth\u0027, **method_classes)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_4edf45d6","line":397,"in_reply_to":"1abeadc6_b31da264","updated":"2014-08-28 22:35:51.000000000","message":"There was one test that set methods to \u0027\u0027, so i wanted to maintain that. This might be a bit odd now that i look at it, it shouldn\u0027t matter as long as methods is \u0027\u0027","commit_id":"49e46edacd1875c6cc08bd5c63266b613294fe37"}]}