)]}'
{"keystone/assignment/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"26470be92999af6e164d587668f0dfd4463eeb14","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            token_ref \u003d token_model.KeystoneToken(token_id\u003dcontext[\u0027token_id\u0027],"},{"line_number":75,"context_line":"                                                  token_data\u003dtoken_data)"},{"line_number":76,"context_line":"        except exception.NotFound as e:"},{"line_number":77,"context_line":"            LOG.warning(_LW(\u0027Authentication failed: %s\u0027), e)"},{"line_number":78,"context_line":"            raise exception.Unauthorized(e)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        tenant_refs \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_455ac183","line":77,"updated":"2014-10-27 14:55:56.000000000","message":"question here, what\u0027s the difference between: \n\n    LOG.warning\n\nand \n\n    LOG.warn\n\nIs one preferred over the other?","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f17697eccb587c649eec4ab2421053a5686f5ce","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            token_ref \u003d token_model.KeystoneToken(token_id\u003dcontext[\u0027token_id\u0027],"},{"line_number":75,"context_line":"                                                  token_data\u003dtoken_data)"},{"line_number":76,"context_line":"        except exception.NotFound as e:"},{"line_number":77,"context_line":"            LOG.warning(_LW(\u0027Authentication failed: %s\u0027), e)"},{"line_number":78,"context_line":"            raise exception.Unauthorized(e)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        tenant_refs \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_a966e727","line":77,"in_reply_to":"9aa7fdbe_455ac183","updated":"2014-10-27 15:17:00.000000000","message":"No difference: https://hg.python.org/cpython/file/a22ef88143b9/Lib/logging/__init__.py#l1288\n\nI like warn because it is shorted, but I don\u0027t think we have a preference as a team.","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47d31a35f56ef0613e735e0716d2c3b134a2ec5d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            token_ref \u003d token_model.KeystoneToken(token_id\u003dcontext[\u0027token_id\u0027],"},{"line_number":75,"context_line":"                                                  token_data\u003dtoken_data)"},{"line_number":76,"context_line":"        except exception.NotFound as e:"},{"line_number":77,"context_line":"            LOG.warning(_LW(\u0027Authentication failed: %s\u0027), e)"},{"line_number":78,"context_line":"            raise exception.Unauthorized(e)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        tenant_refs \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_35a2414b","line":77,"in_reply_to":"9aa7fdbe_a966e727","updated":"2014-10-27 20:01:44.000000000","message":"Is that something we should determine? Something we should work towards as a project?","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"}],"keystone/auth/controllers.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a46b0b5be137549ce4b895227c09dd14ecf7f8d7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from keystone import config"},{"line_number":27,"context_line":"from keystone.contrib import federation"},{"line_number":28,"context_line":"from keystone import exception"},{"line_number":29,"context_line":"from keystone.i18n import _, _LI"},{"line_number":30,"context_line":"from keystone.openstack.common import importutils"},{"line_number":31,"context_line":"from keystone.openstack.common import jsonutils"},{"line_number":32,"context_line":"from keystone.openstack.common import log"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_a302023c","side":"PARENT","line":29,"updated":"2014-10-01 20:07:19.000000000","message":"surprised this doesn\u0027t violate the one-import-per-line already","commit_id":"536dddd4aa8bf26040443b31b978deb0077c3b4d"}],"keystone/common/ldap/core.py":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"023be000a370dbf4f5e9808c3ffea68c173f44ab","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"                        not_deleted_nodes.append(node_dn)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"        if not_deleted_nodes:"},{"line_number":1653,"context_line":"            LOG.warn(_LW(\"When deleting entries for %(search_base)s, could not\""},{"line_number":1654,"context_line":"                         \" delete nonexistent entries %(entries)s%(dots)s\"),"},{"line_number":1655,"context_line":"                     {\u0027search_base\u0027: search_base,"},{"line_number":1656,"context_line":"                      \u0027entries\u0027: not_deleted_nodes[:3],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_8fc871a9","line":1653,"updated":"2014-10-24 12:39:06.000000000","message":"Though warn and warning are the same mb would be better to write somewhere in coding standard which one to prefer?\nThis is not about reviewed patch - just an idea.","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"}],"keystone/token/providers/common.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"92557ce448a3b4d71e941cb6f37dda1bf83ba074","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d audit_info"},{"line_number":343,"context_line":"        else:"},{"line_number":344,"context_line":"            msg \u003d (_(\u0027Invalid audit info data type: %(data)s (%(type)s)\u0027) %"},{"line_number":345,"context_line":"                   {\u0027data\u0027: audit_info, \u0027type\u0027: type(audit_info)})"},{"line_number":346,"context_line":"            LOG.error(msg)"},{"line_number":347,"context_line":"            raise exception.UnexpectedError(msg)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_0f254a08","line":345,"updated":"2014-10-25 20:24:20.000000000","message":"why was this changed? seems unrelated.","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1f17697eccb587c649eec4ab2421053a5686f5ce","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d audit_info"},{"line_number":343,"context_line":"        else:"},{"line_number":344,"context_line":"            msg \u003d (_(\u0027Invalid audit info data type: %(data)s (%(type)s)\u0027) %"},{"line_number":345,"context_line":"                   {\u0027data\u0027: audit_info, \u0027type\u0027: type(audit_info)})"},{"line_number":346,"context_line":"            LOG.error(msg)"},{"line_number":347,"context_line":"            raise exception.UnexpectedError(msg)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_49001b34","line":345,"in_reply_to":"9aa7fdbe_0f254a08","updated":"2014-10-27 15:17:00.000000000","message":"I have a review later in the chain that checks for the correct helper. I believe it failed in this method because it detected that msg was not using _LE. With this change it can tell that msg is used later to raise an exception so it will not complain about the _.","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d5871cde12762b6c055a5879a4493d85f46e38d5","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d audit_info"},{"line_number":343,"context_line":"        else:"},{"line_number":344,"context_line":"            msg \u003d (_(\u0027Invalid audit info data type: %(data)s (%(type)s)\u0027) %"},{"line_number":345,"context_line":"                   {\u0027data\u0027: audit_info, \u0027type\u0027: type(audit_info)})"},{"line_number":346,"context_line":"            LOG.error(msg)"},{"line_number":347,"context_line":"            raise exception.UnexpectedError(msg)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_2cd4c5ea","line":345,"in_reply_to":"9aa7fdbe_49001b34","updated":"2014-10-27 15:36:54.000000000","message":"The checker is broken if it can\u0027t figure it out with the code as it is.","commit_id":"314d58cc03594c808112b51887ceb0d801929baf"}]}