)]}'
{"keystone/tests/test_backend_ldap_pool.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4f45ea61b8e6a3a48dbbf2eae070483fdae42d0f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # automagically stop all patches and that will cause an"},{"line_number":220,"context_line":"        # exception. We could just not cleanup after ourselves since"},{"line_number":221,"context_line":"        # oslotest will do it, but that seems wrong. Once bug #1365678"},{"line_number":222,"context_line":"        # if fixed and released in oslotest we can start using"},{"line_number":223,"context_line":"        # oslotest.mockpatch.Patcher instead."},{"line_number":224,"context_line":"        patcher \u003d mock.patch.object(ldap_core.PooledLDAPHandler, \u0027Connector\u0027,"},{"line_number":225,"context_line":"                                    fakeldap.FakeLdapPool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_b12f2c3e","line":222,"updated":"2014-09-04 22:08:18.000000000","message":"change \"if fixed\" to \"is fixed\"","commit_id":"422fa23c6106c73f3ba027758a139c842fb23ea9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"250720e4737afca7fa1e1b4070bc3cfaa54df247","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # automagically stop all patches and that will cause an"},{"line_number":220,"context_line":"        # exception. We could just not cleanup after ourselves since"},{"line_number":221,"context_line":"        # oslotest will do it, but that seems wrong. Once bug #1365678"},{"line_number":222,"context_line":"        # if fixed and released in oslotest we can start using"},{"line_number":223,"context_line":"        # oslotest.mockpatch.Patcher instead."},{"line_number":224,"context_line":"        patcher \u003d mock.patch.object(ldap_core.PooledLDAPHandler, \u0027Connector\u0027,"},{"line_number":225,"context_line":"                                    fakeldap.FakeLdapPool)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_abd96558","line":222,"in_reply_to":"fa98f980_b12f2c3e","updated":"2014-09-05 12:20:02.000000000","message":"Done","commit_id":"422fa23c6106c73f3ba027758a139c842fb23ea9"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4f45ea61b8e6a3a48dbbf2eae070483fdae42d0f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # exception. We could just not cleanup after ourselves since"},{"line_number":221,"context_line":"        # oslotest will do it, but that seems wrong. Once bug #1365678"},{"line_number":222,"context_line":"        # if fixed and released in oslotest we can start using"},{"line_number":223,"context_line":"        # oslotest.mockpatch.Patcher instead."},{"line_number":224,"context_line":"        patcher \u003d mock.patch.object(ldap_core.PooledLDAPHandler, \u0027Connector\u0027,"},{"line_number":225,"context_line":"                                    fakeldap.FakeLdapPool)"},{"line_number":226,"context_line":"        patcher.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_119c785c","line":223,"updated":"2014-09-04 22:08:18.000000000","message":"you mean PatchObject? or is there something new?\n\nAlso, why can\u0027t we switch to PatchObject now? Looks like PatchObject was in the original release of oslotest.","commit_id":"422fa23c6106c73f3ba027758a139c842fb23ea9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"250720e4737afca7fa1e1b4070bc3cfaa54df247","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # exception. We could just not cleanup after ourselves since"},{"line_number":221,"context_line":"        # oslotest will do it, but that seems wrong. Once bug #1365678"},{"line_number":222,"context_line":"        # if fixed and released in oslotest we can start using"},{"line_number":223,"context_line":"        # oslotest.mockpatch.Patcher instead."},{"line_number":224,"context_line":"        patcher \u003d mock.patch.object(ldap_core.PooledLDAPHandler, \u0027Connector\u0027,"},{"line_number":225,"context_line":"                                    fakeldap.FakeLdapPool)"},{"line_number":226,"context_line":"        patcher.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0bd19122","line":223,"in_reply_to":"fa98f980_119c785c","updated":"2014-09-05 12:20:02.000000000","message":"We can\u0027t use PatchObject because of the oslotest bug. We have to make sure that our cleanUp is registered after oslotest\u0027s cleanup.","commit_id":"422fa23c6106c73f3ba027758a139c842fb23ea9"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4f45ea61b8e6a3a48dbbf2eae070483fdae42d0f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                    fakeldap.FakeLdapPool)"},{"line_number":226,"context_line":"        patcher.start()"},{"line_number":227,"context_line":"        super(LdapIdentitySqlAssignment, self).setUp()"},{"line_number":228,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        self.addCleanup(self.cleanup_pools)"},{"line_number":231,"context_line":"        # storing to local variable to avoid long references"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_f1b37407","line":228,"updated":"2014-09-04 22:08:18.000000000","message":"If setUp raises then addCleanup won\u0027t happen. Use try/finally.","commit_id":"422fa23c6106c73f3ba027758a139c842fb23ea9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"250720e4737afca7fa1e1b4070bc3cfaa54df247","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                    fakeldap.FakeLdapPool)"},{"line_number":226,"context_line":"        patcher.start()"},{"line_number":227,"context_line":"        super(LdapIdentitySqlAssignment, self).setUp()"},{"line_number":228,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        self.addCleanup(self.cleanup_pools)"},{"line_number":231,"context_line":"        # storing to local variable to avoid long references"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6bc21d54","line":228,"in_reply_to":"fa98f980_f1b37407","updated":"2014-09-05 12:20:02.000000000","message":"Done","commit_id":"422fa23c6106c73f3ba027758a139c842fb23ea9"}]}