)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"064ade4292c4f0d00ac7b7e187a946d75d45babf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Safer check for enabled in trusts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some LDAP backends, the enable attribute is not"},{"line_number":10,"context_line":"directly set.  Since we have a wrapper function in identiyt/core,"},{"line_number":11,"context_line":"we can use that instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1367952"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_660ffd88","line":10,"updated":"2014-09-11 19:29:10.000000000","message":"(NIT) s/identiyt/identity","commit_id":"263f2e27383ed01b788d27c40ec2a30b082d0734"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"751720310e7aa245f2295049503deeddbbf6c8fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Safer check for enabled in trusts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For some LDAP backends, the enable attribute is not"},{"line_number":10,"context_line":"directly set.  Since we have a wrapper function in identity/core,"},{"line_number":11,"context_line":"we can use that instead."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_3cc15380","line":9,"updated":"2014-09-14 12:54:41.000000000","message":"change \"enable\" to \"enabled\"","commit_id":"20eb5f40869e7ef9368292b6295290e1f6a6dcda"}],"keystone/token/providers/common.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b3dbeaf03618d7667ea6b1c65d40ea4a6aaba4b","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            trustor_user_ref \u003d (self.identity_api.get_user("},{"line_number":218,"context_line":"                                trust[\u0027trustor_user_id\u0027]))"},{"line_number":219,"context_line":"            try:"},{"line_number":220,"context_line":"                self.identity_api.assert_user_enabled(trust[\u0027trustor_user_id\u0027])"},{"line_number":221,"context_line":"            except AssertionError:"},{"line_number":222,"context_line":"                raise exception.Forbidden(_(\u0027Trustor is disabled.\u0027))"},{"line_number":223,"context_line":"            if trust[\u0027impersonation\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_09329da6","line":220,"updated":"2014-09-12 22:58:39.000000000","message":"can a test be added for this?","commit_id":"20eb5f40869e7ef9368292b6295290e1f6a6dcda"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"45eaa29a1d3587e8eaf105dbeabc55055519a41e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            trustor_user_ref \u003d (self.identity_api.get_user("},{"line_number":218,"context_line":"                                trust[\u0027trustor_user_id\u0027]))"},{"line_number":219,"context_line":"            try:"},{"line_number":220,"context_line":"                self.identity_api.assert_user_enabled(trust[\u0027trustor_user_id\u0027])"},{"line_number":221,"context_line":"            except AssertionError:"},{"line_number":222,"context_line":"                raise exception.Forbidden(_(\u0027Trustor is disabled.\u0027))"},{"line_number":223,"context_line":"            if trust[\u0027impersonation\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_8aa358b0","line":220,"in_reply_to":"fa98f980_09329da6","updated":"2014-09-18 15:36:38.000000000","message":"What would I test?  It was  bypassing the public API and going right to the data specific to the provider;  I corrected it.  The logic is the same.  I could make a test that shows that it was broken before, but, unless we revert this exact change, that test is kindof useless.  And a test won\u0027t be able to prevent someone from doing this somewhere else.","commit_id":"20eb5f40869e7ef9368292b6295290e1f6a6dcda"}]}