)]}'
{"keystone/tests/test_v3_assignment.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"59ea0c17c60a0fa3c6107596c01706234f58a34e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_22182f1d","line":1,"updated":"2014-09-15 18:55:39.000000000","message":"I think that you should remove this","commit_id":"2b2f90827ef05204b8fb7cc0192d6868a1c1cd08"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"924ecc7d03aad14ab4a00a6204fc8562fdeb09f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0549328e","line":1,"in_reply_to":"fa98f980_22182f1d","updated":"2014-09-17 20:29:22.000000000","message":"copyright info \n\nhttp://lists.openstack.org/pipermail/legal-discuss/2013-April/000010.html\n\nhttps://wiki.openstack.org/wiki/LegalIssuesFAQ#Copyright_Headers\n\nThere is a wiki out there somewhere that explains who can add OpenStack Foundation Copyright, but I don\u0027t think I found it.","commit_id":"2b2f90827ef05204b8fb7cc0192d6868a1c1cd08"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c135041c4e0eff7186dd308fea3673f3857dda6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_a97087a4","line":1,"updated":"2014-10-08 21:10:17.000000000","message":"This can be removed","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"32162799465fd2853f395f9272f88a6bca6a7440","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_46360bb6","line":1,"in_reply_to":"baa201ad_a97087a4","updated":"2014-10-09 18:03:25.000000000","message":"Done","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c135041c4e0eff7186dd308fea3673f3857dda6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            self.credential_id,"},{"line_number":98,"context_line":"            self.credential)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    # Domain CRUD tests"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_create_domain(self):"},{"line_number":103,"context_line":"        \"\"\"Call ``POST /domains``.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c9986bc2","line":100,"updated":"2014-10-08 21:10:17.000000000","message":"I wonder if these should be there own TestCases?","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c135041c4e0eff7186dd308fea3673f3857dda6","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                  headers\u003d{\u0027x-subject-token\u0027: subject_token},"},{"line_number":429,"context_line":"                  expected_status\u003d404)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    # Project CRUD tests"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def test_list_projects(self):"},{"line_number":434,"context_line":"        \"\"\"Call ``GET /projects``.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_49ec7b2a","line":431,"updated":"2014-10-08 21:10:17.000000000","message":"Same here.","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c135041c4e0eff7186dd308fea3673f3857dda6","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        self.head(member_url, expected_status\u003d204)"},{"line_number":754,"context_line":"        return member_url, user_ref"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    # TODO(lbragstad): Move this test to tests/test_v3_assignment.py"},{"line_number":757,"context_line":"    def test_delete_user_before_removing_role_assignment_succeeds(self):"},{"line_number":758,"context_line":"        \"\"\"Call ``DELETE`` on the user before the role assignment.\"\"\""},{"line_number":759,"context_line":"        member_url, user \u003d self._create_new_user_and_assign_role_on_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_891f435a","line":756,"updated":"2014-10-08 21:10:17.000000000","message":"This could probably be removed","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"32162799465fd2853f395f9272f88a6bca6a7440","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        self.head(member_url, expected_status\u003d204)"},{"line_number":754,"context_line":"        return member_url, user_ref"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    # TODO(lbragstad): Move this test to tests/test_v3_assignment.py"},{"line_number":757,"context_line":"    def test_delete_user_before_removing_role_assignment_succeeds(self):"},{"line_number":758,"context_line":"        \"\"\"Call ``DELETE`` on the user before the role assignment.\"\"\""},{"line_number":759,"context_line":"        member_url, user \u003d self._create_new_user_and_assign_role_on_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c6dbdb7b","line":756,"in_reply_to":"baa201ad_891f435a","updated":"2014-10-09 18:03:25.000000000","message":"Done","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c135041c4e0eff7186dd308fea3673f3857dda6","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        # Make sure the role is gone"},{"line_number":765,"context_line":"        self.head(member_url, expected_status\u003d404)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    # TODO(lbragstad): Move this test to tests/test_v3_assignment.py"},{"line_number":768,"context_line":"    def test_delete_user_and_check_role_assignment_fails(self):"},{"line_number":769,"context_line":"        \"\"\"Call ``DELETE`` on the user and check the role assignment.\"\"\""},{"line_number":770,"context_line":"        member_url, user \u003d self._create_new_user_and_assign_role_on_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_e937efe0","line":767,"updated":"2014-10-08 21:10:17.000000000","message":"Same comment here","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"32162799465fd2853f395f9272f88a6bca6a7440","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        # Make sure the role is gone"},{"line_number":765,"context_line":"        self.head(member_url, expected_status\u003d404)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    # TODO(lbragstad): Move this test to tests/test_v3_assignment.py"},{"line_number":768,"context_line":"    def test_delete_user_and_check_role_assignment_fails(self):"},{"line_number":769,"context_line":"        \"\"\"Call ``DELETE`` on the user and check the role assignment.\"\"\""},{"line_number":770,"context_line":"        member_url, user \u003d self._create_new_user_and_assign_role_on_project()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_e6d8df81","line":767,"in_reply_to":"baa201ad_e937efe0","updated":"2014-10-09 18:03:25.000000000","message":"Done","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c135041c4e0eff7186dd308fea3673f3857dda6","unresolved":false,"context_lines":[{"line_number":821,"context_line":"                  headers\u003d{\u0027x-subject-token\u0027: token},"},{"line_number":822,"context_line":"                  expected_status\u003d404)"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    # Role Assignments tests"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def test_get_role_assignments(self):"},{"line_number":827,"context_line":"        \"\"\"Call ``GET /role_assignments``."}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_e9c1af80","line":824,"updated":"2014-10-08 21:10:17.000000000","message":"Same here","commit_id":"79e0afb2f80afa54736e452d56d02e88c7c8482e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"54510e948cf01d92c3ddabb4c924f89bc2f3ee5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_ecc60249","line":1,"updated":"2014-10-20 00:12:20.000000000","message":"This file should be renamed to test_assignment.py . There wasn\u0027t an assignment backend when we had v2, so no need to specify the API version. Also, most of these tests use the backend and not the API so mentioning the version doesn\u0027t make sense.","commit_id":"87d14849512bc890514827923db3ed323b1b4071"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7bf4abfd6ec65546d499f450c4bbe40e04ffcdd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_56bcf06c","line":1,"in_reply_to":"9aa7fdbe_ecc60249","updated":"2014-10-20 11:58:21.000000000","message":"It makes sense to not specify the API version on the file name. I\u0027d like to follow the pattern we have for other files though. Should we rename the other ones?\n\nJust to clarify, tests in this file use the backend in order to set up the test scenario, i.e., create the needed entities. I think this is done this way for simplicity.\nAfter this, API calls are done to test what the method is supposed to.","commit_id":"87d14849512bc890514827923db3ed323b1b4071"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"54510e948cf01d92c3ddabb4c924f89bc2f3ee5a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self.credential_id,"},{"line_number":96,"context_line":"            self.credential)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # Domain CRUD tests"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_create_domain(self):"},{"line_number":101,"context_line":"        \"\"\"Call ``POST /domains``.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_6c94d237","line":98,"updated":"2014-10-20 00:12:20.000000000","message":"it would be great if we could get rid of these comments.","commit_id":"87d14849512bc890514827923db3ed323b1b4071"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7bf4abfd6ec65546d499f450c4bbe40e04ffcdd1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self.credential_id,"},{"line_number":96,"context_line":"            self.credential)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # Domain CRUD tests"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_create_domain(self):"},{"line_number":101,"context_line":"        \"\"\"Call ``POST /domains``.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_56823053","line":98,"in_reply_to":"9aa7fdbe_6c94d237","updated":"2014-10-20 11:58:21.000000000","message":"I would like to maintain these comments because I think it makes easier to developers to find tests for a given entity.\n\nIn fact, what I really would like to do was to create different test classes for different entities. This is better described on an etherpad I created for tests improvements. Take a look at section \u0027Tests Modularization\u0027 at [1].\n\n[1] https://etherpad.openstack.org/p/Keystone_Tests_Improvement","commit_id":"87d14849512bc890514827923db3ed323b1b4071"}]}