)]}'
{"keystone/tests/test_backend_ldap.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f8770101ca83f8b099199a6f19efb6a870dcdd9a","unresolved":false,"context_lines":[{"line_number":2260,"context_line":"                       self.domains[\u0027domain3\u0027][\u0027id\u0027],"},{"line_number":2261,"context_line":"                       self.domains[\u0027domain4\u0027][\u0027id\u0027]]:"},{"line_number":2262,"context_line":"            check_user(self.users[\u0027user2\u0027], domain, exception.UserNotFound)"},{"line_number":2263,"context_line":""},{"line_number":2264,"context_line":"        # Domains 3 and 4 share the same backend, so you should be"},{"line_number":2265,"context_line":"        # able to see user3 and 4 from either"},{"line_number":2266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_dc6395af","line":2263,"updated":"2014-09-22 16:53:34.000000000","message":"Change it here as well, then, to remain consistent?","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1c08ab05bf871c4d702f8eb7037c19a905425d02","unresolved":false,"context_lines":[{"line_number":2260,"context_line":"                       self.domains[\u0027domain3\u0027][\u0027id\u0027],"},{"line_number":2261,"context_line":"                       self.domains[\u0027domain4\u0027][\u0027id\u0027]]:"},{"line_number":2262,"context_line":"            check_user(self.users[\u0027user2\u0027], domain, exception.UserNotFound)"},{"line_number":2263,"context_line":""},{"line_number":2264,"context_line":"        # Domains 3 and 4 share the same backend, so you should be"},{"line_number":2265,"context_line":"        # able to see user3 and 4 from either"},{"line_number":2266,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_76ef25b1","line":2263,"in_reply_to":"da9df570_dc6395af","updated":"2014-09-22 18:51:55.000000000","message":"Done","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f3799ce4fcdad94c0bda13f4651ec1d6d5534c79","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"                self.identity_api.list_users(domain_scope\u003ddomain),"},{"line_number":2293,"context_line":"                matchers.HasLength(1))"},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"        # domain3 had a user created before we switched on"},{"line_number":2296,"context_line":"        # multiple backends, plus one created afterwards - and its"},{"line_number":2297,"context_line":"        # backend has not changed - so we should find two."},{"line_number":2298,"context_line":"        self.assertThat("}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_1458a455","line":2295,"updated":"2014-09-22 08:34:05.000000000","message":"To keep with the style of commenting in this method, I would leave \u0027domain3\u0027 with a capital \u0027D\u0027.","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"ef4be943791c0695963caac0db9b68a94582866e","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"                self.identity_api.list_users(domain_scope\u003ddomain),"},{"line_number":2293,"context_line":"                matchers.HasLength(1))"},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"        # domain3 had a user created before we switched on"},{"line_number":2296,"context_line":"        # multiple backends, plus one created afterwards - and its"},{"line_number":2297,"context_line":"        # backend has not changed - so we should find two."},{"line_number":2298,"context_line":"        self.assertThat("}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_d7037971","line":2295,"in_reply_to":"da9df570_1458a455","updated":"2014-09-22 12:44:31.000000000","message":"++","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dc87e6f15b8233cb1f9893868306c8555e275611","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"                self.identity_api.list_users(domain_scope\u003ddomain),"},{"line_number":2293,"context_line":"                matchers.HasLength(1))"},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"        # domain3 had a user created before we switched on"},{"line_number":2296,"context_line":"        # multiple backends, plus one created afterwards - and its"},{"line_number":2297,"context_line":"        # backend has not changed - so we should find two."},{"line_number":2298,"context_line":"        self.assertThat("}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_8d48fd5c","line":2295,"in_reply_to":"da9df570_1458a455","updated":"2014-09-22 14:04:24.000000000","message":"Kept it lowercase since it\u0027s a variable","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"e7df2bd6b631adf4cd2f34224d84dd02938700f3","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"                self.identity_api.list_users(domain_scope\u003ddomain),"},{"line_number":2293,"context_line":"                matchers.HasLength(1))"},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"        # domain3 had a user created before we switched on"},{"line_number":2296,"context_line":"        # multiple backends, plus one created afterwards - and its"},{"line_number":2297,"context_line":"        # backend has not changed - so we should find two."},{"line_number":2298,"context_line":"        self.assertThat("}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_ad05c1c3","line":2295,"in_reply_to":"da9df570_8d48fd5c","updated":"2014-09-22 14:12:04.000000000","message":"OK","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f8770101ca83f8b099199a6f19efb6a870dcdd9a","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"                self.identity_api.list_users(domain_scope\u003ddomain),"},{"line_number":2293,"context_line":"                matchers.HasLength(1))"},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"        # domain3 had a user created before we switched on"},{"line_number":2296,"context_line":"        # multiple backends, plus one created afterwards - and its"},{"line_number":2297,"context_line":"        # backend has not changed - so we should find two."},{"line_number":2298,"context_line":"        self.assertThat("}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_dc0ab5d1","line":2295,"in_reply_to":"da9df570_ad05c1c3","updated":"2014-09-22 16:53:34.000000000","message":"My point was, that if you want to fix that (and I don\u0027t disagree that your change is for the better), then we should also change this on line 2264 - that\u0027s what I meant by staying consistent with how the rest of the method was written.","commit_id":"4254f6bc97b646003a5c707cf2970cce122f720a"}]}