)]}'
{"keystone/tests/test_sql_upgrade.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4f1f364a5d225c7deff13d261b4192cf6eca0c70","unresolved":false,"context_lines":[{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"INITIAL_DROP_TABLE_SEQUENCE \u003d ["},{"line_number":131,"context_line":"    # First, the set of tables to which nobody has FKs"},{"line_number":132,"context_line":"    \u0027credential\u0027, \u0027endpoint\u0027, \u0027group_domain_metadata\u0027,"},{"line_number":133,"context_line":"    \u0027group_project_metadata\u0027, \u0027policy\u0027, \u0027role\u0027, \u0027token\u0027, \u0027trust_role\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_ef33dd5f","line":130,"updated":"2014-10-03 15:17:24.000000000","message":"Instead of having to manually manage all of this stuff by hand I think we should use an algorithm similar to what oslo.db uses. They delete all of the constraints so that they can delete the tables in any order: http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo/db/sqlalchemy/test_migrations.py#n483","commit_id":"e9de141fcdc543f9093e094c59bd8ee77e194840"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9d50e691e5f1864edfa46aa10e166ec136850ab2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"INITIAL_DROP_TABLE_SEQUENCE \u003d ["},{"line_number":131,"context_line":"    # First, the set of tables to which nobody has FKs"},{"line_number":132,"context_line":"    \u0027credential\u0027, \u0027endpoint\u0027, \u0027group_domain_metadata\u0027,"},{"line_number":133,"context_line":"    \u0027group_project_metadata\u0027, \u0027policy\u0027, \u0027role\u0027, \u0027token\u0027, \u0027trust_role\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_6c129058","line":130,"in_reply_to":"baa201ad_ef33dd5f","updated":"2014-10-03 23:48:31.000000000","message":"I agree with this comment. Generally speaking manually managing the order is going to be largely unmaintainable in the long run.","commit_id":"e9de141fcdc543f9093e094c59bd8ee77e194840"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"10fce904602f04963d8c79f804385e77f763aee7","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"            table\u003dregion_unique_table)"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        # migrate to 43, unique constraint should be dropped"},{"line_number":1269,"context_line":"        session.close()"},{"line_number":1270,"context_line":"        self.upgrade(43)"},{"line_number":1271,"context_line":"        session \u003d self.Session()"},{"line_number":1272,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_9d3abdcb","line":1269,"updated":"2014-10-01 18:02:27.000000000","message":"should really use context manager for all these, but looks fine as-is","commit_id":"e9de141fcdc543f9093e094c59bd8ee77e194840"}]}