)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"fa0b84fb2a64f568711c4d2fcf3f0581af2216a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wanghong \u003cw.wanghong@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-09 11:28:39 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"wrong order of assertEqual args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Wrong order of assertEqual args in assertValidRoleAssignmentListResponse"},{"line_number":10,"context_line":"method."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baa201ad_81d38fd3","line":7,"updated":"2014-10-09 07:48:21.000000000","message":"Could you please describe what the commit does and not what was before it?","commit_id":"48d1b5b738d1afe0ec662df62ede72d52644743b"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"46c82d6e5cd8447cf01ecbd48267d518926bc502","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wanghong \u003cw.wanghong@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-10 09:47:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix the wrong order of assertEqual args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix the wrong order of assertEqual args in"},{"line_number":10,"context_line":"assertValidRoleAssignmentListResponse method."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_445eb277","line":7,"updated":"2014-10-13 23:10:40.000000000","message":"Would be nice to indicate where the fix was made","commit_id":"7812bfe2732edbb33bd96090568d629e8e4f440c"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"46c82d6e5cd8447cf01ecbd48267d518926bc502","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix the wrong order of assertEqual args"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix the wrong order of assertEqual args in"},{"line_number":10,"context_line":"assertValidRoleAssignmentListResponse method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I021051b385bf1206167b955af58be6d334aeb047"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_e47966fd","line":10,"updated":"2014-10-13 23:10:40.000000000","message":"This doesn\u0027t match the method modified","commit_id":"7812bfe2732edbb33bd96090568d629e8e4f440c"}],"keystone/tests/test_v3.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"12cbd66da0e191a70b6b5f29f9b5efc093bb7e80","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        self.assertIsNotNone(entities)"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        if expected_length is not None:"},{"line_number":548,"context_line":"            self.assertEqual(len(entities), expected_length)"},{"line_number":549,"context_line":"        elif ref is not None:"},{"line_number":550,"context_line":"            # we\u0027re at least expecting the ref"},{"line_number":551,"context_line":"            self.assertNotEmpty(entities)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_a4583e57","side":"PARENT","line":548,"updated":"2014-10-13 23:16:51.000000000","message":"This seems correct.\n\nThe test is based from oslotest, and the sample test I found in there have the expected result as second argument.\n\nhttps://github.com/openstack/oslotest/blob/356f0603ca4af81527c80a00e04149a92aabdd7f/tests/unit/test_base.py","commit_id":"9025b64a8f2bf5cf01a18453d6728e081bd2c3b9"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"2a2e221b00380ebe71e4a7c418e30bef41df766e","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        self.assertIsNotNone(entities)"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        if expected_length is not None:"},{"line_number":548,"context_line":"            self.assertEqual(len(entities), expected_length)"},{"line_number":549,"context_line":"        elif ref is not None:"},{"line_number":550,"context_line":"            # we\u0027re at least expecting the ref"},{"line_number":551,"context_line":"            self.assertNotEmpty(entities)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_23c2b4e9","side":"PARENT","line":548,"in_reply_to":"baa201ad_930e1a31","updated":"2014-10-21 04:12:54.000000000","message":"thanks for the resposne","commit_id":"9025b64a8f2bf5cf01a18453d6728e081bd2c3b9"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"bc917252ed0c53e366d620a020e5598807ced039","unresolved":false,"context_lines":[{"line_number":545,"context_line":"        self.assertIsNotNone(entities)"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        if expected_length is not None:"},{"line_number":548,"context_line":"            self.assertEqual(len(entities), expected_length)"},{"line_number":549,"context_line":"        elif ref is not None:"},{"line_number":550,"context_line":"            # we\u0027re at least expecting the ref"},{"line_number":551,"context_line":"            self.assertNotEmpty(entities)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_930e1a31","side":"PARENT","line":548,"in_reply_to":"baa201ad_a4583e57","updated":"2014-10-14 03:53:42.000000000","message":"The file itself has conflict, you can see: https://github.com/openstack/oslotest/blob/356f0603ca4af81527c80a00e04149a92aabdd7f/tests/unit/test_base.py#L137\n\nAlso, you can see the define of assertEqual method in testtools/testcase.py:316, the expected is first parameter.","commit_id":"9025b64a8f2bf5cf01a18453d6728e081bd2c3b9"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d069103e27b254078cf69fda83bdd1796ca91175","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"        application \u003d None"},{"line_number":1243,"context_line":"        middleware.AuthContextMiddleware(application).process_request(req)"},{"line_number":1244,"context_line":"        self.assertEqual("},{"line_number":1245,"context_line":"            req.environ.get(authorization.AUTH_CONTEXT_ENV)[\u0027user_id\u0027],"},{"line_number":1246,"context_line":"            self.user[\u0027id\u0027])"},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"    def test_auth_context_override(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_19088b90","line":1245,"updated":"2014-10-14 06:53:45.000000000","message":"isn\u0027t self.user a reference here?","commit_id":"057e31ea8abdf92e535134d13c43e1a0686ba64e"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d069103e27b254078cf69fda83bdd1796ca91175","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"        application \u003d None"},{"line_number":1255,"context_line":"        middleware.AuthContextMiddleware(application).process_request(req)"},{"line_number":1256,"context_line":"        # make sure overridden context take precedence"},{"line_number":1257,"context_line":"        self.assertEqual(req.environ.get(authorization.AUTH_CONTEXT_ENV),"},{"line_number":1258,"context_line":"                         overridden_context)"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"    def test_admin_token_auth_context(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_79f8b77c","line":1257,"updated":"2014-10-14 06:53:45.000000000","message":"isn\u0027t overriden_context a reference here?","commit_id":"057e31ea8abdf92e535134d13c43e1a0686ba64e"}]}