)]}'
{"doc/source/configure_federation.rst":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"62c655774ab974e8beca9b6841fe37068c584685","unresolved":false,"context_lines":[{"line_number":201,"context_line":"A protocol contains information that dictates which Mapping rules to use for an incoming"},{"line_number":202,"context_line":"request made by an IdP. An IdP may have multiple supported protocols."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"In the case of SAML2 federation, and in order to be able to authenticate with the SAML authentication plugins shipped with the keystoneclient library, the protocol **must** be named ``saml2`` as shown above in the Apache configuration sample."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"Add `Protocol object"},{"line_number":207,"context_line":"\u003chttps://github.com/openstack/identity-api/blob/master/v3/src/markdown/identity-api-v3-os-federation-ext.md#add-a-supported-protocol-and-attribute-mapping-combination-to-an-identity-provider-put-os-federationidentity_providersidp_idprotocolsprotocol_id\u003e`__ and specify the mapping id"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa201ad_c6454916","line":204,"updated":"2014-10-13 22:08:25.000000000","message":"I think this line needs to be wrapped to be shorter.\n\nSee https://wiki.openstack.org/wiki/Documentation/DocBook_conventions#Avoid_long_lines\n\nThe length is not strictly followed in this doc though, however would still be nice to wrap the line for readability and consistency.","commit_id":"b8af874635adee252f420bb6b7f4545692bc995b"},{"author":{"_account_id":6534,"name":"David Chadwick","email":"d.w.chadwick@truetrust.co.uk","username":"d-w-chadwick"},"change_message_id":"b414cacb44c989fb3e5b72c7ac8bbbed43d22f08","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"A protocol contains information that dictates which Mapping rules to use for an incoming"},{"line_number":202,"context_line":"request made by an IdP. An IdP may have multiple supported protocols."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"In the case of SAML2 federation, and in order to be able to authenticate with"},{"line_number":205,"context_line":"the SAML authentication plugins shipped with the keystoneclient library, the"},{"line_number":206,"context_line":"protocol **must** be named ``saml2`` as shown above in the Apache configuration sample."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baa201ad_1ca761a8","line":203,"updated":"2014-10-15 17:16:41.000000000","message":"This is conceptually wrong. The protocol field should tell keystone which protocol handling module to use in order to decode the incoming authentication information, and that is all.\n\nWhich mapping rule to use should be independent of the protocol i.e. the same mapping rule(s) can be used by multiple protocols, or it should be possible to specify that no mapping rules are to be used for a particular IDP/protocol combination. It is not possible at the current time to do the latter.\n\nFurthermore, it should be possible to change the mapping rules to be used without changing an IdP/Protocol combination.","commit_id":"ae625a6da2fdbd0e1c8b7d565ca8668216426eab"}]}