)]}'
{"keystone/common/serializer.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d73f63d618bc62513cdc510dd7f5869b56d2d3d5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"DOCTYPE \u003d \u0027\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e\u0027"},{"line_number":30,"context_line":"XMLNS \u003d \u0027http://docs.openstack.org/identity/api/v2.0\u0027"},{"line_number":31,"context_line":"XMLNS_OS_KSADM \u003d {"},{"line_number":32,"context_line":"    \u0027value\u0027: \u0027http://docs.openstack.org/identity/api/ext/OS-KSADM/v1.0\u0027,"},{"line_number":33,"context_line":"    \u0027prefix\u0027: \u0027OS-KSADM\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FbDU%3D","line":30,"updated":"2012-09-12 15:16:05.000000000","message":"There are more namespaces (i.e. other extensions) that could be supported in this manner. Can you make this implementation more generic, e.g.:\n\n    XMLNS_LIST \u003d [\n        {\n            \u0027value\u0027: \u0027\u0027http://docs.openstack.org/identity/api/v2.0\u0027,\n         }, {\n            \u0027prefix\u0027: \u0027OS-KSADM\u0027,\n            \u0027value\u0027: \u0027http://docs.openstack.org/identity/api/ext/OS-KSADM/v1.0\u0027,\n         },\n    ]\n\nAnd then instead of hardcoding the reference in _tag_name, iterate over the list above and prefix appropriately.","commit_id":"18a59789f8db9512c9ab3078fefe5c2b5c15cd7b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d73f63d618bc62513cdc510dd7f5869b56d2d3d5","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @staticmethod"},{"line_number":62,"context_line":"    def _tag_name(tag, namespace\u003dFalse):"},{"line_number":63,"context_line":"        \"\"\"Returns a tag name with the namespace prefix or not by"},{"line_number":64,"context_line":"        specifying the parameter namespace."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FbDI%3D","line":63,"updated":"2012-09-12 15:16:05.000000000","message":"see HACKING for appropriate docstring format","commit_id":"18a59789f8db9512c9ab3078fefe5c2b5c15cd7b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d73f63d618bc62513cdc510dd7f5869b56d2d3d5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        #If the namespace is"},{"line_number":74,"context_line":"        #http://docs.openstack.org/identity/api/ext/OS-KSADM/v1.0"},{"line_number":75,"context_line":"        #for the root element, a prefix needs to add in front of the tag name."},{"line_number":76,"context_line":"        if XMLNS_OS_KSADM[\u0027value\u0027] \u003d\u003d ns:"},{"line_number":77,"context_line":"            return \u0027%(PREFIX)s:%(tag_name)s\u0027 \\"},{"line_number":78,"context_line":"                % {\u0027PREFIX\u0027: XMLNS_OS_KSADM[\u0027prefix\u0027], \u0027tag_name\u0027: tag_name}"},{"line_number":79,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FbDM%3D","line":76,"updated":"2012-09-12 15:16:05.000000000","message":"iterate over the list here","commit_id":"18a59789f8db9512c9ab3078fefe5c2b5c15cd7b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d73f63d618bc62513cdc510dd7f5869b56d2d3d5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            return tag_name"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def walk_element(self, element, namespace\u003dFalse):"},{"line_number":83,"context_line":"        \"\"\"Populates a dictionary by walking an etree element.\"\"\""},{"line_number":84,"context_line":"        values \u003d {}"},{"line_number":85,"context_line":"        for k, v in element.attrib.iteritems():"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FbD0%3D","line":82,"updated":"2012-09-12 15:16:05.000000000","message":"The default value of namespace is defined twice, as False. I don\u0027t see a reason it needs to be defined more than once?","commit_id":"18a59789f8db9512c9ab3078fefe5c2b5c15cd7b"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"d73f63d618bc62513cdc510dd7f5869b56d2d3d5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        m \u003d re.search(\u0027[^:]+$\u0027, name)"},{"line_number":126,"context_line":"        root_name \u003d m.string[m.start():]"},{"line_number":127,"context_line":"        prefix \u003d m.string[0:m.start() - 1]"},{"line_number":128,"context_line":"        if XMLNS_OS_KSADM[\u0027prefix\u0027] \u003d\u003d prefix:"},{"line_number":129,"context_line":"            xmlns \u003d XMLNS_OS_KSADM[\u0027value\u0027]"},{"line_number":130,"context_line":"        # only the root dom element gets an xlmns"},{"line_number":131,"context_line":"        root \u003d etree.Element(root_name, xmlns\u003d(xmlns or XMLNS))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FbDQ%3D","line":128,"updated":"2012-09-12 15:16:05.000000000","message":"iterate over the list here","commit_id":"18a59789f8db9512c9ab3078fefe5c2b5c15cd7b"}]}