)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cf83a29abda4450d03c71265b9c15c25f177f499","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                controlValue\u003d(self.page_size, \u0027\u0027))"},{"line_number":973,"context_line":"            page_ctrl_oid \u003d ldap.LDAP_CONTROL_PAGE_OID"},{"line_number":974,"context_line":"        else:"},{"line_number":975,"context_line":"            lc \u003d ldap.controls.SimplePagedResultsControl("},{"line_number":976,"context_line":"                criticality\u003dTrue,"},{"line_number":977,"context_line":"                size\u003dself.page_size,"},{"line_number":978,"context_line":"                cookie\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_115fdf0f","line":975,"updated":"2014-10-19 19:15:52.000000000","message":"The docs say the class is ldap.controls.libldap.SimplePagedResultsControl rather than ldap.controls.SimplePagedResultsControl : http://www.python-ldap.org/doc/html/ldap-\ncontrols.html#ldap.controls.libldap.SimplePagedResultsControl\n\n(I don\u0027t have a python-ldap 2.4 system here so I can only go by the documentation.)","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"7252c72cf61e94d4d3d49ec3184b7a6e7cf00963","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                controlValue\u003d(self.page_size, \u0027\u0027))"},{"line_number":973,"context_line":"            page_ctrl_oid \u003d ldap.LDAP_CONTROL_PAGE_OID"},{"line_number":974,"context_line":"        else:"},{"line_number":975,"context_line":"            lc \u003d ldap.controls.SimplePagedResultsControl("},{"line_number":976,"context_line":"                criticality\u003dTrue,"},{"line_number":977,"context_line":"                size\u003dself.page_size,"},{"line_number":978,"context_line":"                cookie\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_6736ad05","line":975,"in_reply_to":"9aa7fdbe_115fdf0f","updated":"2014-10-20 03:05:17.000000000","message":"Interesting.  I followed the in-tree simple paged result example from python-ldap.  I\u0027ll try out the class as described in the docs and use it (assuming it works of course).  I did test this patch with python-ldap 2.4.x, and it works properly.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cf83a29abda4450d03c71265b9c15c25f177f499","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                criticality\u003dTrue,"},{"line_number":977,"context_line":"                size\u003dself.page_size,"},{"line_number":978,"context_line":"                cookie\u003d\u0027\u0027)"},{"line_number":979,"context_line":"            page_ctrl_oid \u003d ldap.controls.SimplePagedResultsControl.controlType"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        base_utf8 \u003d utf8_encode(base)"},{"line_number":982,"context_line":"        filterstr_utf8 \u003d utf8_encode(filterstr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_319b03cb","line":979,"updated":"2014-10-19 19:15:52.000000000","message":"The docs don\u0027t have controlType as an attribute of SimplePagedResultsControl","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"7252c72cf61e94d4d3d49ec3184b7a6e7cf00963","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                criticality\u003dTrue,"},{"line_number":977,"context_line":"                size\u003dself.page_size,"},{"line_number":978,"context_line":"                cookie\u003d\u0027\u0027)"},{"line_number":979,"context_line":"            page_ctrl_oid \u003d ldap.controls.SimplePagedResultsControl.controlType"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        base_utf8 \u003d utf8_encode(base)"},{"line_number":982,"context_line":"        filterstr_utf8 \u003d utf8_encode(filterstr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_8712b160","line":979,"in_reply_to":"9aa7fdbe_319b03cb","updated":"2014-10-20 03:05:17.000000000","message":"This comes from the base class for all request controls (RequestControl):\n\n  http://www.python-ldap.org/doc/html/ldap-controls.html#ldap.controls.RequestControl\n\nThis is also the way that the python-ldap in-tree simple paged results example demonstrates use of the API.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cf83a29abda4450d03c71265b9c15c25f177f499","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"                    lc.controlValue \u003d (self.page_size, cookie)"},{"line_number":1006,"context_line":"                else:"},{"line_number":1007,"context_line":"                    cookie \u003d pctrls[0].cookie"},{"line_number":1008,"context_line":"                    lc.cookie \u003d cookie"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"                if cookie:"},{"line_number":1011,"context_line":"                    # There is more data still on the server"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_d1ab97d4","line":1008,"updated":"2014-10-19 19:15:52.000000000","message":"suggest combine these lines.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"7252c72cf61e94d4d3d49ec3184b7a6e7cf00963","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"                    lc.controlValue \u003d (self.page_size, cookie)"},{"line_number":1006,"context_line":"                else:"},{"line_number":1007,"context_line":"                    cookie \u003d pctrls[0].cookie"},{"line_number":1008,"context_line":"                    lc.cookie \u003d cookie"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"                if cookie:"},{"line_number":1011,"context_line":"                    # There is more data still on the server"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_8257ff01","line":1008,"in_reply_to":"9aa7fdbe_d1ab97d4","updated":"2014-10-20 03:05:17.000000000","message":"Will do.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cf83a29abda4450d03c71265b9c15c25f177f499","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                if cookie:"},{"line_number":1011,"context_line":"                    # There is more data still on the server"},{"line_number":1012,"context_line":"                    # so we request another page"},{"line_number":1013,"context_line":"                    lc.controlValue \u003d (self.page_size, cookie)"},{"line_number":1014,"context_line":"                    msgid \u003d self.conn.search_ext(base_utf8,"},{"line_number":1015,"context_line":"                                                 scope,"},{"line_number":1016,"context_line":"                                                 filterstr_utf8,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_b1ae13e6","line":1013,"updated":"2014-10-19 19:15:52.000000000","message":"Get rid of this since it was set at line 1005 or 1008","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"7252c72cf61e94d4d3d49ec3184b7a6e7cf00963","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"                if cookie:"},{"line_number":1011,"context_line":"                    # There is more data still on the server"},{"line_number":1012,"context_line":"                    # so we request another page"},{"line_number":1013,"context_line":"                    lc.controlValue \u003d (self.page_size, cookie)"},{"line_number":1014,"context_line":"                    msgid \u003d self.conn.search_ext(base_utf8,"},{"line_number":1015,"context_line":"                                                 scope,"},{"line_number":1016,"context_line":"                                                 filterstr_utf8,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_a25c0327","line":1013,"in_reply_to":"9aa7fdbe_b1ae13e6","updated":"2014-10-20 03:05:17.000000000","message":"Will do.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"}],"keystone/tests/unit/common/test_ldap.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cf83a29abda4450d03c71265b9c15c25f177f499","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self.load_backends()"},{"line_number":363,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.addCleanup(common_ldap_core._HANDLERS.clear)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def clear_database(self):"},{"line_number":368,"context_line":"        for shelf in fakeldap.FakeShelves:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_11b6ff3d","line":365,"updated":"2014-10-19 19:15:52.000000000","message":"this should be moved right after line 361","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"7252c72cf61e94d4d3d49ec3184b7a6e7cf00963","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self.load_backends()"},{"line_number":363,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.addCleanup(common_ldap_core._HANDLERS.clear)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def clear_database(self):"},{"line_number":368,"context_line":"        for shelf in fakeldap.FakeShelves:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_4274379c","line":365,"in_reply_to":"9aa7fdbe_11b6ff3d","updated":"2014-10-20 03:05:17.000000000","message":"Will do.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cf83a29abda4450d03c71265b9c15c25f177f499","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        conn \u003d self.identity_api.user.get_connection()"},{"line_number":391,"context_line":"        conn._paged_search_s(\u0027dc\u003dexample,dc\u003dtest\u0027,"},{"line_number":392,"context_line":"                             ldap.SCOPE_SUBTREE,"},{"line_number":393,"context_line":"                             \u0027objectclass\u003d*\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_717cab73","line":393,"updated":"2014-10-19 19:15:52.000000000","message":"There\u0027s no assert in the test so what is it testing?","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"7252c72cf61e94d4d3d49ec3184b7a6e7cf00963","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        conn \u003d self.identity_api.user.get_connection()"},{"line_number":391,"context_line":"        conn._paged_search_s(\u0027dc\u003dexample,dc\u003dtest\u0027,"},{"line_number":392,"context_line":"                             ldap.SCOPE_SUBTREE,"},{"line_number":393,"context_line":"                             \u0027objectclass\u003d*\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_024b0f5a","line":393,"in_reply_to":"9aa7fdbe_717cab73","updated":"2014-10-20 03:05:17.000000000","message":"It\u0027s testing that an exception isn\u0027t thrown by _paged_search_s().  Before the actual fix from this patch, this test would trigger an AttributeError inside of _paged_search_s() when using python-ldap 2.4.x.","commit_id":"c0d2b0cea4a2ac5bc531907ebb976a523b6657ac"}]}