)]}'
{"keystone/catalog/backends/sql.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"836397b50284f7ed5d9c33f22506247435d4b98c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    #                 is required to have an \"extra\" column because of the"},{"line_number":48,"context_line":"    #                 DictBase in the keystone.common.sql.core module. Forcing"},{"line_number":49,"context_line":"    #                 tables to have pointless columns in the database is just"},{"line_number":50,"context_line":"    #                 bad. Remove all of this extra JSON blob stuff."},{"line_number":51,"context_line":"    #                 See: https://bugs.launchpad.net/keystone/+bug/1265071"},{"line_number":52,"context_line":"    extra \u003d sql.Column(sql.JsonBlob())"},{"line_number":53,"context_line":"    endpoints \u003d sqlalchemy.orm.relationship(\"Endpoint\", backref\u003d\"region\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_971f8cb6","side":"PARENT","line":50,"updated":"2014-10-26 23:02:44.000000000","message":"the extra JSON blob stuff hasn\u0027t been removed.","commit_id":"c259f6d10258d8dcfe6b3e35d70db3682213856f"}],"keystone/catalog/schema.py":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"ea8404fa5fb02a23d5f3a788c6071a70eae75daf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":31,"context_line":"    \u0027properties\u0027: _region_properties,"},{"line_number":32,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":33,"context_line":"    # NOTE(lbragstad): No parameters are required for creating regions."},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"region_update \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_15052b13","line":33,"updated":"2014-10-28 12:10:03.000000000","message":"Seems like next patch will be about removing this note :)","commit_id":"6c801c5517b7c2b31e2cb3598333e8ec51543e7d"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"e5f5bb43b9501dea105139c94a7f4d9619db8e2d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":31,"context_line":"    \u0027properties\u0027: _region_properties,"},{"line_number":32,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":33,"context_line":"    # NOTE(lbragstad): No parameters are required for creating regions."},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"region_update \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_e449c061","line":33,"in_reply_to":"9aa7fdbe_15052b13","updated":"2014-10-29 06:40:12.000000000","message":"I think this note is for \"required\" parameter.","commit_id":"6c801c5517b7c2b31e2cb3598333e8ec51543e7d"}],"keystone/tests/test_backend_sql.py":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"f4afe3417619cebfcd1bfb6ccd10a1dd74095e79","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        child_region \u003d {"},{"line_number":576,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":577,"context_line":"            \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":578,"context_line":"            \u0027parent_region_id\u0027: region[\u0027id\u0027]"},{"line_number":579,"context_line":"        }"},{"line_number":580,"context_line":"        self.catalog_api.create_region(child_region)"},{"line_number":581,"context_line":"        # create a service"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_f499a979","line":578,"updated":"2014-10-27 13:22:11.000000000","message":"I don\u0027t see how it related to \u0027todo\u0027 removal","commit_id":"17578cbdace079a6b4c874386664f1e58b624101"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"c16a63ec4ffe211308b293b39cf34ae8dc71edf7","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        child_region \u003d {"},{"line_number":576,"context_line":"            \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":577,"context_line":"            \u0027description\u0027: uuid.uuid4().hex,"},{"line_number":578,"context_line":"            \u0027parent_region_id\u0027: region[\u0027id\u0027]"},{"line_number":579,"context_line":"        }"},{"line_number":580,"context_line":"        self.catalog_api.create_region(child_region)"},{"line_number":581,"context_line":"        # create a service"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_b77c71ed","line":578,"in_reply_to":"9aa7fdbe_f499a979","updated":"2014-10-28 00:59:05.000000000","message":"According to the todo comment, he don\u0027t want region to have extra attribute. So, I remove it in this patch. That is say, region does not has extra now and because region does not have parent_id attribute, it will get an error when creating region.","commit_id":"17578cbdace079a6b4c874386664f1e58b624101"}]}