)]}'
{"keystone/catalog/backends/kvs.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f5433a4e2f96924438b984df7a52bfa96bd3afe7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        for child in children:"},{"line_number":37,"context_line":"            if child[\u0027id\u0027] \u003d\u003d root_region_id:"},{"line_number":38,"context_line":"                # Hit a circular region hierarchy"},{"line_number":39,"context_line":"                return"},{"line_number":40,"context_line":"            self._delete_child_regions(child[\u0027id\u0027], root_region_id)"},{"line_number":41,"context_line":"            self._delete_region(child[\u0027id\u0027])"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_05432faf","line":39,"updated":"2014-12-15 15:46:11.000000000","message":"a break would have also worked here.","commit_id":"e57729ca5f1364a41f6cd3e9579fba07cf19a613"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"f761e2b26a63c0b5af4f800440bb9ae67bf347e0","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                          self.catalog_api.create_region,"},{"line_number":3826,"context_line":"                          new_region)"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"    def test_can_not_create_circle_regions_via_region_update(self):"},{"line_number":3829,"context_line":"        region_one \u003d self._create_region_with_parent_id()"},{"line_number":3830,"context_line":""},{"line_number":3831,"context_line":"        # self circle: region_one-\u003eregion_one"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_37675cec","line":3828,"updated":"2014-11-19 13:11:03.000000000","message":"would change the test name to something like: test_avoid_creating_circular_references_in_regions_update()\n\ncircle_regions sounds a bit odd and does not make clear what is being tested.","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b551add088905521c253379f1b4e12f5c6e131","unresolved":false,"context_lines":[{"line_number":3834,"context_line":"                          region_one[\u0027id\u0027],"},{"line_number":3835,"context_line":"                          {\u0027parent_region_id\u0027: region_one[\u0027id\u0027]})"},{"line_number":3836,"context_line":""},{"line_number":3837,"context_line":"        # region_one-\u003ereiong_two-\u003eregion_one"},{"line_number":3838,"context_line":"        region_two \u003d self._create_region_with_parent_id(region_one[\u0027id\u0027])"},{"line_number":3839,"context_line":"        self.assertRaises(exception.CircularRegionHierarchyError,"},{"line_number":3840,"context_line":"                          self.catalog_api.update_region,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9ae93ae8","line":3837,"updated":"2014-11-18 16:42:03.000000000","message":"nit: region_two","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b551add088905521c253379f1b4e12f5c6e131","unresolved":false,"context_lines":[{"line_number":3841,"context_line":"                          region_one[\u0027id\u0027],"},{"line_number":3842,"context_line":"                          {\u0027parent_region_id\u0027: region_two[\u0027id\u0027]})"},{"line_number":3843,"context_line":""},{"line_number":3844,"context_line":"        # region_one region_tow-\u003eregion_three-\u003eregion_four-\u003eregion_two"},{"line_number":3845,"context_line":"        region_three \u003d self._create_region_with_parent_id(region_two[\u0027id\u0027])"},{"line_number":3846,"context_line":"        region_four \u003d self._create_region_with_parent_id(region_three[\u0027id\u0027])"},{"line_number":3847,"context_line":"        self.assertRaises(exception.CircularRegionHierarchyError,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_3ae3e6d9","line":3844,"updated":"2014-11-18 16:42:03.000000000","message":"nit: region_two","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b551add088905521c253379f1b4e12f5c6e131","unresolved":false,"context_lines":[{"line_number":3852,"context_line":"    @mock.patch.object(core.Driver,"},{"line_number":3853,"context_line":"                       \"_ensure_no_circle_in_hierarchical_regions\")"},{"line_number":3854,"context_line":"    def test_circular_regions_can_be_deleted(self, mock_ensure_on_circle):"},{"line_number":3855,"context_line":"        mock_ensure_on_circle.return_value \u003d None"},{"line_number":3856,"context_line":""},{"line_number":3857,"context_line":"        region_one \u003d self._create_region_with_parent_id()"},{"line_number":3858,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_ba6a7617","line":3855,"updated":"2014-11-18 16:42:03.000000000","message":"Should put a comment above this line to let others know this turns off the enforcement so that cycles can be created for the test.","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b551add088905521c253379f1b4e12f5c6e131","unresolved":false,"context_lines":[{"line_number":3860,"context_line":"        self.catalog_api.update_region("},{"line_number":3861,"context_line":"            region_one[\u0027id\u0027],"},{"line_number":3862,"context_line":"            {\u0027parent_region_id\u0027: region_one[\u0027id\u0027]})"},{"line_number":3863,"context_line":"        self.catalog_api.delete_region(region_one[\u0027id\u0027])"},{"line_number":3864,"context_line":""},{"line_number":3865,"context_line":"        # region_one-\u003eregion_two-\u003eregion_one"},{"line_number":3866,"context_line":"        region_one \u003d self._create_region_with_parent_id()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_fa423ea9","line":3863,"updated":"2014-11-18 16:42:03.000000000","message":"It would be good at add an assertion here to show if the record should or should not be deleted.","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b551add088905521c253379f1b4e12f5c6e131","unresolved":false,"context_lines":[{"line_number":3871,"context_line":"        self.catalog_api.delete_region(region_one[\u0027id\u0027])"},{"line_number":3872,"context_line":"        self.assertRaises(exception.RegionNotFound,"},{"line_number":3873,"context_line":"                          self.catalog_api.get_region,"},{"line_number":3874,"context_line":"                          region_two[\u0027id\u0027])"},{"line_number":3875,"context_line":""},{"line_number":3876,"context_line":"        # region_one-\u003eregion_two-\u003eregion_three-\u003eregion_one"},{"line_number":3877,"context_line":"        region_one \u003d self._create_region_with_parent_id()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9a569a5a","line":3874,"updated":"2014-11-18 16:42:03.000000000","message":"Maybe an assertion to show what happened to region_one?","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b551add088905521c253379f1b4e12f5c6e131","unresolved":false,"context_lines":[{"line_number":3886,"context_line":"                          region_one[\u0027id\u0027])"},{"line_number":3887,"context_line":"        self.assertRaises(exception.RegionNotFound,"},{"line_number":3888,"context_line":"                          self.catalog_api.get_region,"},{"line_number":3889,"context_line":"                          region_three[\u0027id\u0027])"},{"line_number":3890,"context_line":""},{"line_number":3891,"context_line":"    def test_service_crud(self):"},{"line_number":3892,"context_line":"        # create"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_baffd632","line":3889,"updated":"2014-11-18 16:42:03.000000000","message":"Same as above here.","commit_id":"60fdd54d9e6b6e4bb37bd3ba8d8b69fd02c50c0a"}]}