)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"7d5e08517a2c41830c0bcc950aa49c802309ee16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"remove unnecessary checks in assignment/controllers.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are checks which check project/domain or user/group must be"},{"line_number":10,"context_line":"specifed only one in create/list/check/revoke_grant methods. However,"},{"line_number":11,"context_line":"1. these methods would not be called by others except router"},{"line_number":12,"context_line":"2. the users can not specify both via url(If a user specify a url such"},{"line_number":13,"context_line":"as /domains/{domain_id}/projects/{project_id}/users/{user_id}/roles or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a890539_887a02bb","line":10,"updated":"2014-11-17 14:04:06.000000000","message":"There are checks that only one of project/domain or user/group are passed to create/list/check/revoke_grant methods.","commit_id":"9ff05c3682aa1853c1819e4d4428eedc8359cb23"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"7d5e08517a2c41830c0bcc950aa49c802309ee16","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are checks which check project/domain or user/group must be"},{"line_number":10,"context_line":"specifed only one in create/list/check/revoke_grant methods. However,"},{"line_number":11,"context_line":"1. these methods would not be called by others except router"},{"line_number":12,"context_line":"2. the users can not specify both via url(If a user specify a url such"},{"line_number":13,"context_line":"as /domains/{domain_id}/projects/{project_id}/users/{user_id}/roles or"},{"line_number":14,"context_line":"/domains/{domain_id}/users/{user_id}/groups/{group_id}/roles or etc, he"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a890539_c857aa24","line":11,"updated":"2014-11-17 14:04:06.000000000","message":"only router calls these methods","commit_id":"9ff05c3682aa1853c1819e4d4428eedc8359cb23"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"7d5e08517a2c41830c0bcc950aa49c802309ee16","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are checks which check project/domain or user/group must be"},{"line_number":10,"context_line":"specifed only one in create/list/check/revoke_grant methods. However,"},{"line_number":11,"context_line":"1. these methods would not be called by others except router"},{"line_number":12,"context_line":"2. the users can not specify both via url(If a user specify a url such"},{"line_number":13,"context_line":"as /domains/{domain_id}/projects/{project_id}/users/{user_id}/roles or"},{"line_number":14,"context_line":"/domains/{domain_id}/users/{user_id}/groups/{group_id}/roles or etc, he"},{"line_number":15,"context_line":"will get a 404 error from router)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a890539_081c5277","line":12,"updated":"2014-11-17 14:04:06.000000000","message":"URL scheme does not accept both project and user simultaneously","commit_id":"9ff05c3682aa1853c1819e4d4428eedc8359cb23"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"7d5e08517a2c41830c0bcc950aa49c802309ee16","unresolved":false,"context_lines":[{"line_number":13,"context_line":"as /domains/{domain_id}/projects/{project_id}/users/{user_id}/roles or"},{"line_number":14,"context_line":"/domains/{domain_id}/users/{user_id}/groups/{group_id}/roles or etc, he"},{"line_number":15,"context_line":"will get a 404 error from router)"},{"line_number":16,"context_line":"That is say, the cases these methods check would never happen. So, I"},{"line_number":17,"context_line":"think these checks can be removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2f996afc59568fd1b17c6a91e72eeeca5856fe3c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a890539_2354d1fd","line":16,"updated":"2014-11-17 14:04:06.000000000","message":"That is why the cases...","commit_id":"9ff05c3682aa1853c1819e4d4428eedc8359cb23"}]}
