)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8fc784d864c8e072b509ca8141a202113222363c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# wsgi keepalive option. In order to close the client socket connection"},{"line_number":107,"context_line":"# explicitly after the response is sent and read successfully by the client,"},{"line_number":108,"context_line":"# you simply have to set keepalive to False when you create a wsgi server."},{"line_number":109,"context_line":"#wsgi_keep_alive \u003d True"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Set this to true if you want to enable TCP_KEEPALIVE on"},{"line_number":112,"context_line":"# server sockets, i.e. sockets used by the Keystone wsgi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5a890539_75c43741","line":109,"updated":"2014-12-01 22:04:39.000000000","message":"This text doesn\u0027t seem to match with what\u0027s in config.py. This sample config should be generated using generate_sample.sh or the tox environment.","commit_id":"4ceb4f2d771902120dbc6d84186f866472c68526"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7680b0e466d01f367f0df3168d976fa01f7a0f2c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# wsgi keepalive option. In order to close the client socket connection"},{"line_number":107,"context_line":"# explicitly after the response is sent and read successfully by the client,"},{"line_number":108,"context_line":"# you simply have to set keepalive to False when you create a wsgi server."},{"line_number":109,"context_line":"#wsgi_keep_alive \u003d True"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Set this to true if you want to enable TCP_KEEPALIVE on"},{"line_number":112,"context_line":"# server sockets, i.e. sockets used by the Keystone wsgi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5a890539_a68e6a25","line":109,"in_reply_to":"5a890539_75c43741","updated":"2014-12-02 07:35:03.000000000","message":"Done","commit_id":"4ceb4f2d771902120dbc6d84186f866472c68526"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e032afa866a35c0459f4bf928990fff2640102c3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"# encrypt method. (integer value)"},{"line_number":103,"context_line":"#crypt_strength\u003d40000"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Timeout for client connections socket operations. If an"},{"line_number":106,"context_line":"# incoming connection is idle for this number of seconds it"},{"line_number":107,"context_line":"# will be closed. A value of \u00270\u0027 means wait forever. (integer"},{"line_number":108,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3a961159_7914539f","line":105,"updated":"2014-12-30 21:42:41.000000000","message":"the sample config file should be generated using tox -e sample_config.","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"709a1255f306fabbf108d9f6867d39426c944c12","unresolved":false,"context_lines":[{"line_number":102,"context_line":"# encrypt method. (integer value)"},{"line_number":103,"context_line":"#crypt_strength\u003d40000"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Timeout for client connections socket operations. If an"},{"line_number":106,"context_line":"# incoming connection is idle for this number of seconds it"},{"line_number":107,"context_line":"# will be closed. A value of \u00270\u0027 means wait forever. (integer"},{"line_number":108,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3a961159_f61bdb70","line":105,"in_reply_to":"3a961159_7914539f","updated":"2015-01-02 08:07:11.000000000","message":"Done","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"}],"keystone/common/config.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e032afa866a35c0459f4bf928990fff2640102c3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_3971eb0c","line":116,"updated":"2014-12-30 21:42:41.000000000","message":"I think this should default to None and use the eventlet.wsgi.server() default if it\u0027s None.","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"709a1255f306fabbf108d9f6867d39426c944c12","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_d3ca7145","line":116,"in_reply_to":"3a961159_3971eb0c","updated":"2015-01-02 08:07:11.000000000","message":"Done","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"a6664b3eeb9e13b8e8333052104b970698f77e52","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_df895270","line":116,"in_reply_to":"3a961159_3971eb0c","updated":"2015-01-06 13:46:36.000000000","message":"I disagree with this change because other projects have accepted similar changes where the values are boolean (default True). See\n* https://review.openstack.org/#/c/130843/6/nova/wsgi.py\n* https://review.openstack.org/#/c/130821/3/cinder/wsgi.py\n* https://review.openstack.org/#/c/130834/12/neutron/wsgi.py\n* https://review.openstack.org/#/c/130839/3/glance/common/wsgi.py\n\nIn principle, I think that this comment is the correct approach, but consistency across services seems more important in my opinion.","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e032afa866a35c0459f4bf928990fff2640102c3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":120,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":121,"context_line":"                        \"If an incoming connection is idle for this number \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_d952a767","line":118,"updated":"2014-12-30 21:42:41.000000000","message":"I don\u0027t think people reading this will understand what it means. Suggest use the text from the wsgi.server docs:\n\n If set to False, disables keepalives on the server; all connections will be closed after serving one request.","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"709a1255f306fabbf108d9f6867d39426c944c12","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":120,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":121,"context_line":"                        \"If an incoming connection is idle for this number \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_f3d92d23","line":118,"in_reply_to":"3a961159_d952a767","updated":"2015-01-02 08:07:11.000000000","message":"Done","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e032afa866a35c0459f4bf928990fff2640102c3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":120,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":121,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":122,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_194d0fc5","line":119,"updated":"2014-12-30 21:42:41.000000000","message":"Same comment here... this should default to None and use the eventlet.wsgi.server() default if it\u0027s None.","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"709a1255f306fabbf108d9f6867d39426c944c12","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":120,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":121,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":122,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_d60c1f3c","line":119,"in_reply_to":"3a961159_194d0fc5","updated":"2015-01-02 08:07:11.000000000","message":"Done","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"a6664b3eeb9e13b8e8333052104b970698f77e52","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If False, closes the client socket connection \""},{"line_number":118,"context_line":"                         \"explicitly.\"),"},{"line_number":119,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":120,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":121,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":122,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_ffe9ae1a","line":119,"in_reply_to":"3a961159_194d0fc5","updated":"2015-01-06 13:46:36.000000000","message":"See comment above.","commit_id":"20b7e00b0e03e2d4fb852f8aac54b3f607737185"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"cec47e4d546e045819606647babaeac8d2542aea","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_3f3ed68b","line":116,"updated":"2015-01-06 13:47:41.000000000","message":"Recommend changing the default back to \"True\" to be consistent with changes to other projects. (See comment on patch set 6.)","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8645a7ebbe249384d601faafba42fa599312ac25","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_6cb7c521","line":116,"in_reply_to":"3a961159_3f3ed68b","updated":"2015-01-07 07:10:41.000000000","message":"Done","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"74dbaab4c8bcd4b049c03a6873e5178859966fd5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_e0f58ecb","line":116,"in_reply_to":"3a961159_3f3ed68b","updated":"2015-01-06 15:05:07.000000000","message":"I prefer consistency, too. I didn\u0027t know other projects had already chosen something. This stuff should be in oslo-incubator rather than copied around.","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8645a7ebbe249384d601faafba42fa599312ac25","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_4cba090c","line":116,"in_reply_to":"3a961159_e0f58ecb","updated":"2015-01-07 07:10:41.000000000","message":"Done","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"9960556c4bb21bf33504d08b0eac92514caa7826","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cfg.IntOpt(\u0027crypt_strength\u0027, default\u003d40000,"},{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dNone,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_a605307b","line":116,"in_reply_to":"3a961159_e0f58ecb","updated":"2015-01-07 23:11:47.000000000","message":"That\u0027s a great point. Would like to see the code that\u0027s been contributed to different projects consolidated in oslo-incubator at some point.","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"cec47e4d546e045819606647babaeac8d2542aea","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"},{"line_number":120,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003dNone,"},{"line_number":121,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":122,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":123,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_df4eb237","line":120,"updated":"2015-01-06 13:47:41.000000000","message":"Ditto as above (default 900).","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8645a7ebbe249384d601faafba42fa599312ac25","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"},{"line_number":120,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003dNone,"},{"line_number":121,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":122,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":123,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_2cc13d80","line":120,"in_reply_to":"3a961159_df4eb237","updated":"2015-01-07 07:10:41.000000000","message":"Done","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"},{"line_number":120,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_98ccd2bd","line":117,"updated":"2015-01-09 23:13:30.000000000","message":"since the config generator uses \u0027true\u0027 / \u0027false\u0027, suggest change \"False\" to \"false\"","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                   help\u003d\u0027The value passed as the keyword \"rounds\" to \u0027"},{"line_number":115,"context_line":"                        \u0027passlib\\\u0027s encrypt method.\u0027),"},{"line_number":116,"context_line":"        cfg.BoolOpt(\u0027wsgi_keep_alive\u0027, default\u003dTrue,"},{"line_number":117,"context_line":"                    help\u003d\"If set to False, disables keepalives on the server; \""},{"line_number":118,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":119,"context_line":"                         \"request.\"),"},{"line_number":120,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_33f5ae84","line":117,"in_reply_to":"3a961159_98ccd2bd","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8db0ba7aa9881a606317842478648997d0cc09c2","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                    help\u003d\"If set to false, disables keepalives on the server; \""},{"line_number":967,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":968,"context_line":"                         \"request.\"),"},{"line_number":969,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":970,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":971,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":972,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_543378aa","line":969,"updated":"2015-02-24 23:35:38.000000000","message":"Why is the default 15 minutes? Seems like that would be no better than where we are today.","commit_id":"7a32d694aba272e65a47aa9d394b607e48b2f240"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"381dc4f926a4f17db0e6b8552fa4b5686ac3169e","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                    help\u003d\"If set to false, disables keepalives on the server; \""},{"line_number":967,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":968,"context_line":"                         \"request.\"),"},{"line_number":969,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":970,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":971,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":972,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_7ea2124c","line":969,"in_reply_to":"ba7be1f8_543378aa","updated":"2015-02-25 06:41:56.000000000","message":"Hi David,\n\nI have kept default value as 900 for consistency with other projects like nova, cinder, neutron etc. If you have any suggestion please let me know. I will make the changes accordingly.","commit_id":"7a32d694aba272e65a47aa9d394b607e48b2f240"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8db0ba7aa9881a606317842478648997d0cc09c2","unresolved":false,"context_lines":[{"line_number":967,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":968,"context_line":"                         \"request.\"),"},{"line_number":969,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":970,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":971,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":972,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""},{"line_number":973,"context_line":"                        \"means wait forever.\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_34d5241c","line":970,"updated":"2015-02-24 23:35:38.000000000","message":"\"Timeout for socket operations on a client connection.\" read a little better. Or add the apostrophe like in the eventlet docs.","commit_id":"7a32d694aba272e65a47aa9d394b607e48b2f240"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"381dc4f926a4f17db0e6b8552fa4b5686ac3169e","unresolved":false,"context_lines":[{"line_number":967,"context_line":"                         \"all connections will be closed after serving one \""},{"line_number":968,"context_line":"                         \"request.\"),"},{"line_number":969,"context_line":"        cfg.IntOpt(\u0027client_socket_timeout\u0027, default\u003d900,"},{"line_number":970,"context_line":"                   help\u003d\"Timeout for client connections socket operations. \""},{"line_number":971,"context_line":"                        \"If an incoming connection is idle for this number \""},{"line_number":972,"context_line":"                        \"of seconds it will be closed. A value of \u00270\u0027 \""},{"line_number":973,"context_line":"                        \"means wait forever.\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_9e27c611","line":970,"in_reply_to":"ba7be1f8_34d5241c","updated":"2015-02-25 06:41:56.000000000","message":"Done","commit_id":"7a32d694aba272e65a47aa9d394b607e48b2f240"}],"keystone/common/environment/eventlet_server.py":[{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"cf366e832b14d8ee707cdc90ed55788f89821dc9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"CONF \u003d cfg.CONF"},{"line_number":48,"context_line":"CONF.register_opts(eventlet_opts)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_62e27230","line":48,"updated":"2014-10-25 01:09:29.000000000","message":"You have defined them in common/config.py, so, here should be removed.","commit_id":"24d16026af6e4a9caaa3e852c009130d41dde94d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8fc784d864c8e072b509ca8141a202113222363c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.keepalive \u003d keepalive"},{"line_number":75,"context_line":"        self.keepidle \u003d keepidle"},{"line_number":76,"context_line":"        self.socket \u003d None"},{"line_number":77,"context_line":"        self.client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def listen(self, key\u003dNone, backlog\u003d128):"},{"line_number":80,"context_line":"        \"\"\"Create and start listening on socket."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_3501cf6a","line":77,"updated":"2014-12-01 22:04:39.000000000","message":"This has a default set in config.py, which should pass through to the implementation if the user doesn\u0027t set it.","commit_id":"4ceb4f2d771902120dbc6d84186f866472c68526"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7680b0e466d01f367f0df3168d976fa01f7a0f2c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.keepalive \u003d keepalive"},{"line_number":75,"context_line":"        self.keepidle \u003d keepidle"},{"line_number":76,"context_line":"        self.socket \u003d None"},{"line_number":77,"context_line":"        self.client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def listen(self, key\u003dNone, backlog\u003d128):"},{"line_number":80,"context_line":"        \"\"\"Create and start listening on socket."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_4bd5cfb5","line":77,"in_reply_to":"5a890539_3501cf6a","updated":"2014-12-02 07:35:03.000000000","message":"Hi Lance,\n\nI agree if client_socket_timeout is not set, it will take default value from config.py but or None is required here, as if client_socket_timeout is set to 0 (by mistake) then the connection will timeouts instantly. In commit message it is mentioned that 0 means never timeout, in order to achieve it we need to set it to None.\n\nhttp://eventlet.net/doc/modules/wsgi.html#module-eventlet.wsgi","commit_id":"4ceb4f2d771902120dbc6d84186f866472c68526"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"cec47e4d546e045819606647babaeac8d2542aea","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.socket \u003d None"},{"line_number":77,"context_line":"        self.client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":78,"context_line":"        wsgi_keep_alive \u003d CONF.wsgi_keep_alive"},{"line_number":79,"context_line":"        self.wsgi_keep_alive \u003d (True if wsgi_keep_alive is None"},{"line_number":80,"context_line":"                                else wsgi_keep_alive)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def listen(self, key\u003dNone, backlog\u003d128):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_3f0c16ec","line":79,"updated":"2015-01-06 13:47:41.000000000","message":"None \u003d\u003e True so why not just set the default value to True?","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8645a7ebbe249384d601faafba42fa599312ac25","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.socket \u003d None"},{"line_number":77,"context_line":"        self.client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":78,"context_line":"        wsgi_keep_alive \u003d CONF.wsgi_keep_alive"},{"line_number":79,"context_line":"        self.wsgi_keep_alive \u003d (True if wsgi_keep_alive is None"},{"line_number":80,"context_line":"                                else wsgi_keep_alive)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def listen(self, key\u003dNone, backlog\u003d128):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_ac3c4d94","line":79,"in_reply_to":"3a961159_3f0c16ec","updated":"2015-01-07 07:10:41.000000000","message":"Done","commit_id":"11d0d8f520688e00f32d3975ef26794b1cb9ccfd"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.keepalive \u003d keepalive"},{"line_number":75,"context_line":"        self.keepidle \u003d keepidle"},{"line_number":76,"context_line":"        self.socket \u003d None"},{"line_number":77,"context_line":"        self.client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def listen(self, key\u003dNone, backlog\u003d128):"},{"line_number":80,"context_line":"        \"\"\"Create and start listening on socket."}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_d8bd7a05","line":77,"updated":"2015-01-09 23:13:30.000000000","message":"adding a member variable for this is more complicated than it needs to be. Suggest move it to a regular variable in _run.","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.keepalive \u003d keepalive"},{"line_number":75,"context_line":"        self.keepidle \u003d keepidle"},{"line_number":76,"context_line":"        self.socket \u003d None"},{"line_number":77,"context_line":"        self.client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def listen(self, key\u003dNone, backlog\u003d128):"},{"line_number":80,"context_line":"        \"\"\"Create and start listening on socket."}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_1301926a","line":77,"in_reply_to":"3a961159_d8bd7a05","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"8cd59f9f0de7a00e9db08f5facceda9f40a235c3","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def _run(self, application, socket):"},{"line_number":178,"context_line":"        \"\"\"Start a WSGI server with a new green thread pool.\"\"\""},{"line_number":179,"context_line":"        logger \u003d log.getLogger(\u0027eventlet.wsgi.server\u0027)"},{"line_number":180,"context_line":"        client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":183,"context_line":"                                 log\u003dEventletFilteringLogger(logger),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_d1b03b42","line":180,"updated":"2015-01-16 04:02:58.000000000","message":"Why this value cannot be 0? \n\nDocumentation at keystone/common/config.py says:\n\"A value of \u00270\u0027 means wait forever.\", so setting client_socket_timeout to 0 would be a valid config value.\n\nIf not, the documentation needs to be updated.","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"4a3b6a018548be8e394f9236822ec0c7e58ab520","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def _run(self, application, socket):"},{"line_number":178,"context_line":"        \"\"\"Start a WSGI server with a new green thread pool.\"\"\""},{"line_number":179,"context_line":"        logger \u003d log.getLogger(\u0027eventlet.wsgi.server\u0027)"},{"line_number":180,"context_line":"        client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":183,"context_line":"                                 log\u003dEventletFilteringLogger(logger),"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_d45d2f7b","line":180,"in_reply_to":"3a961159_d1b03b42","updated":"2015-02-13 19:51:46.000000000","message":"According to the eventlet docs None is treated as forever.(http://eventlet.net/doc/modules/wsgi.html) Does that mean this \u0027or\u0027 is protecting against something else?","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4737acb0c673cfe2223f199ae37d3764a5577a14","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def _run(self, application, socket):"},{"line_number":178,"context_line":"        \"\"\"Start a WSGI server with a new green thread pool.\"\"\""},{"line_number":179,"context_line":"        logger \u003d log.getLogger(\u0027eventlet.wsgi.server\u0027)"},{"line_number":180,"context_line":"        client_socket_timeout \u003d CONF.client_socket_timeout or None"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            eventlet.wsgi.server(socket, application, custom_pool\u003dself.pool,"},{"line_number":183,"context_line":"                                 log\u003dEventletFilteringLogger(logger),"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_20753c32","line":180,"in_reply_to":"da86d52c_d45d2f7b","updated":"2015-02-16 12:04:24.000000000","message":"Hi David, Samuel,\n\nIn help message it is mentioned that 0 means wait forever. If service provider configures client_socket_timeout as 0, the connection will time out immediately and we get run time error while sending the request. In order to configure eventlet wsgi socket to wait forever, it should be set to None. So, I have added CONF.client_socket_timeout or None.\n\nPlease refer:\n\nhttp://eventlet.net/doc/modules/wsgi.html","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8db0ba7aa9881a606317842478648997d0cc09c2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo_log import log"},{"line_number":29,"context_line":"from oslo_log import loggers"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from keystone.common import config"},{"line_number":32,"context_line":"from keystone.i18n import _LE, _LI"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_74a95c8f","line":31,"updated":"2015-02-24 23:35:38.000000000","message":"I think this should be \u0027from oslo_config import cfg\u0027. See  I60c8d2c577d37b9b8a367b46596154ce6c49fff4","commit_id":"7a32d694aba272e65a47aa9d394b607e48b2f240"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"381dc4f926a4f17db0e6b8552fa4b5686ac3169e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo_log import log"},{"line_number":29,"context_line":"from oslo_log import loggers"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from keystone.common import config"},{"line_number":32,"context_line":"from keystone.i18n import _LE, _LI"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_5e0aae79","line":31,"in_reply_to":"ba7be1f8_74a95c8f","updated":"2015-02-25 06:41:56.000000000","message":"Done","commit_id":"7a32d694aba272e65a47aa9d394b607e48b2f240"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0716006b930e45874ea0eb5e75b91af548aacec4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    def _run(self, application, socket):"},{"line_number":187,"context_line":"        \"\"\"Start a WSGI server with a new green thread pool.\"\"\""},{"line_number":188,"context_line":"        logger \u003d log.getLogger(\u0027eventlet.wsgi.server\u0027)"},{"line_number":189,"context_line":"        socket_timeout \u003d CONF.eventlet_server.client_socket_timeout or None"},{"line_number":190,"context_line":"        try:"},{"line_number":191,"context_line":"            eventlet.wsgi.server("},{"line_number":192,"context_line":"                socket, application, log\u003dEventletFilteringLogger(logger),"}],"source_content_type":"text/x-python","patch_set":18,"id":"bab921fb_3f369252","line":189,"updated":"2015-04-24 20:36:09.000000000","message":"the \"or None\" is not necessary because this has a default","commit_id":"3b08644eb9cf4c5aca51a36250ae93105c17f6c4"}],"keystone/tests/test_wsgi.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    def test_client_socket_timeout(self):"},{"line_number":435,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":436,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":437,"context_line":"        CONF.set_override(\u0027client_socket_timeout\u0027, 5)"},{"line_number":438,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":439,"context_line":"                                    port\u003dself.port)"},{"line_number":440,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_18b8e210","line":437,"updated":"2015-01-09 23:13:30.000000000","message":"use the config fixture: self.config_fixture.config(client_socket_timeout\u003d5)\n\nThe value 5 should be moved to a variable and used below where it\u0027s checked against so that it\u0027s obvious.","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    def test_client_socket_timeout(self):"},{"line_number":435,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":436,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":437,"context_line":"        CONF.set_override(\u0027client_socket_timeout\u0027, 5)"},{"line_number":438,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":439,"context_line":"                                    port\u003dself.port)"},{"line_number":440,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_33ce8e5c","line":437,"in_reply_to":"3a961159_18b8e210","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":439,"context_line":"                                    port\u003dself.port)"},{"line_number":440,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":441,"context_line":"            fake_application \u003d 1"},{"line_number":442,"context_line":"            fake_socket \u003d 2"},{"line_number":443,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":444,"context_line":"            mock_server.assert_called_once_with(fake_socket,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_f85156da","line":441,"updated":"2015-01-09 23:13:30.000000000","message":"why 1 ? Add a comment. (or use a random value then no comment is needed.)","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":439,"context_line":"                                    port\u003dself.port)"},{"line_number":440,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":441,"context_line":"            fake_application \u003d 1"},{"line_number":442,"context_line":"            fake_socket \u003d 2"},{"line_number":443,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":444,"context_line":"            mock_server.assert_called_once_with(fake_socket,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_53cb1a4a","line":441,"in_reply_to":"3a961159_f85156da","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                                    port\u003dself.port)"},{"line_number":440,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":441,"context_line":"            fake_application \u003d 1"},{"line_number":442,"context_line":"            fake_socket \u003d 2"},{"line_number":443,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":444,"context_line":"            mock_server.assert_called_once_with(fake_socket,"},{"line_number":445,"context_line":"                                                fake_application,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_385bdefa","line":442,"updated":"2015-01-09 23:13:30.000000000","message":"why 2 ? Add a comment.","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                                    port\u003dself.port)"},{"line_number":440,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":441,"context_line":"            fake_application \u003d 1"},{"line_number":442,"context_line":"            fake_socket \u003d 2"},{"line_number":443,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":444,"context_line":"            mock_server.assert_called_once_with(fake_socket,"},{"line_number":445,"context_line":"                                                fake_application,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_73d8161f","line":442,"in_reply_to":"3a961159_385bdefa","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    def test_wsgi_keep_alive(self):"},{"line_number":453,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":454,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":455,"context_line":"        CONF.set_override(\u0027wsgi_keep_alive\u0027, False)"},{"line_number":456,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":457,"context_line":"                                    port\u003dself.port)"},{"line_number":458,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_3834beab","line":455,"updated":"2015-01-09 23:13:30.000000000","message":"use the config fixture.\n\n  self.config_fixture.config(wsgi_keep_alive\u003dFalse)\n\nAlso, the value should be put in a variable and used below so that it\u0027s obvious they\u0027re the same value.","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    def test_wsgi_keep_alive(self):"},{"line_number":453,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":454,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":455,"context_line":"        CONF.set_override(\u0027wsgi_keep_alive\u0027, False)"},{"line_number":456,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":457,"context_line":"                                    port\u003dself.port)"},{"line_number":458,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_b3019e6f","line":455,"in_reply_to":"3a961159_3834beab","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":457,"context_line":"                                    port\u003dself.port)"},{"line_number":458,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":459,"context_line":"            fake_application \u003d 1"},{"line_number":460,"context_line":"            fake_socket \u003d 2"},{"line_number":461,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":462,"context_line":"            mock_server.assert_called_once_with(fake_socket,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_186622bc","line":459,"updated":"2015-01-09 23:13:30.000000000","message":"why 1 ? Add a comment.","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":457,"context_line":"                                    port\u003dself.port)"},{"line_number":458,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":459,"context_line":"            fake_application \u003d 1"},{"line_number":460,"context_line":"            fake_socket \u003d 2"},{"line_number":461,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":462,"context_line":"            mock_server.assert_called_once_with(fake_socket,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_d3062a85","line":459,"in_reply_to":"3a961159_186622bc","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c8757b777fd7cd3538425d8dd6c9cd4402d814c8","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                                    port\u003dself.port)"},{"line_number":458,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":459,"context_line":"            fake_application \u003d 1"},{"line_number":460,"context_line":"            fake_socket \u003d 2"},{"line_number":461,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":462,"context_line":"            mock_server.assert_called_once_with(fake_socket,"},{"line_number":463,"context_line":"                                                fake_application,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_3802feba","line":460,"updated":"2015-01-09 23:13:30.000000000","message":"why 2 ? Add a comment.","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a62e677ee9c267259b096bbd083b3d1a1b3c84db","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                                    port\u003dself.port)"},{"line_number":458,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"},{"line_number":459,"context_line":"            fake_application \u003d 1"},{"line_number":460,"context_line":"            fake_socket \u003d 2"},{"line_number":461,"context_line":"            server._run(fake_application, fake_socket)"},{"line_number":462,"context_line":"            mock_server.assert_called_once_with(fake_socket,"},{"line_number":463,"context_line":"                                                fake_application,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_f3fb2679","line":460,"in_reply_to":"3a961159_3802feba","updated":"2015-01-12 08:08:29.000000000","message":"Done","commit_id":"685fee36edd9eb29f91465b6f23f61f02fb90c8d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9860bc39a703b5a0b743abca4f0e61390bed3dea","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    def test_client_socket_timeout(self):"},{"line_number":435,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":436,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":437,"context_line":"        socket_timeout \u003d 5"},{"line_number":438,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dsocket_timeout)"},{"line_number":439,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":440,"context_line":"                                    port\u003dself.port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_5d930ea4","line":437,"updated":"2015-01-12 21:10:31.000000000","message":"why 5? Add a comment.","commit_id":"0a6a1f57bdf19138a7243cf783dfadfecafa2c3b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cc274698c83a06fa0afbdff8162dd6aadd22e3ad","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    def test_client_socket_timeout(self):"},{"line_number":435,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":436,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":437,"context_line":"        socket_timeout \u003d 5"},{"line_number":438,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dsocket_timeout)"},{"line_number":439,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":440,"context_line":"                                    port\u003dself.port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_1cec1392","line":437,"in_reply_to":"3a961159_5d930ea4","updated":"2015-01-13 12:08:46.000000000","message":"Done","commit_id":"0a6a1f57bdf19138a7243cf783dfadfecafa2c3b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9860bc39a703b5a0b743abca4f0e61390bed3dea","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":455,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":456,"context_line":"        wsgi_keepalive \u003d False"},{"line_number":457,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dwsgi_keepalive)"},{"line_number":458,"context_line":"        CONF.set_override(\u0027wsgi_keep_alive\u0027, False)"},{"line_number":459,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":460,"context_line":"                                    port\u003dself.port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_7dd7ea4f","line":457,"updated":"2015-01-12 21:10:31.000000000","message":"??","commit_id":"0a6a1f57bdf19138a7243cf783dfadfecafa2c3b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cc274698c83a06fa0afbdff8162dd6aadd22e3ad","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":455,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":456,"context_line":"        wsgi_keepalive \u003d False"},{"line_number":457,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dwsgi_keepalive)"},{"line_number":458,"context_line":"        CONF.set_override(\u0027wsgi_keep_alive\u0027, False)"},{"line_number":459,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":460,"context_line":"                                    port\u003dself.port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_dce28b9f","line":457,"in_reply_to":"3a961159_7dd7ea4f","updated":"2015-01-13 12:08:46.000000000","message":"Done","commit_id":"0a6a1f57bdf19138a7243cf783dfadfecafa2c3b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9860bc39a703b5a0b743abca4f0e61390bed3dea","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":456,"context_line":"        wsgi_keepalive \u003d False"},{"line_number":457,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dwsgi_keepalive)"},{"line_number":458,"context_line":"        CONF.set_override(\u0027wsgi_keep_alive\u0027, False)"},{"line_number":459,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":460,"context_line":"                                    port\u003dself.port)"},{"line_number":461,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_fdebda0f","line":458,"updated":"2015-01-12 21:10:31.000000000","message":"use the config fixture.\n\n self.config_fixture.config(wsgi_keep_alive\u003dFalse)\n\nAlso, the value should be put in a variable and used below so that it\u0027s obvious they\u0027re the same value.","commit_id":"0a6a1f57bdf19138a7243cf783dfadfecafa2c3b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cc274698c83a06fa0afbdff8162dd6aadd22e3ad","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":456,"context_line":"        wsgi_keepalive \u003d False"},{"line_number":457,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dwsgi_keepalive)"},{"line_number":458,"context_line":"        CONF.set_override(\u0027wsgi_keep_alive\u0027, False)"},{"line_number":459,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"},{"line_number":460,"context_line":"                                    port\u003dself.port)"},{"line_number":461,"context_line":"        with mock.patch.object(eventlet.wsgi, \u0027server\u0027) as mock_server:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_fcdd87de","line":458,"in_reply_to":"3a961159_fdebda0f","updated":"2015-01-13 12:08:46.000000000","message":"Done","commit_id":"0a6a1f57bdf19138a7243cf783dfadfecafa2c3b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"872b9be9363d00335c9c45ba197e8b0a80302212","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":432,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # setting socket_timeout as 5, so that after 5 seconds client"},{"line_number":435,"context_line":"        # connection will be closed if it is idle."},{"line_number":436,"context_line":"        socket_timeout \u003d 5"},{"line_number":437,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_5d3da3dc","line":434,"updated":"2015-01-13 21:51:32.000000000","message":"why is it important for this to be 5 and not 6 or 7? A random number should be used.","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8c57947d8c4690a2d0eb3325a7881db569172397","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":432,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # setting socket_timeout as 5, so that after 5 seconds client"},{"line_number":435,"context_line":"        # connection will be closed if it is idle."},{"line_number":436,"context_line":"        socket_timeout \u003d 5"},{"line_number":437,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_266b9486","line":434,"in_reply_to":"3a961159_11ed6325","updated":"2015-02-16 12:32:36.000000000","message":"I have used random number between 1 to 10","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"8cd59f9f0de7a00e9db08f5facceda9f40a235c3","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":432,"context_line":"        # configured \u0027client_socket_timeout\u0027 value."},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        # setting socket_timeout as 5, so that after 5 seconds client"},{"line_number":435,"context_line":"        # connection will be closed if it is idle."},{"line_number":436,"context_line":"        socket_timeout \u003d 5"},{"line_number":437,"context_line":"        self.config_fixture.config(client_socket_timeout\u003dsocket_timeout)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_11ed6325","line":434,"in_reply_to":"3a961159_5d3da3dc","updated":"2015-01-16 04:02:58.000000000","message":"++","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"19cf6b38c8c9dc1776c191e4445e85197de2861d","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":454,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # setting wsgi_keepalive as False, so that after  connection will be"},{"line_number":457,"context_line":"        # closed automatically after response is sent and read successfully"},{"line_number":458,"context_line":"        # by the client."},{"line_number":459,"context_line":"        wsgi_keepalive \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_1141ffa5","line":456,"updated":"2015-01-15 13:44:25.000000000","message":"Nit: double space between after and connection","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"872b9be9363d00335c9c45ba197e8b0a80302212","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":454,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # setting wsgi_keepalive as False, so that after  connection will be"},{"line_number":457,"context_line":"        # closed automatically after response is sent and read successfully"},{"line_number":458,"context_line":"        # by the client."},{"line_number":459,"context_line":"        wsgi_keepalive \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a961159_7d233fbe","line":456,"updated":"2015-01-13 21:51:32.000000000","message":"why is it important for this to be False and not True?","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8c57947d8c4690a2d0eb3325a7881db569172397","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":454,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # setting wsgi_keepalive as False, so that after  connection will be"},{"line_number":457,"context_line":"        # closed automatically after response is sent and read successfully"},{"line_number":458,"context_line":"        # by the client."},{"line_number":459,"context_line":"        wsgi_keepalive \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_46fde8b0","line":456,"in_reply_to":"3a961159_1141ffa5","updated":"2015-02-16 12:32:36.000000000","message":"Done","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8c57947d8c4690a2d0eb3325a7881db569172397","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":454,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # setting wsgi_keepalive as False, so that after  connection will be"},{"line_number":457,"context_line":"        # closed automatically after response is sent and read successfully"},{"line_number":458,"context_line":"        # by the client."},{"line_number":459,"context_line":"        wsgi_keepalive \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_66a02ca6","line":456,"in_reply_to":"3a961159_7d233fbe","updated":"2015-02-16 12:32:36.000000000","message":"Hi Brant,\n\nI am just checking that eventlet.wsgi.server method is called with configured wsgi_keepalive option.","commit_id":"a9b60c628e0878e8fb325c1dfdb3504550fc233e"}],"keystone/tests/unit/test_wsgi.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"50e6f6ad53b8571c24a9816aa57e15c7c6feb447","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # mocking server method of eventlet.wsgi to check it is called with"},{"line_number":456,"context_line":"        # configured \u0027wsgi_keep_alive\u0027 value."},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        # setting wsgi_keepalive as False, so that after connection will be"},{"line_number":459,"context_line":"        # closed automatically after response is sent and read successfully"},{"line_number":460,"context_line":"        # by the client."},{"line_number":461,"context_line":"        wsgi_keepalive \u003d False"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_24dc7212","line":458,"updated":"2015-02-23 00:55:11.000000000","message":"the comment about \"I am just checking that eventlet.wsgi.server method is called with configured wsgi_keepalive option.\" should be in the code here... having it as a comment in gerrit isn\u0027t very useful.","commit_id":"617af458937b9a724891cb801faffe97c81de693"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"ba4dc65c5eabf3990301ad3efabf735fdd9e0179","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        # setting random socket_timeout between 1 to 10, so that after given"},{"line_number":436,"context_line":"        # seconds client connection will be closed if it is idle."},{"line_number":437,"context_line":"        socket_timeout \u003d random.randint(1, 10)"},{"line_number":438,"context_line":"        self.config_fixture.config(group\u003d\u0027eventlet_server\u0027,"},{"line_number":439,"context_line":"                                   client_socket_timeout\u003dsocket_timeout)"},{"line_number":440,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a80dd14_08dc75e3","line":437,"updated":"2015-03-13 15:40:29.000000000","message":"Best to avoid random number -- makes it difficult to reproduce any failures.","commit_id":"3b08644eb9cf4c5aca51a36250ae93105c17f6c4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5b6705bba4d10b35a5260c2f51dd28b976bf05b5","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        # setting random socket_timeout between 1 to 10, so that after given"},{"line_number":436,"context_line":"        # seconds client connection will be closed if it is idle."},{"line_number":437,"context_line":"        socket_timeout \u003d random.randint(1, 10)"},{"line_number":438,"context_line":"        self.config_fixture.config(group\u003d\u0027eventlet_server\u0027,"},{"line_number":439,"context_line":"                                   client_socket_timeout\u003dsocket_timeout)"},{"line_number":440,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a80dd14_48b65bfa","line":437,"in_reply_to":"9a80dd14_08dc75e3","updated":"2015-03-13 21:50:09.000000000","message":"the comment before this is confusing since it says that client connections will be closed, but this test doesn\u0027t have any client connections. Everything is mocked.","commit_id":"3b08644eb9cf4c5aca51a36250ae93105c17f6c4"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0716006b930e45874ea0eb5e75b91af548aacec4","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        # setting random socket_timeout between 1 to 10, so that after given"},{"line_number":436,"context_line":"        # seconds client connection will be closed if it is idle."},{"line_number":437,"context_line":"        socket_timeout \u003d random.randint(1, 10)"},{"line_number":438,"context_line":"        self.config_fixture.config(group\u003d\u0027eventlet_server\u0027,"},{"line_number":439,"context_line":"                                   client_socket_timeout\u003dsocket_timeout)"},{"line_number":440,"context_line":"        server \u003d environment.Server(mock.MagicMock(), host\u003dself.host,"}],"source_content_type":"text/x-python","patch_set":18,"id":"bab921fb_3f8452d2","line":437,"in_reply_to":"9a80dd14_48b65bfa","updated":"2015-04-24 20:36:09.000000000","message":"++ and this test is hardly testing anything at all... \"the configuration value is passed through: yay!\"","commit_id":"3b08644eb9cf4c5aca51a36250ae93105c17f6c4"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"0716006b930e45874ea0eb5e75b91af548aacec4","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                                debug\u003dmock.ANY,"},{"line_number":469,"context_line":"                                                socket_timeout\u003dmock.ANY,"},{"line_number":470,"context_line":"                                                log\u003dmock.ANY,"},{"line_number":471,"context_line":"                                                keepalive\u003dwsgi_keepalive)"}],"source_content_type":"text/x-python","patch_set":18,"id":"bab921fb_7fc88a22","line":471,"updated":"2015-04-24 20:36:09.000000000","message":"same as above","commit_id":"3b08644eb9cf4c5aca51a36250ae93105c17f6c4"}]}