)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"905e133d644dc3698d092c8f2bc83dc683ba6cf3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The require matching id check is done at controller layer. And,"},{"line_number":10,"context_line":"the check should be at controller layer rather than manager layer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0ee070b3640b1013982c75f62e59fac8932fe812"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_5677a59f","line":11,"updated":"2014-11-26 18:53:29.000000000","message":"this is a bug or a bp? If yes, please put the reference here.","commit_id":"6120a43d85a333302d1dac644e76cb3405b5f0aa"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d39842a28d593a92b21dfc239a3f6aabbfcfd81c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The require matching id check is done at controller layer. And,"},{"line_number":10,"context_line":"the check should be at controller layer rather than manager layer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0ee070b3640b1013982c75f62e59fac8932fe812"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_e7ea8bab","line":11,"in_reply_to":"5a890539_5677a59f","updated":"2014-11-27 10:08:36.000000000","message":"improvement i\u0027d say.","commit_id":"6120a43d85a333302d1dac644e76cb3405b5f0aa"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"7503f544f344ca11244666ecf3f5d5d327c496a5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The require matching id check is done at controller layer. And,"},{"line_number":10,"context_line":"the check should be at controller layer rather than manager layer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0ee070b3640b1013982c75f62e59fac8932fe812"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_2daec298","line":11,"in_reply_to":"5a890539_e7ea8bab","updated":"2014-12-19 07:32:26.000000000","message":"Yes):","commit_id":"6120a43d85a333302d1dac644e76cb3405b5f0aa"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e939fcad1f05830c65e3a8807b7a31c1d3c686a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove duplicate matching id check when updating user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The require matching id check is done at controller layer. And,"},{"line_number":10,"context_line":"the check should be at controller layer rather than manager layer."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0ee070b3640b1013982c75f62e59fac8932fe812"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a930d6b_d33b369a","line":9,"updated":"2015-01-23 15:38:00.000000000","message":"(nit) required instead or require\n\nI\u0027d also replace \u0027. And, \u0027 with just \u0027and\u0027","commit_id":"289a93f1dfc629d36d851454155de4953a55858c"}],"keystone/identity/core.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"b8100bfb6b1f4399960a146ee9d0741cf5f77834","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            # the driver layer won\u0027t be confused by the fact the this is the"},{"line_number":639,"context_line":"            # public ID not the local ID"},{"line_number":640,"context_line":"            user.pop(\u0027id\u0027)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        domain_id, driver, entity_id \u003d ("},{"line_number":643,"context_line":"            self._get_domain_driver_and_entity_id(user_id))"},{"line_number":644,"context_line":"        user \u003d self._clear_domain_id_if_domain_unaware(driver, user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b0d29ffd","side":"PARENT","line":641,"updated":"2014-11-26 11:55:16.000000000","message":"Mabe add a NOTE that this is aleady handled in UserV3._require_matching_id() ?","commit_id":"3d9184b6f5860f0b56091a326ed41d2a4c29fbe4"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"7503f544f344ca11244666ecf3f5d5d327c496a5","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            # the driver layer won\u0027t be confused by the fact the this is the"},{"line_number":639,"context_line":"            # public ID not the local ID"},{"line_number":640,"context_line":"            user.pop(\u0027id\u0027)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        domain_id, driver, entity_id \u003d ("},{"line_number":643,"context_line":"            self._get_domain_driver_and_entity_id(user_id))"},{"line_number":644,"context_line":"        user \u003d self._clear_domain_id_if_domain_unaware(driver, user)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_0d8026f6","side":"PARENT","line":641,"in_reply_to":"5a890539_b0d29ffd","updated":"2014-12-19 07:32:26.000000000","message":"I do not think so. Almost all the keystone objects use _require_matching_id to do this check in controller.","commit_id":"3d9184b6f5860f0b56091a326ed41d2a4c29fbe4"}]}
