)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31ad8f7b57606624e8eeb6497a97031fad311489","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve testing of domain federation tokens for inherited roles."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently domain-scoped federation-generated tokens incorrectly"},{"line_number":10,"context_line":"include group roles that are inerited projects within that domain."},{"line_number":11,"context_line":"This error is also exposed via the /auth/domains and"},{"line_number":12,"context_line":"/OS-FEDERATION/domains API calls."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8c0949_9f645223","line":10,"updated":"2014-11-07 08:40:12.000000000","message":"inherited","commit_id":"e69a17a9b95d3d079f3b442121b84042d9095bac"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b7277abbff2f772bc784a79212109d1a06f138c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve testing of domain federation tokens for inherited roles."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently domain-scoped federation-generated tokens incorrectly"},{"line_number":10,"context_line":"include group roles that are inerited projects within that domain."},{"line_number":11,"context_line":"This error is also exposed via the /auth/domains and"},{"line_number":12,"context_line":"/OS-FEDERATION/domains API calls."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a890539_9c24d1c7","line":10,"in_reply_to":"7a8c0949_9f645223","updated":"2014-11-08 14:58:54.000000000","message":"Done","commit_id":"e69a17a9b95d3d079f3b442121b84042d9095bac"}],"keystone/tests/test_v3_federation.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9fa07a3b627b9828c9b759f536327097e00ebc22","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"                  self.tokens[\u0027EMPLOYEE_ASSERTION\u0027],"},{"line_number":1117,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        # TODO(henry-nash): The following *should* not include domain D"},{"line_number":1120,"context_line":"        # for customer/admin since they only have a role that is inherited"},{"line_number":1121,"context_line":"        # to projects within it. See bug #1385643"},{"line_number":1122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_4503130d","line":1119,"updated":"2014-11-05 16:47:02.000000000","message":"nit: using \"domain D\" here and \"Domain D\" in the previous comment","commit_id":"e69a17a9b95d3d079f3b442121b84042d9095bac"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b7277abbff2f772bc784a79212109d1a06f138c1","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"                  self.tokens[\u0027EMPLOYEE_ASSERTION\u0027],"},{"line_number":1117,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        # TODO(henry-nash): The following *should* not include domain D"},{"line_number":1120,"context_line":"        # for customer/admin since they only have a role that is inherited"},{"line_number":1121,"context_line":"        # to projects within it. See bug #1385643"},{"line_number":1122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_7c400557","line":1119,"in_reply_to":"7a8c0949_1bb5ddcc","updated":"2014-11-08 14:58:54.000000000","message":"Done","commit_id":"e69a17a9b95d3d079f3b442121b84042d9095bac"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"899a96e1b291aa21a92c8c492e0c51f98a3cd7d0","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"                  self.tokens[\u0027EMPLOYEE_ASSERTION\u0027],"},{"line_number":1117,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        # TODO(henry-nash): The following *should* not include domain D"},{"line_number":1120,"context_line":"        # for customer/admin since they only have a role that is inherited"},{"line_number":1121,"context_line":"        # to projects within it. See bug #1385643"},{"line_number":1122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_1bb5ddcc","line":1119,"in_reply_to":"7a8c0949_4503130d","updated":"2014-11-06 16:22:53.000000000","message":"this comment gets replaced in the dependant fix patch...so unless I need to do another commit, I\u0027ll leave this..","commit_id":"e69a17a9b95d3d079f3b442121b84042d9095bac"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"b37cb1f157e2728c76ee1121b6e2bcb6ea52e08c","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        # TODO(henry-nash): The following *should* not include domainD"},{"line_number":1120,"context_line":"        # for customer/admin since they only have a role that is inherited"},{"line_number":1121,"context_line":"        # to projects within it. See bug #1385643"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"        domain_refs \u003d (set([self.domainA[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_5e894ac9","line":1120,"updated":"2014-11-11 20:06:24.000000000","message":"Nit:  perhaps add the word \"token\" after customer/admin to make it more clear that the relationship of the domain sets you describe are associated with the tokens added in the tokens set above","commit_id":"4bb8d28b4020e7a4701516ddb83679a4a78bc9c1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"42147077c19a12a9b98be161ae37e804eb961fda","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        # TODO(henry-nash): The following *should* not include domainD"},{"line_number":1120,"context_line":"        # for customer/admin since they only have a role that is inherited"},{"line_number":1121,"context_line":"        # to projects within it. See bug #1385643"},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"        domain_refs \u003d (set([self.domainA[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_544be286","line":1120,"in_reply_to":"5a890539_5e894ac9","updated":"2014-11-12 08:43:07.000000000","message":"fair comment - if it\u0027s OK I\u0027ll leave this to a tidy up follow-on patch, unless, as you say, other things need changing.","commit_id":"4bb8d28b4020e7a4701516ddb83679a4a78bc9c1"}]}