)]}'
{"keystone/assignment/backends/sql.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"a4bb479505af6bf15b72324cf3e5ba25eaeec65f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        sql_constraints \u003d sqlalchemy.and_("},{"line_number":327,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"},{"line_number":328,"context_line":"            RoleAssignment.target_id \u003d\u003d target_id,"},{"line_number":329,"context_line":"            RoleAssignment.inherited \u003d\u003d false(),"},{"line_number":330,"context_line":"            Role.id \u003d\u003d RoleAssignment.role_id,"},{"line_number":331,"context_line":"            RoleAssignment.actor_id.in_(group_ids))"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_7ff9ae4c","line":329,"updated":"2014-11-11 14:10:29.000000000","message":"so, what should happen if a group had an inherited role assigned to a domain (effectively to all projects in a domain). Shouldn\u0027t it be listed here?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1c2154a53377c5a3aa3d6c6ce0bfdc594a95355","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        sql_constraints \u003d sqlalchemy.and_("},{"line_number":327,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"},{"line_number":328,"context_line":"            RoleAssignment.target_id \u003d\u003d target_id,"},{"line_number":329,"context_line":"            RoleAssignment.inherited \u003d\u003d false(),"},{"line_number":330,"context_line":"            Role.id \u003d\u003d RoleAssignment.role_id,"},{"line_number":331,"context_line":"            RoleAssignment.actor_id.in_(group_ids))"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_39f49df1","line":329,"in_reply_to":"5a890539_1fa189f8","updated":"2014-11-11 17:17:45.000000000","message":"indeed","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"dfdd52a0d053dcb767ae05518df930b1cca12deb","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        sql_constraints \u003d sqlalchemy.and_("},{"line_number":327,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"},{"line_number":328,"context_line":"            RoleAssignment.target_id \u003d\u003d target_id,"},{"line_number":329,"context_line":"            RoleAssignment.inherited \u003d\u003d false(),"},{"line_number":330,"context_line":"            Role.id \u003d\u003d RoleAssignment.role_id,"},{"line_number":331,"context_line":"            RoleAssignment.actor_id.in_(group_ids))"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_1fa189f8","line":329,"in_reply_to":"5a890539_7ff9ae4c","updated":"2014-11-11 14:18:26.000000000","message":"ah, i guess it\u0027s resolved in patches biult on top of this one?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"a4bb479505af6bf15b72324cf3e5ba25eaeec65f","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("},{"line_number":368,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"},{"line_number":369,"context_line":"            RoleAssignment.inherited \u003d\u003d false(),"},{"line_number":370,"context_line":"            entity.id \u003d\u003d RoleAssignment.target_id,"},{"line_number":371,"context_line":"            RoleAssignment.actor_id.in_(group_ids))"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_df9f0202","line":369,"updated":"2014-11-11 14:10:29.000000000","message":"so, what should happen if a group had an inherited role assigned to a domain (effectively to all projects in a domain). Shouldn\u0027t it be listed here?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1c2154a53377c5a3aa3d6c6ce0bfdc594a95355","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("},{"line_number":368,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"},{"line_number":369,"context_line":"            RoleAssignment.inherited \u003d\u003d false(),"},{"line_number":370,"context_line":"            entity.id \u003d\u003d RoleAssignment.target_id,"},{"line_number":371,"context_line":"            RoleAssignment.actor_id.in_(group_ids))"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_59f969e8","line":369,"in_reply_to":"5a890539_7fafede3","updated":"2014-11-11 17:17:45.000000000","message":"indeed","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"dfdd52a0d053dcb767ae05518df930b1cca12deb","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("},{"line_number":368,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"},{"line_number":369,"context_line":"            RoleAssignment.inherited \u003d\u003d false(),"},{"line_number":370,"context_line":"            entity.id \u003d\u003d RoleAssignment.target_id,"},{"line_number":371,"context_line":"            RoleAssignment.actor_id.in_(group_ids))"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_7fafede3","line":369,"in_reply_to":"5a890539_df9f0202","updated":"2014-11-11 14:18:26.000000000","message":"ah, i guess it\u0027s resolved in patches biult on top of this one?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9538b16b20826c8367791bd8df243788f1080bd0","unresolved":false,"context_lines":[{"line_number":3041,"context_line":"        self.assertThat(member_assignments,"},{"line_number":3042,"context_line":"                        matchers.Equals(orig_member_assignments))"},{"line_number":3043,"context_line":""},{"line_number":3044,"context_line":"    def test_get_roles_for_groups_on_domain(self):"},{"line_number":3045,"context_line":"        \"\"\"Test retrieving group domain roles."},{"line_number":3046,"context_line":""},{"line_number":3047,"context_line":"        Test Plan:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_0002d90a","line":3044,"updated":"2014-11-05 19:46:10.000000000","message":"what do you think about another test checking the roles of the users in those groups?","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0a4922ac7e026d132d44f832e91ae11ef65064a7","unresolved":false,"context_lines":[{"line_number":3041,"context_line":"        self.assertThat(member_assignments,"},{"line_number":3042,"context_line":"                        matchers.Equals(orig_member_assignments))"},{"line_number":3043,"context_line":""},{"line_number":3044,"context_line":"    def test_get_roles_for_groups_on_domain(self):"},{"line_number":3045,"context_line":"        \"\"\"Test retrieving group domain roles."},{"line_number":3046,"context_line":""},{"line_number":3047,"context_line":"        Test Plan:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_19a6d3c1","line":3044,"in_reply_to":"7a8c0949_0002d90a","updated":"2014-11-06 09:20:38.000000000","message":"I think that is checked else where (i.e. that a user in a group gets the any roles that have been assigned to that group)...but what I think I should add is a test for list_domains_for_groups().","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"6e5722b4c790d147ee0fa250ac059f3a9e4ed3f2","unresolved":false,"context_lines":[{"line_number":3041,"context_line":"        self.assertThat(member_assignments,"},{"line_number":3042,"context_line":"                        matchers.Equals(orig_member_assignments))"},{"line_number":3043,"context_line":""},{"line_number":3044,"context_line":"    def test_get_roles_for_groups_on_domain(self):"},{"line_number":3045,"context_line":"        \"\"\"Test retrieving group domain roles."},{"line_number":3046,"context_line":""},{"line_number":3047,"context_line":"        Test Plan:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_54de5d6e","line":3044,"in_reply_to":"7a8c0949_19a6d3c1","updated":"2014-11-06 11:40:27.000000000","message":"++","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"309ef5826a5c4f06385819af162f21eac70b292e","unresolved":false,"context_lines":[{"line_number":3051,"context_line":"        - Ensure that only the non-inherited roles are returned on the domain"},{"line_number":3052,"context_line":""},{"line_number":3053,"context_line":"        \"\"\""},{"line_number":3054,"context_line":"        domain1 \u003d {\u0027id\u0027: uuid.uuid4().hex, \u0027name\u0027: uuid.uuid4().hex}"},{"line_number":3055,"context_line":"        self.assignment_api.create_domain(domain1[\u0027id\u0027], domain1)"},{"line_number":3056,"context_line":"        group_list \u003d []"},{"line_number":3057,"context_line":"        group_id_list \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_8d2281ff","line":3054,"updated":"2014-11-06 01:14:36.000000000","message":"I would suggest adding methods to the utils class to create models. This would help clean up the code.\n\nex:\ndef create_domain(id\u003dnew_uuid(), name\u003dnew_uuid()):\n    return {\u0027id\u0027: id, \u0027name\u0027: name}\n\nAlso, there currently exists a method under keystone/test/utils.py for generating uuids. (new_uuid)","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0a4922ac7e026d132d44f832e91ae11ef65064a7","unresolved":false,"context_lines":[{"line_number":3051,"context_line":"        - Ensure that only the non-inherited roles are returned on the domain"},{"line_number":3052,"context_line":""},{"line_number":3053,"context_line":"        \"\"\""},{"line_number":3054,"context_line":"        domain1 \u003d {\u0027id\u0027: uuid.uuid4().hex, \u0027name\u0027: uuid.uuid4().hex}"},{"line_number":3055,"context_line":"        self.assignment_api.create_domain(domain1[\u0027id\u0027], domain1)"},{"line_number":3056,"context_line":"        group_list \u003d []"},{"line_number":3057,"context_line":"        group_id_list \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_d9c0cb2c","line":3054,"in_reply_to":"7a8c0949_8d2281ff","updated":"2014-11-06 09:20:38.000000000","message":"so we do have a full set of methods for instantiating new models (e.g. new_domain_ref())...which are in test_v3.RestfulTestCase.  I\u0027m not actually sure why are only for the test the \"other side\" of the API boundary.  What\u0027s needed is to pul them out of there so that can be used more generally. I think that is a better solution, but outside the scope of this patch.","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"309ef5826a5c4f06385819af162f21eac70b292e","unresolved":false,"context_lines":[{"line_number":3056,"context_line":"        group_list \u003d []"},{"line_number":3057,"context_line":"        group_id_list \u003d []"},{"line_number":3058,"context_line":"        for _ in range(3):"},{"line_number":3059,"context_line":"            group \u003d {\u0027name\u0027: uuid.uuid4().hex, \u0027domain_id\u0027: domain1[\u0027id\u0027]}"},{"line_number":3060,"context_line":"            group \u003d self.identity_api.create_group(group)"},{"line_number":3061,"context_line":"            group_list.append(group)"},{"line_number":3062,"context_line":"            group_id_list.append(group[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_8d69a127","line":3059,"updated":"2014-11-06 01:14:36.000000000","message":"Same as before but for groups.","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0a4922ac7e026d132d44f832e91ae11ef65064a7","unresolved":false,"context_lines":[{"line_number":3056,"context_line":"        group_list \u003d []"},{"line_number":3057,"context_line":"        group_id_list \u003d []"},{"line_number":3058,"context_line":"        for _ in range(3):"},{"line_number":3059,"context_line":"            group \u003d {\u0027name\u0027: uuid.uuid4().hex, \u0027domain_id\u0027: domain1[\u0027id\u0027]}"},{"line_number":3060,"context_line":"            group \u003d self.identity_api.create_group(group)"},{"line_number":3061,"context_line":"            group_list.append(group)"},{"line_number":3062,"context_line":"            group_id_list.append(group[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_f9de6710","line":3059,"in_reply_to":"7a8c0949_8d69a127","updated":"2014-11-06 09:20:38.000000000","message":"see above","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":13152,"name":"Jorge Munoz","email":"elkidster@gmail.com","username":"jmunoz"},"change_message_id":"309ef5826a5c4f06385819af162f21eac70b292e","unresolved":false,"context_lines":[{"line_number":3062,"context_line":"            group_id_list.append(group[\u0027id\u0027])"},{"line_number":3063,"context_line":"        role_list \u003d []"},{"line_number":3064,"context_line":"        for _ in range(3):"},{"line_number":3065,"context_line":"            role \u003d {\u0027id\u0027: uuid.uuid4().hex, \u0027name\u0027: uuid.uuid4().hex}"},{"line_number":3066,"context_line":"            self.assignment_api.create_role(role[\u0027id\u0027], role)"},{"line_number":3067,"context_line":"            role_list.append(role)"},{"line_number":3068,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_edef8585","line":3065,"updated":"2014-11-06 01:14:36.000000000","message":"Same as before but for roles.","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0a4922ac7e026d132d44f832e91ae11ef65064a7","unresolved":false,"context_lines":[{"line_number":3062,"context_line":"            group_id_list.append(group[\u0027id\u0027])"},{"line_number":3063,"context_line":"        role_list \u003d []"},{"line_number":3064,"context_line":"        for _ in range(3):"},{"line_number":3065,"context_line":"            role \u003d {\u0027id\u0027: uuid.uuid4().hex, \u0027name\u0027: uuid.uuid4().hex}"},{"line_number":3066,"context_line":"            self.assignment_api.create_role(role[\u0027id\u0027], role)"},{"line_number":3067,"context_line":"            role_list.append(role)"},{"line_number":3068,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_19e253d5","line":3065,"in_reply_to":"7a8c0949_edef8585","updated":"2014-11-06 09:20:38.000000000","message":"see above","commit_id":"164703d27c54e4d4d5bd7735490ba4b86d8ee137"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"ac7d9078bef0e0d298afe50d7ca27ebe58fd9dd7","unresolved":false,"context_lines":[{"line_number":3044,"context_line":"    def test_get_roles_for_groups_on_domain(self):"},{"line_number":3045,"context_line":"        \"\"\"Test retrieving group domain roles."},{"line_number":3046,"context_line":""},{"line_number":3047,"context_line":"        Test Plan:"},{"line_number":3048,"context_line":""},{"line_number":3049,"context_line":"        - Create a domain, three groups and three roles"},{"line_number":3050,"context_line":"        - Assign one an inherited and the others a non-inherited group role"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_1e7d026f","line":3047,"updated":"2014-11-11 19:50:26.000000000","message":"Thanks for adding the Test plan! Its a huge help to making the code readable.","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"ec6aa3dee1fe5ea571be6a3df60096752e5780ce","unresolved":false,"context_lines":[{"line_number":3044,"context_line":"    def test_get_roles_for_groups_on_domain(self):"},{"line_number":3045,"context_line":"        \"\"\"Test retrieving group domain roles."},{"line_number":3046,"context_line":""},{"line_number":3047,"context_line":"        Test Plan:"},{"line_number":3048,"context_line":""},{"line_number":3049,"context_line":"        - Create a domain, three groups and three roles"},{"line_number":3050,"context_line":"        - Assign one an inherited and the others a non-inherited group role"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_ce773fd3","line":3047,"in_reply_to":"5a890539_1e7d026f","updated":"2014-11-12 07:01:53.000000000","message":"++","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1a0af180b2c993b6108d298ff99721f60db7ec83","unresolved":false,"context_lines":[{"line_number":3054,"context_line":"        \"\"\""},{"line_number":3055,"context_line":"        domain1 \u003d {\u0027id\u0027: uuid.uuid4().hex, \u0027name\u0027: uuid.uuid4().hex}"},{"line_number":3056,"context_line":"        self.assignment_api.create_domain(domain1[\u0027id\u0027], domain1)"},{"line_number":3057,"context_line":"        group_list \u003d []"},{"line_number":3058,"context_line":"        group_id_list \u003d []"},{"line_number":3059,"context_line":"        role_list \u003d []"},{"line_number":3060,"context_line":"        for _ in range(3):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_99ff4367","line":3057,"updated":"2014-11-12 07:41:14.000000000","message":"there is no need to save the group objects, you are just plucking the id from them.","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1a0af180b2c993b6108d298ff99721f60db7ec83","unresolved":false,"context_lines":[{"line_number":3117,"context_line":"        self.assignment_api.create_role(role1[\u0027id\u0027], role1)"},{"line_number":3118,"context_line":""},{"line_number":3119,"context_line":"        # Assign the roles - one is inherited"},{"line_number":3120,"context_line":"        self.assignment_api.create_grant(group_id\u003dgroup_list[0][\u0027id\u0027],"},{"line_number":3121,"context_line":"                                         domain_id\u003ddomain_list[0][\u0027id\u0027],"},{"line_number":3122,"context_line":"                                         role_id\u003drole1[\u0027id\u0027])"},{"line_number":3123,"context_line":"        self.assignment_api.create_grant(group_id\u003dgroup_list[1][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_f93a0733","line":3120,"updated":"2014-11-12 07:41:14.000000000","message":"same comment as above, you can just write group_id_list[0]","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"a4bb479505af6bf15b72324cf3e5ba25eaeec65f","unresolved":false,"context_lines":[{"line_number":3138,"context_line":"        self.assertIn(domain_list[0], domain_refs)"},{"line_number":3139,"context_line":"        self.assertIn(domain_list[1], domain_refs)"},{"line_number":3140,"context_line":""},{"line_number":3141,"context_line":""},{"line_number":3142,"context_line":"class TokenTests(object):"},{"line_number":3143,"context_line":"    def _create_token_id(self):"},{"line_number":3144,"context_line":"        # Use a token signed by the cms module"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_dfb6228a","line":3141,"updated":"2014-11-11 14:10:29.000000000","message":"Are there any tests where user scoped to a project within a domain with a roles inheriting to all the projects?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1c2154a53377c5a3aa3d6c6ce0bfdc594a95355","unresolved":false,"context_lines":[{"line_number":3138,"context_line":"        self.assertIn(domain_list[0], domain_refs)"},{"line_number":3139,"context_line":"        self.assertIn(domain_list[1], domain_refs)"},{"line_number":3140,"context_line":""},{"line_number":3141,"context_line":""},{"line_number":3142,"context_line":"class TokenTests(object):"},{"line_number":3143,"context_line":"    def _create_token_id(self):"},{"line_number":3144,"context_line":"        # Use a token signed by the cms module"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_f9d05555","line":3141,"in_reply_to":"5a890539_9fac99ef","updated":"2014-11-11 17:17:45.000000000","message":"yes","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"dfdd52a0d053dcb767ae05518df930b1cca12deb","unresolved":false,"context_lines":[{"line_number":3138,"context_line":"        self.assertIn(domain_list[0], domain_refs)"},{"line_number":3139,"context_line":"        self.assertIn(domain_list[1], domain_refs)"},{"line_number":3140,"context_line":""},{"line_number":3141,"context_line":""},{"line_number":3142,"context_line":"class TokenTests(object):"},{"line_number":3143,"context_line":"    def _create_token_id(self):"},{"line_number":3144,"context_line":"        # Use a token signed by the cms module"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9fac99ef","line":3141,"in_reply_to":"5a890539_dfb6228a","updated":"2014-11-11 14:18:26.000000000","message":"ah, i guess it\u0027s resolved in patches biult on top of this one?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"}],"keystone/tests/test_backend_ldap.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4ea027ca99bb7f3d06383cca8dbd7d4efc75389b","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        self.skipTest(\u0027N/A: LDAP does not support multiple domains\u0027)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def test_get_roles_for_groups_on_domain(self):"},{"line_number":413,"context_line":"        self.skipTest(\u0027Blocked by bug: 1390125\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def test_list_domains_for_groups(self):"},{"line_number":416,"context_line":"        self.skipTest(\u0027N/A: LDAP does not support multiple domains\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9210e7a9","line":413,"updated":"2014-11-12 18:33:05.000000000","message":"NIT: Please check for the actual result (e.g. what the bug causes to occur) not just skip the test.","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4ea027ca99bb7f3d06383cca8dbd7d4efc75389b","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        self.skipTest(\u0027Blocked by bug: 1390125\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def test_list_domains_for_groups(self):"},{"line_number":416,"context_line":"        self.skipTest(\u0027N/A: LDAP does not support multiple domains\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def test_list_role_assignments_unfiltered(self):"},{"line_number":419,"context_line":"        new_domain \u003d self._get_domain_fixture()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_327ad3f1","line":416,"updated":"2014-11-12 18:33:05.000000000","message":"Same as above. Please validate that LDAP throws some specific error *not* just skip the test (in general we should never skip tests like this).","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"}],"keystone/tests/test_v3_federation.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1a0af180b2c993b6108d298ff99721f60db7ec83","unresolved":false,"context_lines":[{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_scope_to_domain_with_only_inherited_roles_fails(self):"},{"line_number":1081,"context_line":"        \"\"\"Try to scope to a domain that has no direct roles.\"\"\""},{"line_number":1082,"context_line":"        self.v3_authenticate_token("},{"line_number":1083,"context_line":"            self.TOKEN_SCOPE_DOMAIN_D_FROM_CUSTOMER,"},{"line_number":1084,"context_line":"            expected_status\u003d401)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_797d37e7","line":1082,"updated":"2014-11-12 07:41:14.000000000","message":"@henry, this fails because if there are no roles, then we 401? \n\nsource: https://github.com/openstack/keystone/blob/master/keystone/token/providers/common.py#L192-L207","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"4ea027ca99bb7f3d06383cca8dbd7d4efc75389b","unresolved":false,"context_lines":[{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_scope_to_domain_with_only_inherited_roles_fails(self):"},{"line_number":1081,"context_line":"        \"\"\"Try to scope to a domain that has no direct roles.\"\"\""},{"line_number":1082,"context_line":"        self.v3_authenticate_token("},{"line_number":1083,"context_line":"            self.TOKEN_SCOPE_DOMAIN_D_FROM_CUSTOMER,"},{"line_number":1084,"context_line":"            expected_status\u003d401)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_725b7b87","line":1082,"in_reply_to":"5a890539_797d37e7","updated":"2014-11-12 18:33:05.000000000","message":"Interesting...","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"323588c9397b5d70a6fd3b2d72d5a1e71f95413e","unresolved":false,"context_lines":[{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_scope_to_domain_with_only_inherited_roles_fails(self):"},{"line_number":1081,"context_line":"        \"\"\"Try to scope to a domain that has no direct roles.\"\"\""},{"line_number":1082,"context_line":"        self.v3_authenticate_token("},{"line_number":1083,"context_line":"            self.TOKEN_SCOPE_DOMAIN_D_FROM_CUSTOMER,"},{"line_number":1084,"context_line":"            expected_status\u003d401)"},{"line_number":1085,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_86eb45af","line":1082,"in_reply_to":"5a890539_797d37e7","updated":"2014-11-12 21:32:59.000000000","message":"Yes, I think that\u0027s correct, no?","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"ac7d9078bef0e0d298afe50d7ca27ebe58fd9dd7","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"                  self.tokens[\u0027EMPLOYEE_ASSERTION\u0027],"},{"line_number":1113,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        # NOTE(henry-nash): domain D does not appear in the expected results"},{"line_number":1116,"context_line":"        # since it only had inherited roles (which only apply to projects"},{"line_number":1117,"context_line":"        # within the domain)"},{"line_number":1118,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_dea1baaa","line":1115,"updated":"2014-11-11 19:50:26.000000000","message":"Great comment!","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7becf69d8228d8858229eda0844cfbe7eb9e8193","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"                  self.tokens[\u0027EMPLOYEE_ASSERTION\u0027],"},{"line_number":1113,"context_line":"                  self.tokens[\u0027ADMIN_ASSERTION\u0027])"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        # NOTE(henry-nash): domain D does not appear in the expected results"},{"line_number":1116,"context_line":"        # since it only had inherited roles (which only apply to projects"},{"line_number":1117,"context_line":"        # within the domain)"},{"line_number":1118,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9ead728b","line":1115,"in_reply_to":"5a890539_dea1baaa","updated":"2014-11-11 19:52:59.000000000","message":"++","commit_id":"1f54bebe65897b57845e09bd4e8d12ccc9323139"}]}
