)]}'
{"keystone/assignment/backends/sql.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"00b92b5b183452c01ac3ce9a1151c65ca1dd3e28","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            assignment_type \u003d AssignmentType.GROUP_DOMAIN"},{"line_number":362,"context_line":"        elif entity \u003d\u003d Project:"},{"line_number":363,"context_line":"            assignment_type \u003d AssignmentType.GROUP_PROJECT"},{"line_number":364,"context_line":"        else:"},{"line_number":365,"context_line":"            raise exception.Error(message\u003d_("},{"line_number":366,"context_line":"                \u0027Unexpected entity encountered, %s\u0027) %entity)"},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_f3179f4f","line":364,"updated":"2014-11-11 11:48:40.000000000","message":"Can this ever happen? I think that a test should be created for this case","commit_id":"2c40e34bcb754ddc3b7dba7452f98a7acf775ad7"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b39a792659d663b2cd0276e2c7f461c7493834d7","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            assignment_type \u003d AssignmentType.GROUP_DOMAIN"},{"line_number":362,"context_line":"        elif entity \u003d\u003d Project:"},{"line_number":363,"context_line":"            assignment_type \u003d AssignmentType.GROUP_PROJECT"},{"line_number":364,"context_line":"        else:"},{"line_number":365,"context_line":"            raise exception.Error(message\u003d_("},{"line_number":366,"context_line":"                \u0027Unexpected entity encountered, %s\u0027) %entity)"},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_c452d712","line":364,"in_reply_to":"5a890539_f3179f4f","updated":"2014-11-11 13:16:00.000000000","message":"Thanks Boris.Currently, the entity should only be \"Domain\" or \"Project\" from the code where this private method is invoked, while IMO the check logic should cover any unexcepted behavior like what method of \"denormalize_role\" did. I am considering to create one testcase.","commit_id":"2c40e34bcb754ddc3b7dba7452f98a7acf775ad7"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"00b92b5b183452c01ac3ce9a1151c65ca1dd3e28","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        elif entity \u003d\u003d Project:"},{"line_number":363,"context_line":"            assignment_type \u003d AssignmentType.GROUP_PROJECT"},{"line_number":364,"context_line":"        else:"},{"line_number":365,"context_line":"            raise exception.Error(message\u003d_("},{"line_number":366,"context_line":"                \u0027Unexpected entity encountered, %s\u0027) %entity)"},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("},{"line_number":368,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_0e0f9e31","line":365,"updated":"2014-11-11 11:48:40.000000000","message":"Is the exception catched somewhere?","commit_id":"2c40e34bcb754ddc3b7dba7452f98a7acf775ad7"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b39a792659d663b2cd0276e2c7f461c7493834d7","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        elif entity \u003d\u003d Project:"},{"line_number":363,"context_line":"            assignment_type \u003d AssignmentType.GROUP_PROJECT"},{"line_number":364,"context_line":"        else:"},{"line_number":365,"context_line":"            raise exception.Error(message\u003d_("},{"line_number":366,"context_line":"                \u0027Unexpected entity encountered, %s\u0027) %entity)"},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("},{"line_number":368,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_64904396","line":365,"in_reply_to":"5a890539_0e0f9e31","updated":"2014-11-11 13:16:00.000000000","message":"Can i think this exception will be catched the same manner as where the exception from the method of \"calculate_type\" or \"denormalize_role\"?","commit_id":"2c40e34bcb754ddc3b7dba7452f98a7acf775ad7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bcf85119b7d67990c04f667b2693bd807db1da0d","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        elif entity \u003d\u003d Project:"},{"line_number":363,"context_line":"            assignment_type \u003d AssignmentType.GROUP_PROJECT"},{"line_number":364,"context_line":"        else:"},{"line_number":365,"context_line":"            raise exception.Error(message\u003d_("},{"line_number":366,"context_line":"                \u0027Unexpected entity encountered, %s\u0027) % entity)"},{"line_number":367,"context_line":"        group_sql_conditions \u003d sqlalchemy.and_("},{"line_number":368,"context_line":"            RoleAssignment.type \u003d\u003d assignment_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_2225525c","line":365,"updated":"2015-02-15 17:55:02.000000000","message":"Seems UnexpectedError would be more accurate for this error\n\nIs it also possible that add a test?","commit_id":"9c03676b594f76fbc53a96098cc5adbf8a77180e"}]}