)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"26b910cf17580dbb7be422a55f1e15d743ec09fd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"OperationlError -\u003e apply fix -\u003e complete the old migration. The main"},{"line_number":22,"context_line":"problem is the tables can\u0027t be created correctly due to applying interruption."},{"line_number":23,"context_line":"So the fix required a helper function to make the trick and possibly"},{"line_number":24,"context_line":"weird new migration."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Alternative #2: same entities as above but in this approach we drop the"},{"line_number":27,"context_line":"incomplete tables and create new but with primary key constraint."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_94fd583e","line":24,"updated":"2014-11-28 13:49:36.000000000","message":"I think it\u0027s appropriate to provide both: the fix in the current migration and the new script to fix broken deployments.","commit_id":"2ef4d3d8f15cced2b099803fd87b032179879154"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"b2f80e451d05f53f0897a4c4518fbe674528a407","unresolved":false,"context_lines":[{"line_number":21,"context_line":"OperationlError -\u003e apply fix -\u003e complete the old migration. The main"},{"line_number":22,"context_line":"problem is the tables can\u0027t be created correctly due to applying interruption."},{"line_number":23,"context_line":"So the fix required a helper function to make the trick and possibly"},{"line_number":24,"context_line":"weird new migration."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Alternative #2: same entities as above but in this approach we drop the"},{"line_number":27,"context_line":"incomplete tables and create new but with primary key constraint."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_2bb51e7e","line":24,"in_reply_to":"5a890539_94fd583e","updated":"2014-11-28 16:33:09.000000000","message":"Makes sense.","commit_id":"2ef4d3d8f15cced2b099803fd87b032179879154"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"26b910cf17580dbb7be422a55f1e15d743ec09fd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Alternative #2: same entities as above but in this approach we drop the"},{"line_number":27,"context_line":"incomplete tables and create new but with primary key constraint."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I499833f17a0383c07e8d400ac3e124d9b470bcb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_f4ecdc94","line":29,"updated":"2014-11-28 13:49:36.000000000","message":"Missing bug reference in the commit message: \n Partial-Bug: #\nor\n Related-Bug: #","commit_id":"2ef4d3d8f15cced2b099803fd87b032179879154"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"b2f80e451d05f53f0897a4c4518fbe674528a407","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Alternative #2: same entities as above but in this approach we drop the"},{"line_number":27,"context_line":"incomplete tables and create new but with primary key constraint."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I499833f17a0383c07e8d400ac3e124d9b470bcb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a890539_216c5f08","line":29,"in_reply_to":"5a890539_f4ecdc94","updated":"2014-11-28 16:33:09.000000000","message":"I had no time to file. I\u0027m going to file it today.","commit_id":"2ef4d3d8f15cced2b099803fd87b032179879154"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c6dc41ad4625ac0adb8cff7c0d201099baf34008","unresolved":false,"context_lines":[{"line_number":17,"context_line":"should modify existing migration. Added specific non-reverse migration"},{"line_number":18,"context_line":"for existing SQLIte deployment."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I499833f17a0383c07e8d400ac3e124d9b470bcb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a890539_fc2e7ef9","line":20,"updated":"2014-11-28 16:55:19.000000000","message":"still missing the bug ref","commit_id":"0474f945f35e9e463aea3b6e32b271d34723521b"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"6b2ab78feafe1af024bb66963d0e7468f5b5a7d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"should modify existing migration. Added specific non-reverse migration"},{"line_number":18,"context_line":"for existing SQLIte deployment."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I499833f17a0383c07e8d400ac3e124d9b470bcb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a890539_b3a97227","line":20,"in_reply_to":"5a890539_fc2e7ef9","updated":"2014-12-01 09:02:19.000000000","message":"Yep-yep, I\u0027m going to file the bug in a few minutes.","commit_id":"0474f945f35e9e463aea3b6e32b271d34723521b"}],"keystone/contrib/endpoint_filter/migrate_repo/versions/003_add_endpoint_group_id_primary_key.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"8e36c722057cb89ba46a78786d18347dfd9f6d93","unresolved":false,"context_lines":[{"line_number":19,"context_line":"migration has implemented. Also required this migration script to fix an"},{"line_number":20,"context_line":"existing SQLite driven deployments.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from migrate.changeset import constraint as cstrnt"},{"line_number":23,"context_line":"import sqlalchemy as sql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_16031477","line":22,"updated":"2014-12-01 09:31:32.000000000","message":"why \"as cstrnt\"? It doesn\u0027t really save much typing and is typo-prone.","commit_id":"0474f945f35e9e463aea3b6e32b271d34723521b"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"c6d87e8f3138a0239ed4b60aa9a1fb2ce2d13872","unresolved":false,"context_lines":[{"line_number":19,"context_line":"migration has implemented. Also required this migration script to fix an"},{"line_number":20,"context_line":"existing SQLite driven deployments.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from migrate.changeset import constraint as cstrnt"},{"line_number":23,"context_line":"import sqlalchemy as sql"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_edd65cf1","line":22,"in_reply_to":"5a890539_16031477","updated":"2014-12-03 12:23:09.000000000","message":"Yep, I agree — it\u0027s weird name. Will fix.","commit_id":"0474f945f35e9e463aea3b6e32b271d34723521b"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c6dc41ad4625ac0adb8cff7c0d201099baf34008","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    This migration is the fix for previously deployed instances where was"},{"line_number":41,"context_line":"    applied the #2 migration before it fixed. The #2 migration has already"},{"line_number":42,"context_line":"    fixed and contains the change."},{"line_number":43,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_7cf36e9f","line":43,"updated":"2014-11-28 16:55:19.000000000","message":"don\u0027t you need a\n pass\nhere?","commit_id":"0474f945f35e9e463aea3b6e32b271d34723521b"},{"author":{"_account_id":7536,"name":"Ilya Pekelny","email":"ipekelny@mirantis.com","username":"I159"},"change_message_id":"6b2ab78feafe1af024bb66963d0e7468f5b5a7d7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    This migration is the fix for previously deployed instances where was"},{"line_number":41,"context_line":"    applied the #2 migration before it fixed. The #2 migration has already"},{"line_number":42,"context_line":"    fixed and contains the change."},{"line_number":43,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_73a1ca45","line":43,"in_reply_to":"5a890539_7cf36e9f","updated":"2014-12-01 09:02:19.000000000","message":"Technically — no. But for clarity — yes. I\u0027ll add it.","commit_id":"0474f945f35e9e463aea3b6e32b271d34723521b"}]}
