)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d3f67a98b371fecbf5aedb6131c823e6b51d7838","unresolved":false,"context_lines":[{"line_number":11,"context_line":"It\u0027s result depends from domain\u0027s config load order. It will not detect"},{"line_number":12,"context_line":"multiple SQL backends if domain\u0027s config loaded in order like this:"},{"line_number":13,"context_line":"SQL -\u003e not SQL -\u003e SQL."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idfc03ba5314acc7ebc8ed99f078b6a08130cc1dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_6df09c67","line":14,"updated":"2014-12-12 10:41:39.000000000","message":"We need to be reference a defect here","commit_id":"e6fd3452fa73ab3834e350b6341058aa8f9de6c4"},{"author":{"_account_id":12631,"name":"Bogun Dmitriy","email":"dbogun@mirantis.com","username":"dbogun"},"change_message_id":"993330926c9a51ffe1910c0527cf8c5850a47504","unresolved":false,"context_lines":[{"line_number":11,"context_line":"It\u0027s result depends from domain\u0027s config load order. It will not detect"},{"line_number":12,"context_line":"multiple SQL backends if domain\u0027s config loaded in order like this:"},{"line_number":13,"context_line":"SQL -\u003e not SQL -\u003e SQL."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idfc03ba5314acc7ebc8ed99f078b6a08130cc1dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_6518ec76","line":14,"in_reply_to":"3a961159_6df09c67","updated":"2015-01-14 17:07:18.000000000","message":"Done","commit_id":"e6fd3452fa73ab3834e350b6341058aa8f9de6c4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"aecc4c7232ff79cb409de3c6dc11939d161d5bf9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Expose multiple SQL backend usage validation error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"File-based domain-specific configuration supports only one SQL backend."},{"line_number":10,"context_line":"The method that checkd how many SQL backends are enabled was not correct,"},{"line_number":11,"context_line":"and depending on the order of domains excamined, may give the wrong"},{"line_number":12,"context_line":"result. A follow-on patch will fix this error."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_22a6a710","line":10,"updated":"2015-04-03 05:21:34.000000000","message":"checked*","commit_id":"03aa784033a9da1834374290aeaad116fc184cf4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"eff8069b2a1d7f87b05b53cbadabcbbd68b9ed19","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Expose multiple SQL backend usage validation error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"File-based domain-specific configuration supports only one SQL backend."},{"line_number":10,"context_line":"The method that checkd how many SQL backends are enabled was not correct,"},{"line_number":11,"context_line":"and depending on the order of domains excamined, may give the wrong"},{"line_number":12,"context_line":"result. A follow-on patch will fix this error."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_0245e315","line":10,"in_reply_to":"baa041b7_22a6a710","updated":"2015-04-03 05:27:01.000000000","message":"Done","commit_id":"03aa784033a9da1834374290aeaad116fc184cf4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"aecc4c7232ff79cb409de3c6dc11939d161d5bf9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"File-based domain-specific configuration supports only one SQL backend."},{"line_number":10,"context_line":"The method that checkd how many SQL backends are enabled was not correct,"},{"line_number":11,"context_line":"and depending on the order of domains excamined, may give the wrong"},{"line_number":12,"context_line":"result. A follow-on patch will fix this error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1410850"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_a2bab721","line":11,"updated":"2015-04-03 05:21:34.000000000","message":"examined*","commit_id":"03aa784033a9da1834374290aeaad116fc184cf4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"eff8069b2a1d7f87b05b53cbadabcbbd68b9ed19","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"File-based domain-specific configuration supports only one SQL backend."},{"line_number":10,"context_line":"The method that checkd how many SQL backends are enabled was not correct,"},{"line_number":11,"context_line":"and depending on the order of domains excamined, may give the wrong"},{"line_number":12,"context_line":"result. A follow-on patch will fix this error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1410850"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_e24c3f44","line":11,"in_reply_to":"baa041b7_a2bab721","updated":"2015-04-03 05:27:01.000000000","message":"Done","commit_id":"03aa784033a9da1834374290aeaad116fc184cf4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"aecc4c7232ff79cb409de3c6dc11939d161d5bf9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The method that checkd how many SQL backends are enabled was not correct,"},{"line_number":11,"context_line":"and depending on the order of domains excamined, may give the wrong"},{"line_number":12,"context_line":"result. A follow-on patch will fix this error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1410850"},{"line_number":15,"context_line":"Change-Id: Idfc03ba5314acc7ebc8ed99f078b6a08130cc1dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_227d876e","line":13,"updated":"2015-04-03 05:21:34.000000000","message":"list yourself as a co-author\n\nCo-Authored-By: Henry Nash \u003cemail\u003e","commit_id":"03aa784033a9da1834374290aeaad116fc184cf4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"eff8069b2a1d7f87b05b53cbadabcbbd68b9ed19","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The method that checkd how many SQL backends are enabled was not correct,"},{"line_number":11,"context_line":"and depending on the order of domains excamined, may give the wrong"},{"line_number":12,"context_line":"result. A follow-on patch will fix this error."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1410850"},{"line_number":15,"context_line":"Change-Id: Idfc03ba5314acc7ebc8ed99f078b6a08130cc1dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baa041b7_c247fb1b","line":13,"in_reply_to":"baa041b7_227d876e","updated":"2015-04-03 05:27:01.000000000","message":"Done","commit_id":"03aa784033a9da1834374290aeaad116fc184cf4"}],"keystone/identity/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d3f67a98b371fecbf5aedb6131c823e6b51d7838","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                # one sql driver, so raise an exception."},{"line_number":109,"context_line":"                raise exception.MultipleSQLDriversInConfig("},{"line_number":110,"context_line":"                    config_file\u003dconfig_file)"},{"line_number":111,"context_line":"            self._any_sql |\u003d new_config[\u0027driver\u0027].is_sql"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        try:"},{"line_number":114,"context_line":"            domain_ref \u003d assignment_api.get_domain_by_name(domain_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_0ddab8e7","line":111,"updated":"2014-12-12 10:41:39.000000000","message":"Personally, I\u0027d be tempted to just restructure this block to be:\n\nif new_config[\u0027driver\u0027].is_sql:\n    if self._any_sql:\n        raise exception....\n    else\n        self._any_sql \u003d True","commit_id":"e6fd3452fa73ab3834e350b6341058aa8f9de6c4"},{"author":{"_account_id":12631,"name":"Bogun Dmitriy","email":"dbogun@mirantis.com","username":"dbogun"},"change_message_id":"993330926c9a51ffe1910c0527cf8c5850a47504","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                # one sql driver, so raise an exception."},{"line_number":109,"context_line":"                raise exception.MultipleSQLDriversInConfig("},{"line_number":110,"context_line":"                    config_file\u003dconfig_file)"},{"line_number":111,"context_line":"            self._any_sql |\u003d new_config[\u0027driver\u0027].is_sql"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        try:"},{"line_number":114,"context_line":"            domain_ref \u003d assignment_api.get_domain_by_name(domain_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_02e9de7e","line":111,"in_reply_to":"3a961159_0ddab8e7","updated":"2015-01-14 17:07:18.000000000","message":"Done","commit_id":"e6fd3452fa73ab3834e350b6341058aa8f9de6c4"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"05bc4bc63995af39fef0244f650a187a4d191fd4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # This is called by the api call wrapper"},{"line_number":139,"context_line":"        self.configured \u003d True"},{"line_number":140,"context_line":"        self.driver \u003d standard_driver"},{"line_number":141,"context_line":"        self._any_sql \u003d self.driver.is_sql"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        conf_dir \u003d CONF.identity.domain_config_dir"},{"line_number":144,"context_line":"        if not os.path.exists(conf_dir):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_d5373cfc","line":141,"updated":"2015-01-16 12:51:59.000000000","message":"As asserted on existing tests, the standard driver may be None.\nIn this case, you should use:\n\nself._any_sql \u003d self.driver and self.driver.is_sql","commit_id":"c88ba9fc23fc888d9402498606623f0f10fb1311"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e035e4fcf41643853eda6fbe9c4f18cb9e0d7e8c","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            \"\"\""},{"line_number":106,"context_line":"            if new_config[\u0027driver\u0027].is_sql:"},{"line_number":107,"context_line":"                if self._any_sql:"},{"line_number":108,"context_line":"                    # The addition of this driver would cause us to have more"},{"line_number":109,"context_line":"                    # than one sql driver, so raise an exception."},{"line_number":110,"context_line":"                    raise exception.MultipleSQLDriversInConfig("}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_7022afba","line":107,"updated":"2015-02-02 16:56:58.000000000","message":"If you change this to \u0027if (self.driver.is_sql or self._any_sql):\u0027 you would not need the section on line 141 at all. But I\u0027m not opposed to this here.","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":12631,"name":"Bogun Dmitriy","email":"dbogun@mirantis.com","username":"dbogun"},"change_message_id":"a5704cf4e427adb28fa2aa6b705de88b62c19e48","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            \"\"\""},{"line_number":106,"context_line":"            if new_config[\u0027driver\u0027].is_sql:"},{"line_number":107,"context_line":"                if self._any_sql:"},{"line_number":108,"context_line":"                    # The addition of this driver would cause us to have more"},{"line_number":109,"context_line":"                    # than one sql driver, so raise an exception."},{"line_number":110,"context_line":"                    raise exception.MultipleSQLDriversInConfig("}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_5c1cc677","line":107,"in_reply_to":"da86d52c_7022afba","updated":"2015-02-03 09:17:58.000000000","message":"How it can be self.driver.is_sql or self._any_sql ??? At least it must be \"and\", not \"or\". And if it will be \"and\" it don\u0027t work as required.","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"414632fe35def1ebc6e57dedad9f18ec336023d0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # This is called by the api call wrapper"},{"line_number":139,"context_line":"        self.configured \u003d True"},{"line_number":140,"context_line":"        self.driver \u003d standard_driver"},{"line_number":141,"context_line":"        self._any_sql \u003d False"},{"line_number":142,"context_line":"        if self.driver is not None:"},{"line_number":143,"context_line":"            self._any_sql \u003d self.driver.is_sql"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_a8b5b7d1","line":141,"updated":"2015-02-09 01:55:16.000000000","message":"add a comment why we\u0027ve got another place that sets _any_sql to false... it was initialized to False, and then gets set and checked in assert_no_more_than_one_sql_driver ... why do we also reset it here?","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e035e4fcf41643853eda6fbe9c4f18cb9e0d7e8c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.configured \u003d True"},{"line_number":140,"context_line":"        self.driver \u003d standard_driver"},{"line_number":141,"context_line":"        self._any_sql \u003d False"},{"line_number":142,"context_line":"        if self.driver is not None:"},{"line_number":143,"context_line":"            self._any_sql \u003d self.driver.is_sql"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        conf_dir \u003d CONF.identity.domain_config_dir"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_5095ab3e","line":142,"updated":"2015-02-02 16:56:58.000000000","message":"I don\u0027t like this because it weakens the interface. Right now this has to be something that at least has an `is_sql` attribute (maybe more things if I read more of the code) If you want to keep this section I think you can just write \u0027self._any_sql \u003d self.driver.is_sql\u0027 and call it a day.","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":12631,"name":"Bogun Dmitriy","email":"dbogun@mirantis.com","username":"dbogun"},"change_message_id":"a5704cf4e427adb28fa2aa6b705de88b62c19e48","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.configured \u003d True"},{"line_number":140,"context_line":"        self.driver \u003d standard_driver"},{"line_number":141,"context_line":"        self._any_sql \u003d False"},{"line_number":142,"context_line":"        if self.driver is not None:"},{"line_number":143,"context_line":"            self._any_sql \u003d self.driver.is_sql"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        conf_dir \u003d CONF.identity.domain_config_dir"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_1cedeeef","line":142,"in_reply_to":"da86d52c_5095ab3e","updated":"2015-02-03 09:17:58.000000000","message":"Actually it was done, as you say (see patchset 4). But self.driver can be None... so we need this check and this section.","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"}],"keystone/tests/unit/identity/test_core.py":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"05bc4bc63995af39fef0244f650a187a4d191fd4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        mock_assignment_api.get_domain_by_name.side_effect \u003d e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        domain_config \u003d identity.DomainConfigs()"},{"line_number":59,"context_line":"        fake_standard_driver \u003d mock.Mock(is_sql\u003dTrue)"},{"line_number":60,"context_line":"        domain_config.setup_domain_drivers(fake_standard_driver,"},{"line_number":61,"context_line":"                                           mock_assignment_api)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_5530ace8","line":59,"updated":"2015-01-16 12:51:59.000000000","message":"Unrelated change. As this test is originally doing, the standard_driver may be None, right?","commit_id":"c88ba9fc23fc888d9402498606623f0f10fb1311"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"05bc4bc63995af39fef0244f650a187a4d191fd4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                               \u0027_load_config\u0027) as mock_load_config:"},{"line_number":74,"context_line":"            domain_config \u003d identity.DomainConfigs()"},{"line_number":75,"context_line":"            fake_assignment_api \u003d None"},{"line_number":76,"context_line":"            fake_standard_driver \u003d mock.Mock(is_sql\u003dTrue)"},{"line_number":77,"context_line":"            domain_config.setup_domain_drivers(fake_standard_driver,"},{"line_number":78,"context_line":"                                               fake_assignment_api)"},{"line_number":79,"context_line":"            mock_load_config.assert_called_once_with(fake_assignment_api,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_150c6441","line":76,"updated":"2015-01-16 12:51:59.000000000","message":"Same as above.","commit_id":"c88ba9fc23fc888d9402498606623f0f10fb1311"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"c159ea5456dd7f4be2f30bca702e2a3b3f8added","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        assignment_api \u003d mock.Mock()"},{"line_number":103,"context_line":"        id_factory \u003d itertools.count()"},{"line_number":104,"context_line":"        assignment_api.get_domain_by_name.side_effect \u003d ("},{"line_number":105,"context_line":"            lambda name: dict(id\u003dnext(id_factory), _\u003d\u0027fake_domain\u0027))"},{"line_number":106,"context_line":"        load_driver_mock \u003d mock.Mock(side_effect\u003ddrivers)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        with mock.patch.object(os, \u0027walk\u0027, walk_fake):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_f407931c","line":105,"updated":"2015-01-20 03:45:15.000000000","message":"For performance reasons, we are updating dict constructs to dict comprehensions. Please take a look at [1].\n\nThen it should be:\n\n    lambda name: {id:next(id_factory), _:\u0027fake_domain\u0027}\n\n[1] https://review.openstack.org/#/c/143842","commit_id":"3a4063655807c9f19d6321e5f9c2ff357a98e43b"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"414632fe35def1ebc6e57dedad9f18ec336023d0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                     [domain_config_filename],"},{"line_number":81,"context_line":"                                                     \u0027abc.def.com\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_config_for_multiple_sql_backend(self):"},{"line_number":84,"context_line":"        domains_config \u003d identity.DomainConfigs()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        drivers \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_08ec03c7","line":83,"updated":"2015-02-09 01:55:16.000000000","message":"add a comment that describes why this test is here (what is it testing?)","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b24329c3f484effe77e8de1657f29d1ba885969d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                     [domain_config_filename],"},{"line_number":81,"context_line":"                                                     \u0027abc.def.com\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_config_for_multiple_sql_backend(self):"},{"line_number":84,"context_line":"        domains_config \u003d identity.DomainConfigs()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        drivers \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_daaf232a","line":83,"in_reply_to":"da86d52c_08ec03c7","updated":"2015-02-20 09:19:55.000000000","message":"In fact there is a test already for this case - test_multiple_sql_specific_drivers_fails in test_backend_ldap.py.  Since this test failed to pick up this bug, I\u0027d suggest we improve that before we add something different here.","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"414632fe35def1ebc6e57dedad9f18ec336023d0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        with mock.patch.object(os, \u0027walk\u0027, walk_fake):"},{"line_number":109,"context_line":"            with mock.patch.object(identity.cfg, \u0027ConfigOpts\u0027):"},{"line_number":110,"context_line":"                with mock.patch.object(domains_config, \u0027_load_driver\u0027,"},{"line_number":111,"context_line":"                                       load_driver_mock):"},{"line_number":112,"context_line":"                    self.assertRaises("},{"line_number":113,"context_line":"                        exception.MultipleSQLDriversInConfig,"},{"line_number":114,"context_line":"                        domains_config.setup_domain_drivers,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da86d52c_c8e10bd2","line":111,"updated":"2015-02-09 01:55:16.000000000","message":"use oslotest.mockpatch so that the code isn\u0027t indented so much: http://docs.openstack.org/developer/oslotest/api.html#module-oslotest.mockpatch","commit_id":"d677e4643c0c520fa1af5ade30b75c41c3bca22d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"978e62bd7218d5664b6c883cf03593aff88bbfff","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            with mock.patch.object(identity.cfg, \u0027ConfigOpts\u0027):"},{"line_number":114,"context_line":"                with mock.patch.object(domains_config, \u0027_load_driver\u0027,"},{"line_number":115,"context_line":"                                       load_driver_mock):"},{"line_number":116,"context_line":"                    # TODO(henry-nash): The following call should fail since"},{"line_number":117,"context_line":"                    # we are asking for two sql drivers.  See bug #1410850."},{"line_number":118,"context_line":"                    domains_config.setup_domain_drivers("},{"line_number":119,"context_line":"                        generic_driver, assignment_api)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baa041b7_2d19f379","line":116,"updated":"2015-04-03 11:26:07.000000000","message":"In the future you can write the tests using the wip decorator. That will let you write them how they should be and it will ignore the failure. Then the follow up patch can fix the code and just delete the decorator.","commit_id":"fdc150fe98be693bdc7a61b87efc492ccc693210"}]}