)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"9e1aff219173d7e4e8629325ce4d8e40af1c3fae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"orderings."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2875a10e77beaa1b491ac4fc579bcaada159c4fc"},{"line_number":20,"context_line":"Partial-Bug: #1348818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a961159_1aaeace7","line":20,"updated":"2015-01-05 15:12:07.000000000","message":"Bug number in Partial-Bug, Related-Bug or Closes-Bug tags should not contain a # in the bug number, according to Gerrit Workflow doc [1].\n\nThis is hapenning in all patches in this chain, starting here.\n\n[1] https://wiki.openstack.org/wiki/Gerrit_Workflow","commit_id":"7401e1ce69b799170fd6174282ff81a7c6a04732"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"54de20c3943cb29a4ad293de820c5591b722f03c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"orderings."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2875a10e77beaa1b491ac4fc579bcaada159c4fc"},{"line_number":20,"context_line":"Partial-Bug: #1348818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a961159_da57c4c8","line":20,"in_reply_to":"3a961159_1aaeace7","updated":"2015-01-05 23:22:27.000000000","message":"The Git commit messages doc says to use #:\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"7401e1ce69b799170fd6174282ff81a7c6a04732"}],"keystone/tests/matchers.py":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"9e1aff219173d7e4e8629325ce4d8e40af1c3fae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            if expected_doc.attrib !\u003d observed_doc.attrib:"},{"line_number":49,"context_line":"                return False"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            def _compare_elems(el1, el2):"},{"line_number":52,"context_line":"                if el1.tag \u003c el2.tag:"},{"line_number":53,"context_line":"                    return -1"},{"line_number":54,"context_line":"                if el1.tag \u003e el2.tag:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_7700a902","line":51,"updated":"2015-01-05 15:12:07.000000000","message":"I think declaring inner functions just after outer declaration improves readability. As we are doing with methods match() and xml_element_equals().","commit_id":"7401e1ce69b799170fd6174282ff81a7c6a04732"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"54de20c3943cb29a4ad293de820c5591b722f03c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            if expected_doc.attrib !\u003d observed_doc.attrib:"},{"line_number":49,"context_line":"                return False"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            def _compare_elems(el1, el2):"},{"line_number":52,"context_line":"                if el1.tag \u003c el2.tag:"},{"line_number":53,"context_line":"                    return -1"},{"line_number":54,"context_line":"                if el1.tag \u003e el2.tag:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_86a6bb52","line":51,"in_reply_to":"3a961159_7700a902","updated":"2015-01-05 23:22:27.000000000","message":"I don\u0027t want to change the convention that\u0027s used in this function already or add unrelated changes to the commit. You or anybody else could propose a separate commit with a PEP8 check to clean this up.","commit_id":"7401e1ce69b799170fd6174282ff81a7c6a04732"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"9e1aff219173d7e4e8629325ce4d8e40af1c3fae","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            expected_children \u003d _sorted_children(expected_doc)"},{"line_number":75,"context_line":"            observed_children \u003d _sorted_children(observed_doc)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            if len(expected_children) !\u003d len(observed_children):"},{"line_number":78,"context_line":"                return False"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            for expected_el, observed_el in zip(expected_children,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_175da548","line":77,"updated":"2015-01-05 15:12:07.000000000","message":"Unrelated to this patch, but this check could be done before sorting children elements.","commit_id":"7401e1ce69b799170fd6174282ff81a7c6a04732"}]}