)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2bd67bd7f3196f407f7948625147549c17562d4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-04 20:04:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reuse call to _get_project_endpoint_group in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change creates a new function that has a more descriptive name and allows"},{"line_number":10,"context_line":"for code reuse."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_40ff1902","line":7,"updated":"2015-02-18 22:22:59.000000000","message":"Maybe call this, \"Rename _get_project_endpoint_group\" \n\nThe code that is proposed doesn\u0027t \u0027re-use\u0027 _get_project...blah. \nif you are going to rename it, rename them all?","commit_id":"b9874df57cae2f8f371087126c5190e4b968b800"}],"keystone/tests/test_associate_project_endpoint_extension.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c7356a7579a45f47bc0cdd8ebd35256519f0f04d","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    def _associate_endpoint_group_with_project(self,"},{"line_number":1038,"context_line":"                                               endpoint_group_id,"},{"line_number":1039,"context_line":"                                               project_id):"},{"line_number":1040,"context_line":"        return self._get_project_endpoint_group_url(endpoint_group_id,"},{"line_number":1041,"context_line":"                                                    project_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _get_project_endpoint_group_url(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_aaf5b6ee","line":1040,"updated":"2014-12-05 10:25:56.000000000","message":"Why can\u0027t we do just\n_associate_endpoint_group_with_project \u003d _get_project_endpoint_group_url?","commit_id":"b9874df57cae2f8f371087126c5190e4b968b800"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"43e6f7f47f1309cab92d1d3ce9a3a7fdceadebe6","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    def _associate_endpoint_group_with_project(self,"},{"line_number":1038,"context_line":"                                               endpoint_group_id,"},{"line_number":1039,"context_line":"                                               project_id):"},{"line_number":1040,"context_line":"        return self._get_project_endpoint_group_url(endpoint_group_id,"},{"line_number":1041,"context_line":"                                                    project_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _get_project_endpoint_group_url(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_3a71ed44","line":1040,"in_reply_to":"3a961159_14cedf5a","updated":"2015-02-09 18:19:26.000000000","message":"Hi Lance and Boris. Here we are just bypassing the calls on _associate_endpoint_group_with_project to _get_project_endpoint_group_url, with the same arguments and in the same order.\n\nIf we really want to do it this way, we could just replace this whole method declaration by:\n\n    _associate_endpoint_group_with_project \u003d (\n        _get_project_endpoint_group_url)\n\nthat should be put after _get_project_endpoint_group_url declaration. I think that is what Boris was proposing.\n\nHowever, I think _get_project_endpoint_group_url is more meaningful than _associate_endpoint_group_with_project, since we just return the URL in both methods.\n\nI do not see an advantage on the approach being proposed in this change, but if we really go this way, I would propose this method to look like:\n\n    def _associate_endpoint_group_with_project(self, endpoint_group_id, project_id):\n        url \u003d (\u0027/OS-EP-FILTER/endpoint_groups/%(endpoint_group_id)s\u0027\n               \u0027/projects/%(project_id)s\u0027 %\n               {\u0027endpoint_group_id\u0027: endpoint_group_id,\n                \u0027project_id\u0027: project_id})\n        self.put(url)\n        return url\n\nSo that this could be used everywhere and then the method _get_project_endpoint_group_url could be removed.","commit_id":"b9874df57cae2f8f371087126c5190e4b968b800"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"d4c43934ca17d8afd6f1aa1c8cb5fe7a0a748ea8","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    def _associate_endpoint_group_with_project(self,"},{"line_number":1038,"context_line":"                                               endpoint_group_id,"},{"line_number":1039,"context_line":"                                               project_id):"},{"line_number":1040,"context_line":"        return self._get_project_endpoint_group_url(endpoint_group_id,"},{"line_number":1041,"context_line":"                                                    project_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _get_project_endpoint_group_url(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_67df7bd7","line":1040,"in_reply_to":"5a890539_5b15054b","updated":"2014-12-05 16:41:39.000000000","message":"OK, but why can\u0027t we just assign to _associate_endpoint_group_with_project value _get_project_endpoint_group_url? :)","commit_id":"b9874df57cae2f8f371087126c5190e4b968b800"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"147152faeb087e7b4f2e8dde46676d4a59a86783","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    def _associate_endpoint_group_with_project(self,"},{"line_number":1038,"context_line":"                                               endpoint_group_id,"},{"line_number":1039,"context_line":"                                               project_id):"},{"line_number":1040,"context_line":"        return self._get_project_endpoint_group_url(endpoint_group_id,"},{"line_number":1041,"context_line":"                                                    project_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _get_project_endpoint_group_url(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_14cedf5a","line":1040,"in_reply_to":"5a890539_67df7bd7","updated":"2014-12-08 14:32:44.000000000","message":"as in rename _get_project_endpoint_group_url() to _associate_endpoint_group_with_project()?","commit_id":"b9874df57cae2f8f371087126c5190e4b968b800"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5f651b04768465bb1c1c7ec0d284def87a4a795b","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    def _associate_endpoint_group_with_project(self,"},{"line_number":1038,"context_line":"                                               endpoint_group_id,"},{"line_number":1039,"context_line":"                                               project_id):"},{"line_number":1040,"context_line":"        return self._get_project_endpoint_group_url(endpoint_group_id,"},{"line_number":1041,"context_line":"                                                    project_id)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _get_project_endpoint_group_url(self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_5b15054b","line":1040,"in_reply_to":"5a890539_aaf5b6ee","updated":"2014-12-05 13:08:48.000000000","message":"it was a suggestion made here: \n\nhttps://review.openstack.org/#/c/139080/1/keystone/tests/test_associate_project_endpoint_extension.py","commit_id":"b9874df57cae2f8f371087126c5190e4b968b800"}]}