)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9e1fb61a6a378592689b3545fb37a6f04e650ef1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-12-10 09:56:07 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong log message in token flush"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a7c30bd8e49a86ba4393228cdb4573b8208f751"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_eda48ca7","line":8,"updated":"2014-12-12 10:29:16.000000000","message":"This needs to reference a defect or spec","commit_id":"5cc48e7f61ee53f1a5e58475dc6876ba92e1f77f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7fe9745371e9d2e782a0722b6cb0b0ccbf9b7aa6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haneef Ali \u003chaneef.ali@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-15 09:01:55 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong log message in token flush"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a7c30bd8e49a86ba4393228cdb4573b8208f751"},{"line_number":10,"context_line":"Closes-Bug: #1402760"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a961159_9524a60f","line":7,"updated":"2014-12-15 18:14:55.000000000","message":"what\u0027s wrong with it? Also, a similar change is proposed in https://review.openstack.org/#/c/131003/","commit_id":"aa631f9de442acf32629d15f5a78987c5f15b53a"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"76ba862b6634955ee3536f8b6bead60d11e222a1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix wrong log message in token flush"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a7c30bd8e49a86ba4393228cdb4573b8208f751"},{"line_number":10,"context_line":"Closes-Bug: #1402760"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_e2db3a1f","line":10,"updated":"2015-02-15 18:37:49.000000000","message":"Not sure how this addresses the bug reported, am I missing something?","commit_id":"aa631f9de442acf32629d15f5a78987c5f15b53a"}],"keystone/token/persistence/backends/sql.py":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"28cda2565394a482fab8a8d891e6c6d8781bdbc4","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                                        expiry_time)"},{"line_number":274,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":275,"context_line":"            total_removed +\u003d row_count"},{"line_number":276,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        session.flush()"},{"line_number":279,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_66f8efc3","line":276,"updated":"2014-12-11 02:37:41.000000000","message":"I don\u0027t think logging how many tokens expired on each iteration is meaningful, since we don\u0027t have any idea of the state that carried those expirations (expiry_time, etc.)\n\nI think it makes more sense to have logged just the final count, i.e. just put the original log out of this for.","commit_id":"5cc48e7f61ee53f1a5e58475dc6876ba92e1f77f"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"370aa647b61527ff39fe2b14ede188434f51e3fc","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                                        expiry_time)"},{"line_number":274,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":275,"context_line":"            total_removed +\u003d row_count"},{"line_number":276,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        session.flush()"},{"line_number":279,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e6321f5e","line":276,"in_reply_to":"3a961159_66f8efc3","updated":"2014-12-11 02:56:03.000000000","message":"I agree with Samuel de Medeiros Queiroz, but I think the original log is enough...","commit_id":"5cc48e7f61ee53f1a5e58475dc6876ba92e1f77f"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"d13b0a6eb4f02a1d81575c344744a530dd77db2b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                                        expiry_time)"},{"line_number":274,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":275,"context_line":"            total_removed +\u003d row_count"},{"line_number":276,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        session.flush()"},{"line_number":279,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9bb8a9c9","line":276,"in_reply_to":"3a961159_c66eea2e","updated":"2014-12-12 03:24:10.000000000","message":"I did not notice line 279. I think this makes sense.","commit_id":"5cc48e7f61ee53f1a5e58475dc6876ba92e1f77f"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"799a07cc8019301ff0d3e61fa86001529dbb302f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                                        expiry_time)"},{"line_number":274,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":275,"context_line":"            total_removed +\u003d row_count"},{"line_number":276,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        session.flush()"},{"line_number":279,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c66eea2e","line":276,"in_reply_to":"3a961159_e6321f5e","updated":"2014-12-11 16:59:59.000000000","message":"We are logging 2 things. \n   1) Total tokens deleted during each batch\n   2) Final total count at the end of loop\n\nIf you look at the original code,  in both the places it is logging total count.\n\nPlease have a look at line 276  \u0026 279. Intention of 276 is to log count on that iteration, but it just used wrong value\n\nBTW  it is useful to log tokens removed on each iteration, as it helps us analyse how long each batch took","commit_id":"5cc48e7f61ee53f1a5e58475dc6876ba92e1f77f"}]}