)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8bf8a76a110cb8da4b14cc39e01242b9723b2e4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"invalidate cache when updating catalog objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we forgot invalidate cache when updating service, region,"},{"line_number":10,"context_line":"endpoint successfully..."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3ed2aa916caabda9b94a7c31564413aa81b603d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_5916e2f2","line":9,"updated":"2014-12-16 11:54:31.000000000","message":"why the three dots in the end? Is there any other entity that should have its cache invalidated?","commit_id":"a2d9b61b5ca99ba98506bd5f10d9c7fe80a76f6d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"8bf8a76a110cb8da4b14cc39e01242b9723b2e4e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"invalidate cache when updating catalog objects"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we forgot invalidate cache when updating service, region,"},{"line_number":10,"context_line":"endpoint successfully..."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3ed2aa916caabda9b94a7c31564413aa81b603d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_f9706e75","line":10,"updated":"2014-12-16 11:54:31.000000000","message":"this sounds like a bug to me, maybe would be better to create one to reference here.","commit_id":"a2d9b61b5ca99ba98506bd5f10d9c7fe80a76f6d"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"3f65b711324be9788a14983880975c5cfc2f9dc7","unresolved":false,"context_lines":[{"line_number":4555,"context_line":"        self.catalog_api.get_service(service_id)"},{"line_number":4556,"context_line":"        updated_service \u003d copy.deepcopy(new_service)"},{"line_number":4557,"context_line":"        updated_service[\u0027description\u0027] \u003d uuid.uuid4().hex"},{"line_number":4558,"context_line":"        self.catalog_api.driver.update_service(service_id, updated_service)"},{"line_number":4559,"context_line":"        self.assertDictContainsSubset(new_service,"},{"line_number":4560,"context_line":"                                      self.catalog_api.get_service(service_id))"},{"line_number":4561,"context_line":"        self.catalog_api.get_service.invalidate(self.catalog_api, service_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_aa23c3a5","line":4558,"updated":"2014-12-17 09:19:23.000000000","message":"What\u0027s this change for?","commit_id":"a62bf7b574a059c059edb9be3c726310ae27f06e"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"ad920d77dd94298d613c439e3c26603e628485ad","unresolved":false,"context_lines":[{"line_number":4555,"context_line":"        self.catalog_api.get_service(service_id)"},{"line_number":4556,"context_line":"        updated_service \u003d copy.deepcopy(new_service)"},{"line_number":4557,"context_line":"        updated_service[\u0027description\u0027] \u003d uuid.uuid4().hex"},{"line_number":4558,"context_line":"        self.catalog_api.driver.update_service(service_id, updated_service)"},{"line_number":4559,"context_line":"        self.assertDictContainsSubset(new_service,"},{"line_number":4560,"context_line":"                                      self.catalog_api.get_service(service_id))"},{"line_number":4561,"context_line":"        self.catalog_api.get_service.invalidate(self.catalog_api, service_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ca7baf27","line":4558,"in_reply_to":"3a961159_aa23c3a5","updated":"2014-12-17 09:36:11.000000000","message":"Before, update does not invalidate cache, so, line 4559 can get new_service rather than update_service. Now, update would invalidate cache, so, we should call driver directly.","commit_id":"a62bf7b574a059c059edb9be3c726310ae27f06e"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"37ea5d5a83dfc341e7fd0a21a4f56acb07433078","unresolved":false,"context_lines":[{"line_number":4555,"context_line":"        self.catalog_api.get_service(service_id)"},{"line_number":4556,"context_line":"        updated_service \u003d copy.deepcopy(new_service)"},{"line_number":4557,"context_line":"        updated_service[\u0027description\u0027] \u003d uuid.uuid4().hex"},{"line_number":4558,"context_line":"        self.catalog_api.driver.update_service(service_id, updated_service)"},{"line_number":4559,"context_line":"        self.assertDictContainsSubset(new_service,"},{"line_number":4560,"context_line":"                                      self.catalog_api.get_service(service_id))"},{"line_number":4561,"context_line":"        self.catalog_api.get_service.invalidate(self.catalog_api, service_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_78d61129","line":4558,"in_reply_to":"3a961159_ca7baf27","updated":"2014-12-17 10:38:38.000000000","message":"Nice catch!","commit_id":"a62bf7b574a059c059edb9be3c726310ae27f06e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"818c694a273467a882cd2cec612480bfe0f887ae","unresolved":false,"context_lines":[{"line_number":4434,"context_line":"        # cache the region"},{"line_number":4435,"context_line":"        self.catalog_api.get_region(region_id)"},{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"        # update the region bypassing catalog_api"},{"line_number":4438,"context_line":"        new_description \u003d {\u0027description\u0027: uuid.uuid4().hex}"},{"line_number":4439,"context_line":"        self.catalog_api.update_region(region_id, new_description)"},{"line_number":4440,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b9b87b76","line":4437,"updated":"2014-12-30 21:49:36.000000000","message":"This doesn\u0027t bypass the catalog_api.","commit_id":"0d6431f89ff05b22dcd9b067313fe618474fefe7"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"dc599800878d99ea2aa726ad490068767390df66","unresolved":false,"context_lines":[{"line_number":4434,"context_line":"        # cache the region"},{"line_number":4435,"context_line":"        self.catalog_api.get_region(region_id)"},{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"        # update the region bypassing catalog_api"},{"line_number":4438,"context_line":"        new_description \u003d {\u0027description\u0027: uuid.uuid4().hex}"},{"line_number":4439,"context_line":"        self.catalog_api.update_region(region_id, new_description)"},{"line_number":4440,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ce149c4f","line":4437,"in_reply_to":"3a961159_b9b87b76","updated":"2014-12-31 01:11:10.000000000","message":"Yes, my mistake.","commit_id":"0d6431f89ff05b22dcd9b067313fe618474fefe7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"818c694a273467a882cd2cec612480bfe0f887ae","unresolved":false,"context_lines":[{"line_number":4565,"context_line":"        self.catalog_api.get_service(service_id)"},{"line_number":4566,"context_line":"        updated_service \u003d copy.deepcopy(new_service)"},{"line_number":4567,"context_line":"        updated_service[\u0027description\u0027] \u003d uuid.uuid4().hex"},{"line_number":4568,"context_line":"        self.catalog_api.driver.update_service(service_id, updated_service)"},{"line_number":4569,"context_line":"        self.assertDictContainsSubset(new_service,"},{"line_number":4570,"context_line":"                                      self.catalog_api.get_service(service_id))"},{"line_number":4571,"context_line":"        self.catalog_api.get_service.invalidate(self.catalog_api, service_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_398d6bd4","line":4568,"updated":"2014-12-30 21:49:36.000000000","message":"should add a comment before this \"# update bypassing catalog api\"","commit_id":"0d6431f89ff05b22dcd9b067313fe618474fefe7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"818c694a273467a882cd2cec612480bfe0f887ae","unresolved":false,"context_lines":[{"line_number":4600,"context_line":"        # cache the service"},{"line_number":4601,"context_line":"        self.catalog_api.get_service(service_id)"},{"line_number":4602,"context_line":""},{"line_number":4603,"context_line":"        # update the service bypassing catalog api"},{"line_number":4604,"context_line":"        new_type \u003d {\u0027type\u0027: uuid.uuid4().hex}"},{"line_number":4605,"context_line":"        self.catalog_api.update_service(service_id, new_type)"},{"line_number":4606,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_d9ae272f","line":4603,"updated":"2014-12-30 21:49:36.000000000","message":"This doesn\u0027t bypass the catalog api.","commit_id":"0d6431f89ff05b22dcd9b067313fe618474fefe7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"818c694a273467a882cd2cec612480bfe0f887ae","unresolved":false,"context_lines":[{"line_number":4840,"context_line":"        # cache the endpoint"},{"line_number":4841,"context_line":"        self.catalog_api.get_endpoint(endpoint_id)"},{"line_number":4842,"context_line":""},{"line_number":4843,"context_line":"        # update the endpoint bypassing catalog api"},{"line_number":4844,"context_line":"        new_url \u003d {\u0027url\u0027: uuid.uuid4().hex}"},{"line_number":4845,"context_line":"        self.catalog_api.update_endpoint(endpoint_id, new_url)"},{"line_number":4846,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_19a98f24","line":4843,"updated":"2014-12-30 21:49:36.000000000","message":"This doesn\u0027t bypass the catalog api.","commit_id":"0d6431f89ff05b22dcd9b067313fe618474fefe7"}]}