)]}'
{"keystone/auth/controllers.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"20a70c456098d44fc336f996d567ff6170b5483a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # domain scope: (domain_id, None, None, None)"},{"line_number":144,"context_line":"        # trust scope: (None, None, trust_ref, None)"},{"line_number":145,"context_line":"        # unscoped: (None, None, None, \"unscoped\")"},{"line_number":146,"context_line":"        # default: (None, None, None, \"unscoped\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _assert_project_is_enabled(self, project_ref):"},{"line_number":149,"context_line":"        # ensure the project is enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_d531fc59","line":146,"updated":"2015-01-16 12:47:35.000000000","message":"Default shouldn\u0027t be equal to project scope?\n\nIf not, there is an \"else\" statement missing in the _validate_and_normalize_scope_data() method? But I guess it would change the desired behavior since the token scope should be the default_project?\n\nAnother issue is if the default_project from a user is deleted, this user won\u0027t be able to get tokens anymore if don\u0027t specify a scope or it will receive an unscoped token?","commit_id":"d486f98cbbb00380998b3d9e4123ce73c5680e07"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"453ee5c4fecee42da60ddf41841d5d90a4b66210","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # domain scope: (domain_id, None, None, None)"},{"line_number":144,"context_line":"        # trust scope: (None, None, trust_ref, None)"},{"line_number":145,"context_line":"        # unscoped: (None, None, None, \"unscoped\")"},{"line_number":146,"context_line":"        # default: (None, None, None, \"unscoped\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _assert_project_is_enabled(self, project_ref):"},{"line_number":149,"context_line":"        # ensure the project is enabled"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_f8d0a5f8","line":146,"in_reply_to":"3a961159_d531fc59","updated":"2015-01-16 17:40:10.000000000","message":"well it depends how you view the default...it\u0027s only a project scoped token by default IF the user has a default project set - they don\u0027t then it is unscoped.  Maybe this line is just confusing...since we never set the default explicitly anywhere...it is generated by code","commit_id":"d486f98cbbb00380998b3d9e4123ce73c5680e07"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"20a70c456098d44fc336f996d567ff6170b5483a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                attribute\u003d\u0027project, domain, or OS-TRUST:trust\u0027,"},{"line_number":235,"context_line":"                target\u003d\u0027scope\u0027)"},{"line_number":236,"context_line":"        if \u0027unscoped\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":237,"context_line":"            self._scope_data \u003d (None, None, None, \"unscoped\")"},{"line_number":238,"context_line":"            return"},{"line_number":239,"context_line":"        if \u0027project\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":240,"context_line":"            project_ref \u003d self._lookup_project(self.auth[\u0027scope\u0027][\u0027project\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_f598b86a","line":237,"updated":"2015-01-16 12:47:35.000000000","message":"nit: single quotes everywhere","commit_id":"d486f98cbbb00380998b3d9e4123ce73c5680e07"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"78334e625bbfaea2930371c8eea8b7759fd267bc","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                \u0027unscoped\u0027 in self.auth[\u0027scope\u0027],"},{"line_number":231,"context_line":"                \u0027OS-TRUST:trust\u0027 in self.auth[\u0027scope\u0027]]) !\u003d 1:"},{"line_number":232,"context_line":"            raise exception.ValidationError("},{"line_number":233,"context_line":"                attribute\u003d\u0027project, domain, or OS-TRUST:trust\u0027,"},{"line_number":234,"context_line":"                target\u003d\u0027scope\u0027)"},{"line_number":235,"context_line":"        if \u0027unscoped\u0027 in self.auth[\u0027scope\u0027]:"},{"line_number":236,"context_line":"            self._scope_data \u003d (None, None, None, \u0027unscoped\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_f775eb32","line":233,"updated":"2015-01-21 02:27:58.000000000","message":"Need to add \u0027unscope\u0027 here as well, in order to keep the ValidationError message consistent.","commit_id":"d835a2e7ff1d744d237466ea23bb8d7285f1b49c"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"b5019806d11014e5b0b9b9ab23811bd57d1a01a5","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                   If scoped to a trust, (None, project_id, trust_ref),"},{"line_number":324,"context_line":"                   Will be returned, where the project_id comes from the"},{"line_number":325,"context_line":"                   trust definition."},{"line_number":326,"context_line":"                   If unscoped, (None, None, None) will be returned."},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        \"\"\""},{"line_number":329,"context_line":"        return self._scope_data"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_2d74849b","line":326,"updated":"2015-01-21 04:05:57.000000000","message":"Should change this comment too.","commit_id":"d835a2e7ff1d744d237466ea23bb8d7285f1b49c"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"78334e625bbfaea2930371c8eea8b7759fd267bc","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        # Skip scoping when unscoped federated token is being issued"},{"line_number":417,"context_line":"        if federation.IDENTITY_PROVIDER in auth_context:"},{"line_number":418,"context_line":"            return"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        if unscoped is not None:"},{"line_number":421,"context_line":"            return"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a930d6b_377933fd","line":419,"updated":"2015-01-21 02:27:58.000000000","message":"(nit)\n\nCould be useful to add a comment here, as in the above case:\n\n    # Skip scoping when explicit unscoped token is being issued","commit_id":"d835a2e7ff1d744d237466ea23bb8d7285f1b49c"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"6bd6758a301bf37281520f511e8acb15692f8cb9","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                   If scoped to a domain, (domain_id, None, None, None)"},{"line_number":322,"context_line":"                   will be returned."},{"line_number":323,"context_line":"                   If scoped to a trust, (None, project_id, trust_ref, None),"},{"line_number":324,"context_line":"                   Will be returned, where the project_id comes from the"},{"line_number":325,"context_line":"                   trust definition."},{"line_number":326,"context_line":"                   If unscoped, (None, None, None, \u0027unscoped\u0027) will be"},{"line_number":327,"context_line":"                   returned."}],"source_content_type":"text/x-python","patch_set":10,"id":"1a930d6b_ad7f0faa","line":324,"updated":"2015-01-24 16:08:34.000000000","message":"nit: s/Will/will","commit_id":"e8ac71f0360b88772044ac2638d161aa00ec5b55"}]}