)]}'
{"keystone/common/sql/migrate_repo/versions/044_service_enabled.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"90fa8eea3e6fa3133e51d318d67afa33bf9b724d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        sql.Column(\u0027id\u0027, sql.String(64), primary_key\u003dTrue),"},{"line_number":118,"context_line":"        sql.Column(\u0027type\u0027, sql.String(255)),"},{"line_number":119,"context_line":"        sql.Column(\u0027extra\u0027, sql.Text()))"},{"line_number":120,"context_line":"    service_table.create(migrate_engine, checkfirst\u003dTrue)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    with session.transaction:"},{"line_number":123,"context_line":"        for service in session.query(orig_service_table):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_7f10b0ab","line":120,"updated":"2015-01-13 09:11:04.000000000","message":"what\u0027s the thinking on when to use checkfirst? I noticed that in the next patch you remove this from the equivalent call.","commit_id":"fe297b578a9a0cf1daeb4ea7c9ada4a193f7e0c3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5d988d1c939fe0640da03f457813ae31064aa12b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        sql.Column(\u0027id\u0027, sql.String(64), primary_key\u003dTrue),"},{"line_number":118,"context_line":"        sql.Column(\u0027type\u0027, sql.String(255)),"},{"line_number":119,"context_line":"        sql.Column(\u0027extra\u0027, sql.Text()))"},{"line_number":120,"context_line":"    service_table.create(migrate_engine, checkfirst\u003dTrue)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    with session.transaction:"},{"line_number":123,"context_line":"        for service in session.query(orig_service_table):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_b5423766","line":120,"in_reply_to":"3a961159_551913d0","updated":"2015-01-13 10:13:14.000000000","message":"OK, great, thanks.","commit_id":"fe297b578a9a0cf1daeb4ea7c9ada4a193f7e0c3"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"6044d8a76fd7f5a95442a70c5e617fdfeb501469","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        sql.Column(\u0027id\u0027, sql.String(64), primary_key\u003dTrue),"},{"line_number":118,"context_line":"        sql.Column(\u0027type\u0027, sql.String(255)),"},{"line_number":119,"context_line":"        sql.Column(\u0027extra\u0027, sql.Text()))"},{"line_number":120,"context_line":"    service_table.create(migrate_engine, checkfirst\u003dTrue)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    with session.transaction:"},{"line_number":123,"context_line":"        for service in session.query(orig_service_table):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_551913d0","line":120,"in_reply_to":"3a961159_55bd93b0","updated":"2015-01-13 10:03:15.000000000","message":"Done","commit_id":"fe297b578a9a0cf1daeb4ea7c9ada4a193f7e0c3"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a899ab96cc8aae9ed9bc0e43c65d1acc2b236296","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        sql.Column(\u0027id\u0027, sql.String(64), primary_key\u003dTrue),"},{"line_number":118,"context_line":"        sql.Column(\u0027type\u0027, sql.String(255)),"},{"line_number":119,"context_line":"        sql.Column(\u0027extra\u0027, sql.Text()))"},{"line_number":120,"context_line":"    service_table.create(migrate_engine, checkfirst\u003dTrue)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    with session.transaction:"},{"line_number":123,"context_line":"        for service in session.query(orig_service_table):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_55bd93b0","line":120,"in_reply_to":"3a961159_7f10b0ab","updated":"2015-01-13 09:57:47.000000000","message":"The issue in the next patch was tricky. The migration didn\u0027t fail by itself, it silently dropped a table and next migrations failed because of it. Removal of checkfirst was part of debugging there.\n\nIMO, there should not be checkfirst in both of these patches, but we should not mix multiple functional changes in the same commit, so I\u0027ll bring it back in that patch.","commit_id":"fe297b578a9a0cf1daeb4ea7c9ada4a193f7e0c3"}]}