)]}'
{"keystone/common/sql/migrate_repo/versions/042_endpoint_enabled.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7f5966c8e6b63230d28f744dbb090c2c4e5e6942","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    orig_endpoint_table \u003d sql.Table("},{"line_number":108,"context_line":"        \u0027endpoint\u0027, meta, autoload\u003dTrue)"},{"line_number":109,"context_line":"    orig_endpoint_table.deregister()"},{"line_number":110,"context_line":"    orig_endpoint_table.rename(\u0027orig_endpoint\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    session \u003d Session(bind\u003dmigrate_engine)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_3fc2a834","line":109,"updated":"2015-01-13 08:58:15.000000000","message":"...that\u0027s a new one on me...didn\u0027t know that call existed!","commit_id":"296c08806c7593d9dbe6356a3bf8e37dff25ce91"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"eb295a7e5bb9304241a9eacf38c384f68eeafdd4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                            \u0027values ( :id, :legacy_endpoint_id, :interface, \u0027"},{"line_number":151,"context_line":"                            \u0027:region, :service_id, :url, :extra);\u0027,"},{"line_number":152,"context_line":"                            new_values)"},{"line_number":153,"context_line":"    orig_endpoint_table.drop()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_5add4d6f","line":153,"updated":"2015-01-15 22:31:38.000000000","message":"in https://review.openstack.org/#/c/144321/5/keystone/common/sql/migrate_repo/versions/044_service_enabled.py there\u0027s a session.close() before the drop -- why doesn\u0027t that need to be done here?","commit_id":"ea0e55c7c78b9f10c61d6def7b42340dc8ec8ecd"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"581c38edffb8282d384803f3e58e9d081241ce6c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                            \u0027values ( :id, :legacy_endpoint_id, :interface, \u0027"},{"line_number":151,"context_line":"                            \u0027:region, :service_id, :url, :extra);\u0027,"},{"line_number":152,"context_line":"                            new_values)"},{"line_number":153,"context_line":"    orig_endpoint_table.drop()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_5a262d17","line":153,"in_reply_to":"3a961159_5add4d6f","updated":"2015-01-15 22:46:05.000000000","message":"session.close() was removed here in commit 90fd2ee0. It could have been removed in the patch you mentioned, but, frankly, I see it only now and I think it would not have any difference, because we use session only for a single transaction.","commit_id":"ea0e55c7c78b9f10c61d6def7b42340dc8ec8ecd"}]}