)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d3ab4b955205900a85fef95d3441d50e91b4b96","unresolved":false,"context_lines":[{"line_number":1685,"context_line":"        :returns query: LDAP query, updated with any filters satisfied"},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"        \"\"\""},{"line_number":1688,"context_line":"        def build_filter(filter_, hints):"},{"line_number":1689,"context_line":"            \"\"\"Build a filter for the query."},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"            :param filter_: the dict that describes this filter"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_284ac083","line":1688,"updated":"2015-02-20 05:55:42.000000000","message":"nit: the underscore at the end of filter is strange, and not really a convention that we use.","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d3ab4b955205900a85fef95d3441d50e91b4b96","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"            return query"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        filter_list \u003d []"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"        for filter_ in hints.filters:"},{"line_number":1751,"context_line":"            if filter_[\u0027name\u0027] not in self.attribute_mapping:"},{"line_number":1752,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_c85a0450","line":1749,"updated":"2015-02-20 05:55:42.000000000","message":"i think adding a few debug statements about the filtering that were seen, used, and ignored would go a long way for some deployers","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a9af154f56d3145d55ee7d3b99ff88e5f9a4e2ab","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"            return query"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        filter_list \u003d []"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"        for filter_ in hints.filters:"},{"line_number":1751,"context_line":"            if filter_[\u0027name\u0027] not in self.attribute_mapping:"},{"line_number":1752,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_29f8b848","line":1749,"in_reply_to":"ba7be1f8_2374a1fc","updated":"2015-02-23 15:46:34.000000000","message":"Happy to consider some additional logging in a follow on patch","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"d0e342c3b4e7e88d7a5080a2e879278e73caa539","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"            return query"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        filter_list \u003d []"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"        for filter_ in hints.filters:"},{"line_number":1751,"context_line":"            if filter_[\u0027name\u0027] not in self.attribute_mapping:"},{"line_number":1752,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_2374a1fc","line":1749,"in_reply_to":"ba7be1f8_83262d67","updated":"2015-02-20 06:26:46.000000000","message":"I see. Good idea. I am fine with adding the logs in this patch or the next.","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"843067ee69900619d4a0a070e4946b99e86a3589","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"            return query"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        filter_list \u003d []"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"        for filter_ in hints.filters:"},{"line_number":1751,"context_line":"            if filter_[\u0027name\u0027] not in self.attribute_mapping:"},{"line_number":1752,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_83262d67","line":1749,"in_reply_to":"ba7be1f8_c3dca577","updated":"2015-02-20 06:15:35.000000000","message":"yes, i meant more in terms of lines 1701 and 1710, if I knowingly supplies name \u003d\u003d enabled or case_sensitive as filters and they were ignored, i\u0027d have no idea why","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"1c0fad29dd22ffd3d4e59986615abcbbff30ce31","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"            return query"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        filter_list \u003d []"},{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"        for filter_ in hints.filters:"},{"line_number":1751,"context_line":"            if filter_[\u0027name\u0027] not in self.attribute_mapping:"},{"line_number":1752,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_c3dca577","line":1749,"in_reply_to":"ba7be1f8_c85a0450","updated":"2015-02-20 06:11:17.000000000","message":"It will eventually get logged. See search_s() in line 929.","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"}],"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"204b38883c83449bb992bd8f1ebd541cf6d2758c","unresolved":false,"context_lines":[{"line_number":5458,"context_line":"        - Create 10 groups, some with names we can filter on"},{"line_number":5459,"context_line":"        - Create 2 users"},{"line_number":5460,"context_line":"        - Assign 1 of those users to most of the groups, including some of the"},{"line_number":5461,"context_line":"          well know named ones"},{"line_number":5462,"context_line":"        - Assign the other user to other groups as spoilers"},{"line_number":5463,"context_line":"        - Ensure that when we list groups for users with a filter on the group"},{"line_number":5464,"context_line":"          name, both restrctions have been enforced on what is returned."}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_76e85ee2","line":5461,"updated":"2015-02-19 05:38:57.000000000","message":"(nit) s/know/known/","commit_id":"13ff2e7a01790029686143ff5c2a479a3bb6aa4f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1058c9d901d59f64274c538e6806f4d122b8367b","unresolved":false,"context_lines":[{"line_number":5458,"context_line":"        - Create 10 groups, some with names we can filter on"},{"line_number":5459,"context_line":"        - Create 2 users"},{"line_number":5460,"context_line":"        - Assign 1 of those users to most of the groups, including some of the"},{"line_number":5461,"context_line":"          well know named ones"},{"line_number":5462,"context_line":"        - Assign the other user to other groups as spoilers"},{"line_number":5463,"context_line":"        - Ensure that when we list groups for users with a filter on the group"},{"line_number":5464,"context_line":"          name, both restrctions have been enforced on what is returned."}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_14eb9513","line":5461,"in_reply_to":"da86d52c_76e85ee2","updated":"2015-02-19 10:05:57.000000000","message":"Done","commit_id":"13ff2e7a01790029686143ff5c2a479a3bb6aa4f"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"204b38883c83449bb992bd8f1ebd541cf6d2758c","unresolved":false,"context_lines":[{"line_number":5461,"context_line":"          well know named ones"},{"line_number":5462,"context_line":"        - Assign the other user to other groups as spoilers"},{"line_number":5463,"context_line":"        - Ensure that when we list groups for users with a filter on the group"},{"line_number":5464,"context_line":"          name, both restrctions have been enforced on what is returned."},{"line_number":5465,"context_line":""},{"line_number":5466,"context_line":"        \"\"\""},{"line_number":5467,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_16bf22d1","line":5464,"updated":"2015-02-19 05:38:57.000000000","message":"(nit) s/restrctions/restrictions/","commit_id":"13ff2e7a01790029686143ff5c2a479a3bb6aa4f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1058c9d901d59f64274c538e6806f4d122b8367b","unresolved":false,"context_lines":[{"line_number":5461,"context_line":"          well know named ones"},{"line_number":5462,"context_line":"        - Assign the other user to other groups as spoilers"},{"line_number":5463,"context_line":"        - Ensure that when we list groups for users with a filter on the group"},{"line_number":5464,"context_line":"          name, both restrctions have been enforced on what is returned."},{"line_number":5465,"context_line":""},{"line_number":5466,"context_line":"        \"\"\""},{"line_number":5467,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da86d52c_54f18dff","line":5464,"in_reply_to":"da86d52c_16bf22d1","updated":"2015-02-19 10:05:57.000000000","message":"Done","commit_id":"13ff2e7a01790029686143ff5c2a479a3bb6aa4f"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d3ab4b955205900a85fef95d3441d50e91b4b96","unresolved":false,"context_lines":[{"line_number":3015,"context_line":"        self.load_backends()"},{"line_number":3016,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":3017,"context_line":""},{"line_number":3018,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":3019,"context_line":"        self.addCleanup(sql.cleanup)"},{"line_number":3020,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"},{"line_number":3021,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_68d118cd","line":3018,"updated":"2015-02-20 05:55:42.000000000","message":"are the sql bits needed? nothing here seems to indicate the need for a mixed backend of sql and ldap","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"de8bb9a70cbc7e1c6d65a3d9e9cda06be47a5e01","unresolved":false,"context_lines":[{"line_number":3015,"context_line":"        self.load_backends()"},{"line_number":3016,"context_line":"        self.load_fixtures(default_fixtures)"},{"line_number":3017,"context_line":""},{"line_number":3018,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":3019,"context_line":"        self.addCleanup(sql.cleanup)"},{"line_number":3020,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"},{"line_number":3021,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba7be1f8_89e9a482","line":3018,"in_reply_to":"ba7be1f8_68d118cd","updated":"2015-02-23 15:46:01.000000000","message":"happy to review that and remove in a follow on patch if necessary","commit_id":"e12cabba868abd5ffa24c0d71c65c42030190c1b"}]}