)]}'
{"keystone/contrib/endpoint_filter/schema.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4801897bfc051e5629626d48ba11cd207e129c9b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"endpoint_group_create \u003d {"},{"line_number":25,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":26,"context_line":"    \u0027properties\u0027: _endpoint_group_properties,"},{"line_number":27,"context_line":"    \u0027required\u0027: [\u0027name\u0027],"},{"line_number":28,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_0a7ed0ae","line":27,"updated":"2015-01-27 23:36:46.000000000","message":"\u0027filters\u0027 are required too","commit_id":"c2ffbb4ca7d981ee1cd9476a9036a43c4675f080"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ebe2efb020350546be6bd9723f2b4b9acdcd0774","unresolved":false,"context_lines":[{"line_number":24,"context_line":"endpoint_group_create \u003d {"},{"line_number":25,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":26,"context_line":"    \u0027properties\u0027: _endpoint_group_properties,"},{"line_number":27,"context_line":"    \u0027required\u0027: [\u0027name\u0027],"},{"line_number":28,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_e5644de7","line":27,"in_reply_to":"fa81d914_0a7ed0ae","updated":"2015-01-27 23:43:10.000000000","message":"Done","commit_id":"c2ffbb4ca7d981ee1cd9476a9036a43c4675f080"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"1b95092c536e714479a952c674b1ffe5d011b2ac","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":27,"context_line":"    \u0027properties\u0027: _endpoint_group_properties,"},{"line_number":28,"context_line":"    \u0027required\u0027: [\u0027name\u0027, \u0027filters\u0027],"},{"line_number":29,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"endpoint_group_update \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_fe265e15","line":29,"updated":"2015-01-29 02:33:29.000000000","message":"EndpointGroup table doesn\u0027t have extra attribute, I think additionalProperties should be False.","commit_id":"35876896b8c48cf93d1fc1e568e1118aa72d8db5"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"156ef0723a684c12f3659910a2000c2974ed82dc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":27,"context_line":"    \u0027properties\u0027: _endpoint_group_properties,"},{"line_number":28,"context_line":"    \u0027required\u0027: [\u0027name\u0027, \u0027filters\u0027],"},{"line_number":29,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"endpoint_group_update \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_099bf772","line":29,"in_reply_to":"fa81d914_fe265e15","updated":"2015-01-29 05:02:21.000000000","message":"Done","commit_id":"35876896b8c48cf93d1fc1e568e1118aa72d8db5"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"1b95092c536e714479a952c674b1ffe5d011b2ac","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":34,"context_line":"    \u0027properties\u0027: _endpoint_group_properties,"},{"line_number":35,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":36,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_7e7a6ef2","line":36,"updated":"2015-01-29 02:33:29.000000000","message":"This too.","commit_id":"35876896b8c48cf93d1fc1e568e1118aa72d8db5"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"156ef0723a684c12f3659910a2000c2974ed82dc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":34,"context_line":"    \u0027properties\u0027: _endpoint_group_properties,"},{"line_number":35,"context_line":"    \u0027minProperties\u0027: 1,"},{"line_number":36,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa81d914_498c0f36","line":36,"in_reply_to":"fa81d914_7e7a6ef2","updated":"2015-01-29 05:02:21.000000000","message":"Done","commit_id":"35876896b8c48cf93d1fc1e568e1118aa72d8db5"}],"keystone/tests/test_validation.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"02355fe18b507681ed3f17ff3521b6c84312b042","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        self.create_endpoint_grp_validator.validate(request_to_validate)"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"    def test_validate_endpoint_group_create_succeeds_with_req_parameters(self):"},{"line_number":1183,"context_line":"        \"\"\"Validate an endpoint group request with only the required"},{"line_number":1184,"context_line":"        parameters."},{"line_number":1185,"context_line":"        \"\"\""},{"line_number":1186,"context_line":"        request_to_validate \u003d {\u0027filters\u0027: {\u0027interface\u0027: \u0027admin\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_5952f3de","line":1183,"updated":"2015-02-10 20:13:48.000000000","message":"This doc string will have to be split up, something like the following: \n\n\n    \"\"\"Validate required endpoint group parameters.\n \n        This test ensure that we can validate the required parameters needed\n        for creating an endpoint group.\n\n    \"\"\"","commit_id":"314fceaaa101e967f9ca54538b63727c1aec1cb7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a467a122ed4be78c6f85bfcdfd53326ed880987b","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"        self.create_endpoint_grp_validator.validate(request_to_validate)"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"    def test_validate_endpoint_group_create_succeeds_with_req_parameters(self):"},{"line_number":1183,"context_line":"        \"\"\"Validate an endpoint group request with only the required"},{"line_number":1184,"context_line":"        parameters."},{"line_number":1185,"context_line":"        \"\"\""},{"line_number":1186,"context_line":"        request_to_validate \u003d {\u0027filters\u0027: {\u0027interface\u0027: \u0027admin\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_420af826","line":1183,"in_reply_to":"da86d52c_5952f3de","updated":"2015-02-10 21:52:28.000000000","message":"Done","commit_id":"314fceaaa101e967f9ca54538b63727c1aec1cb7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"02355fe18b507681ed3f17ff3521b6c84312b042","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"            request_to_validate[\u0027filters\u0027] \u003d valid_filters"},{"line_number":1197,"context_line":"            self.create_endpoint_grp_validator.validate(request_to_validate)"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"    def test_validate_create_endpoint_group_fails_with_invalid_filters(self):"},{"line_number":1200,"context_line":"        \"\"\"Exception raised when non-dict values used as `filters` in"},{"line_number":1201,"context_line":"        endpoint group create request."},{"line_number":1202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_995f0be5","line":1199,"updated":"2015-02-10 20:13:48.000000000","message":"same comment here","commit_id":"314fceaaa101e967f9ca54538b63727c1aec1cb7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a467a122ed4be78c6f85bfcdfd53326ed880987b","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"            request_to_validate[\u0027filters\u0027] \u003d valid_filters"},{"line_number":1197,"context_line":"            self.create_endpoint_grp_validator.validate(request_to_validate)"},{"line_number":1198,"context_line":""},{"line_number":1199,"context_line":"    def test_validate_create_endpoint_group_fails_with_invalid_filters(self):"},{"line_number":1200,"context_line":"        \"\"\"Exception raised when non-dict values used as `filters` in"},{"line_number":1201,"context_line":"        endpoint group create request."},{"line_number":1202,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_62037c10","line":1199,"in_reply_to":"da86d52c_995f0be5","updated":"2015-02-10 21:52:28.000000000","message":"Done","commit_id":"314fceaaa101e967f9ca54538b63727c1aec1cb7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"02355fe18b507681ed3f17ff3521b6c84312b042","unresolved":false,"context_lines":[{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    def test_validate_endpoint_group_update_succeeds_with_name(self):"},{"line_number":1242,"context_line":"        \"\"\"Test passing only a `name` pass validation on update endpoint"},{"line_number":1243,"context_line":"        group request."},{"line_number":1244,"context_line":"        \"\"\""},{"line_number":1245,"context_line":"        request_to_validate \u003d {\u0027name\u0027: \u0027endpoint_group_name\u0027}"},{"line_number":1246,"context_line":"        self.update_endpoint_grp_validator.validate(request_to_validate)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_b90befd4","line":1243,"updated":"2015-02-10 20:13:48.000000000","message":"same comment here.","commit_id":"314fceaaa101e967f9ca54538b63727c1aec1cb7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a467a122ed4be78c6f85bfcdfd53326ed880987b","unresolved":false,"context_lines":[{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    def test_validate_endpoint_group_update_succeeds_with_name(self):"},{"line_number":1242,"context_line":"        \"\"\"Test passing only a `name` pass validation on update endpoint"},{"line_number":1243,"context_line":"        group request."},{"line_number":1244,"context_line":"        \"\"\""},{"line_number":1245,"context_line":"        request_to_validate \u003d {\u0027name\u0027: \u0027endpoint_group_name\u0027}"},{"line_number":1246,"context_line":"        self.update_endpoint_grp_validator.validate(request_to_validate)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da86d52c_ad000502","line":1243,"in_reply_to":"da86d52c_b90befd4","updated":"2015-02-10 21:52:28.000000000","message":"Done","commit_id":"314fceaaa101e967f9ca54538b63727c1aec1cb7"}]}