)]}'
{"dsvm/federation/devstack/extras.d/20-keystone-federation.sh":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"7d205570c2ddf42f3fd7b51fb6c1757e4c0e1fa0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if [[ \"$1\" \u003d\u003d \"clean\" ]]; then"},{"line_number":38,"context_line":"        # Remove state and transient data"},{"line_number":39,"context_line":"        # Remember clean.sh first calls unstack.sh"},{"line_number":40,"context_line":"        # no-op"},{"line_number":41,"context_line":"        :"},{"line_number":42,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da86d52c_16567dce","line":39,"updated":"2015-02-11 03:19:26.000000000","message":"So why isn\u0027t this needed? Is it because its only run for tests and the whole thing is blown away anyway when its done?  If so a comment stating that would be helpful.","commit_id":"10ebf206e02c0b049ee426c4cfe5869a1d36d8d8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f819ea878f07a7912bd6996baa25b9385f380f0b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if [[ \"$1\" \u003d\u003d \"clean\" ]]; then"},{"line_number":38,"context_line":"        # Remove state and transient data"},{"line_number":39,"context_line":"        # Remember clean.sh first calls unstack.sh"},{"line_number":40,"context_line":"        # no-op"},{"line_number":41,"context_line":"        :"},{"line_number":42,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da86d52c_ff079e1a","line":39,"in_reply_to":"da86d52c_16567dce","updated":"2015-02-19 21:57:17.000000000","message":"I\u0027m not sure what I would need to clean up here, but I can add a \"Nothing to cleanup\" comment","commit_id":"10ebf206e02c0b049ee426c4cfe5869a1d36d8d8"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a67351fb6d76d2c934b18b5787f37a96ac9146b3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"pre-install\" ]]; then"},{"line_number":10,"context_line":"        # Keystone may not have been installed or setup yet!  no-op"},{"line_number":11,"context_line":"        :"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":14,"context_line":"        # Called after Keystone is installed"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a80dd14_6957ee26","line":11,"updated":"2015-03-18 18:55:16.000000000","message":"Do we want to log anything here?","commit_id":"0e192b1679efc874a2dbb631cefd85e2a8a986f0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"78ef4694e1f4d03c36f7d2e8636adae30cf271a9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"pre-install\" ]]; then"},{"line_number":10,"context_line":"        # Keystone may not have been installed or setup yet!  no-op"},{"line_number":11,"context_line":"        :"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":14,"context_line":"        # Called after Keystone is installed"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a41bdd9_175e9a76","line":11,"in_reply_to":"9a80dd14_6957ee26","updated":"2015-07-16 19:58:04.000000000","message":"No, I\u0027ll change the comment to make it clearer that it\u0027s not an issue. I\u0027ll just say it\u0027s a no-op.","commit_id":"0e192b1679efc874a2dbb631cefd85e2a8a986f0"}],"dsvm/federation/devstack/lib/keystone-federation":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a67351fb6d76d2c934b18b5787f37a96ac9146b3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    python $FILES/key-federation-setup.py"},{"line_number":84,"context_line":"    #local domain_id\u003d$(get_or_create_domain \"domainX\" \"Domain for federated users\")"},{"line_number":85,"context_line":"    #get_or_create_project \"projectX\" $domain_id"},{"line_number":86,"context_line":"    #get_or_create_role \"memberX\""},{"line_number":87,"context_line":"    :"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9a80dd14_bc284286","line":86,"updated":"2015-03-18 18:55:16.000000000","message":"should these be commented out or removed?","commit_id":"0e192b1679efc874a2dbb631cefd85e2a8a986f0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"78ef4694e1f4d03c36f7d2e8636adae30cf271a9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    python $FILES/key-federation-setup.py"},{"line_number":84,"context_line":"    #local domain_id\u003d$(get_or_create_domain \"domainX\" \"Domain for federated users\")"},{"line_number":85,"context_line":"    #get_or_create_project \"projectX\" $domain_id"},{"line_number":86,"context_line":"    #get_or_create_role \"memberX\""},{"line_number":87,"context_line":"    :"},{"line_number":88,"context_line":"}"},{"line_number":89,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9a41bdd9_97e14a9d","line":86,"in_reply_to":"9a80dd14_bc284286","updated":"2015-07-16 19:58:04.000000000","message":"Done","commit_id":"0e192b1679efc874a2dbb631cefd85e2a8a986f0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3f3f030f168747d8744737f054153e71f1e6d02b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"function configure_keystone_federation {"},{"line_number":54,"context_line":"    local here\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"},{"line_number":55,"context_line":"    local keystone_apache_conf\u003d$(apache_site_config_for keystone)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # insert our Apache federation snippet into the Apache config"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3a50d1a3_0ce671b4","line":54,"updated":"2015-07-20 18:22:32.000000000","message":"this piece fails for me when I run it locally: \n\n    dirname: invalid option -- \u0027b\u0027","commit_id":"eb99bb80edecb88d0bc134a1eead23ffeac74a6b"}]}