)]}'
{"keystone/contrib/ec2/controllers.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c5c76b09651478e90db843dd850d3f18db537c6","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    @controller.protected()"},{"line_number":392,"context_line":"    def ec2_list_credentials(self, context, user_id):"},{"line_number":393,"context_line":"        ref_list \u003d super(Ec2ControllerV3, self).get_credentials(user_id)"},{"line_number":394,"context_line":"        return Ec2ControllerV3.wrap_collection(context,"},{"line_number":395,"context_line":"                                               ref_list[\u0027credentials\u0027])"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c958d2fc","line":393,"updated":"2015-02-10 19:52:11.000000000","message":"nit: s/ref_list/refs/  just to keep consistency:\n\nhttps://github.com/openstack/keystone/blob/15fb5d68cd871a9d05f3bc332139e808d47af2a8/keystone/catalog/controllers.py#L308","commit_id":"5c341ebd09992ed701607dbd9192e200bb88155d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e3195686099e1b46321be4e0c9ba9a117d844e3f","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    @classmethod"},{"line_number":409,"context_line":"    def base_url(cls, context, path\u003dNone):"},{"line_number":410,"context_line":"        if not path:"},{"line_number":411,"context_line":"            path \u003d \u0027/users/%(user_id)s/credentials/OS-EC2/%(credential_id)s\u0027"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        return super(Ec2ControllerV3, cls).base_url(context, path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_8a50475f","line":410,"updated":"2015-02-19 02:33:10.000000000","message":"will there be  a case that path will not be empty?\n\nLooking at all other implementation of base_url, we just always override path. Should we just do that for consistency:\n\n* https://github.com/openstack/keystone/blob/master/keystone/contrib/oauth1/controllers.py#L56\n* https://github.com/openstack/keystone/blob/master/keystone/trust/controllers.py#L60","commit_id":"e431c8ed81d65bbf8308bb51acdf76a326d695b6"}],"keystone/tests/unit/test_v3_credential.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"3293b1270f3002d9ebc2e8567bc228ad57492ace","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_1d18fa1c","line":11,"updated":"2015-03-16 10:35:23.000000000","message":"could implement something like assertValidEc2Response()","commit_id":"e6c67148feb87e5fe755d8203b62ebd41b6fa3d5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cd718a59e6d10ee759fe631603bccae2da6c3db7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_49d2c600","line":11,"in_reply_to":"9a80dd14_1d18fa1c","updated":"2015-03-20 15:47:28.000000000","message":"++","commit_id":"e6c67148feb87e5fe755d8203b62ebd41b6fa3d5"}]}