)]}'
{"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"2bf6bdc32f7b1ca63597b6afce5acf68b2af8043","unresolved":false,"context_lines":[{"line_number":97,"context_line":"             \u0027results\u0027: [{\u0027group\u0027: 0, \u0027role\u0027: 2, \u0027domain\u0027: 0},"},{"line_number":98,"context_line":"                         {\u0027user\u0027: 0, \u0027role\u0027: 2, \u0027project\u0027: 0}]}]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # The \u0027params\u0027 key also supports the \u0027effective\u0027 and \u0027inherited\u0027"},{"line_number":101,"context_line":"        # options to list_role_assignments.}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_a1859bd0","line":100,"updated":"2015-02-17 01:39:51.000000000","message":"(nit) Looking at line 211, the parameter name is \u0027inherited_to_projects\u0027, instead of just \u0027inherited\u0027. Please fix the \u0027inherited\u0027 occurrence in this line.","commit_id":"dfd3c9175a045c6cc582f246819af0df4044c6b4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a1c8af6ff8ee3030a58107bf8ccab4f7716661bb","unresolved":false,"context_lines":[{"line_number":97,"context_line":"             \u0027results\u0027: [{\u0027group\u0027: 0, \u0027role\u0027: 2, \u0027domain\u0027: 0},"},{"line_number":98,"context_line":"                         {\u0027user\u0027: 0, \u0027role\u0027: 2, \u0027project\u0027: 0}]}]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # The \u0027params\u0027 key also supports the \u0027effective\u0027 and \u0027inherited\u0027"},{"line_number":101,"context_line":"        # options to list_role_assignments.}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_7e9ecb64","line":100,"in_reply_to":"da86d52c_a1859bd0","updated":"2015-02-17 21:18:40.000000000","message":"Done","commit_id":"dfd3c9175a045c6cc582f246819af0df4044c6b4"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"2bf6bdc32f7b1ca63597b6afce5acf68b2af8043","unresolved":false,"context_lines":[{"line_number":5341,"context_line":"                              \u0027indirect\u0027: {\u0027domain\u0027: 0}}]}"},{"line_number":5342,"context_line":"            ]"},{"line_number":5343,"context_line":"        }"},{"line_number":5344,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dTrue)"},{"line_number":5345,"context_line":"        self.execute_assignment_test_plan(test_plan)"},{"line_number":5346,"context_line":""},{"line_number":5347,"context_line":"    def test_inherited_role_assignments_excluded_if_os_inherit_false(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_f28e8378","line":5344,"updated":"2015-02-17 01:39:51.000000000","message":"As the test class is called InheritanceTests, I suggest you to enable this config at class level; i.e for all methods.\n\nThis should be the default here in, and any specific method that needs it disabled, do it by itself :)\n(Like the one just below)","commit_id":"dfd3c9175a045c6cc582f246819af0df4044c6b4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a1c8af6ff8ee3030a58107bf8ccab4f7716661bb","unresolved":false,"context_lines":[{"line_number":5341,"context_line":"                              \u0027indirect\u0027: {\u0027domain\u0027: 0}}]}"},{"line_number":5342,"context_line":"            ]"},{"line_number":5343,"context_line":"        }"},{"line_number":5344,"context_line":"        self.config_fixture.config(group\u003d\u0027os_inherit\u0027, enabled\u003dTrue)"},{"line_number":5345,"context_line":"        self.execute_assignment_test_plan(test_plan)"},{"line_number":5346,"context_line":""},{"line_number":5347,"context_line":"    def test_inherited_role_assignments_excluded_if_os_inherit_false(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_b304e87e","line":5344,"in_reply_to":"da86d52c_f28e8378","updated":"2015-02-17 21:18:40.000000000","message":"I think that might be good as a follow on patch...didn\u0027t want to change anything about the current tests...","commit_id":"dfd3c9175a045c6cc582f246819af0df4044c6b4"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"2bf6bdc32f7b1ca63597b6afce5acf68b2af8043","unresolved":false,"context_lines":[{"line_number":5472,"context_line":"                # inherited role on that domain"},{"line_number":5473,"context_line":"                {\u0027params\u0027: {\u0027user\u0027: 0, \u0027domain\u0027: 0, \u0027effective\u0027: True},"},{"line_number":5474,"context_line":"                 \u0027results\u0027: [{\u0027user\u0027: 0, \u0027role\u0027: 1, \u0027domain\u0027: 0}]},"},{"line_number":5475,"context_line":"                # Ensure non-inherted mode also only returns the non-inherited"},{"line_number":5476,"context_line":"                # role on the domain"},{"line_number":5477,"context_line":"                {\u0027params\u0027: {\u0027user\u0027: 0, \u0027domain\u0027: 0, \u0027inherited\u0027: False},"},{"line_number":5478,"context_line":"                 \u0027results\u0027: [{\u0027user\u0027: 0, \u0027role\u0027: 1, \u0027domain\u0027: 0}]},"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_507026dc","line":5475,"updated":"2015-02-17 01:39:51.000000000","message":"(nit) s/non-inherted/non-inherited","commit_id":"dfd3c9175a045c6cc582f246819af0df4044c6b4"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a1c8af6ff8ee3030a58107bf8ccab4f7716661bb","unresolved":false,"context_lines":[{"line_number":5472,"context_line":"                # inherited role on that domain"},{"line_number":5473,"context_line":"                {\u0027params\u0027: {\u0027user\u0027: 0, \u0027domain\u0027: 0, \u0027effective\u0027: True},"},{"line_number":5474,"context_line":"                 \u0027results\u0027: [{\u0027user\u0027: 0, \u0027role\u0027: 1, \u0027domain\u0027: 0}]},"},{"line_number":5475,"context_line":"                # Ensure non-inherted mode also only returns the non-inherited"},{"line_number":5476,"context_line":"                # role on the domain"},{"line_number":5477,"context_line":"                {\u0027params\u0027: {\u0027user\u0027: 0, \u0027domain\u0027: 0, \u0027inherited\u0027: False},"},{"line_number":5478,"context_line":"                 \u0027results\u0027: [{\u0027user\u0027: 0, \u0027role\u0027: 1, \u0027domain\u0027: 0}]},"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_13005465","line":5475,"in_reply_to":"da86d52c_507026dc","updated":"2015-02-17 21:18:40.000000000","message":"Done","commit_id":"dfd3c9175a045c6cc582f246819af0df4044c6b4"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7316d40037503a60d066081bdab2c10da0630682","unresolved":false,"context_lines":[{"line_number":5569,"context_line":""},{"line_number":5570,"context_line":"        - Enable OS-INHERIT extension"},{"line_number":5571,"context_line":"        - Create 3 roles"},{"line_number":5572,"context_line":"        - Create a domain, with a project and a user"},{"line_number":5573,"context_line":"        - Check no roles yet exit"},{"line_number":5574,"context_line":"        - Assign a direct user role to the project and a (non-inherited)"},{"line_number":5575,"context_line":"          user role to the domain"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a4dcd0f_d44c9eca","line":5572,"updated":"2015-08-14 10:39:15.000000000","message":"nits: s/exit/exist","commit_id":"09d91f0c3fefd38b21030dccbc633187785c7081"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6802fdf522046171f3c41d9d66b9198559d5e2a7","unresolved":false,"context_lines":[{"line_number":5569,"context_line":""},{"line_number":5570,"context_line":"        - Enable OS-INHERIT extension"},{"line_number":5571,"context_line":"        - Create 3 roles"},{"line_number":5572,"context_line":"        - Create a domain, with a project and a user"},{"line_number":5573,"context_line":"        - Check no roles yet exit"},{"line_number":5574,"context_line":"        - Assign a direct user role to the project and a (non-inherited)"},{"line_number":5575,"context_line":"          user role to the domain"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a4dcd0f_a8806df8","line":5572,"in_reply_to":"1a4dcd0f_d44c9eca","updated":"2015-08-15 11:29:10.000000000","message":"yes, I\u0027ll leave this for a follow on tidy up","commit_id":"09d91f0c3fefd38b21030dccbc633187785c7081"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7316d40037503a60d066081bdab2c10da0630682","unresolved":false,"context_lines":[{"line_number":5600,"context_line":"            user_id\u003duser1[\u0027id\u0027],"},{"line_number":5601,"context_line":"            project_id\u003dproject1[\u0027id\u0027])"},{"line_number":5602,"context_line":"        self.assertEqual(0, len(roles_ref))"},{"line_number":5603,"context_line":""},{"line_number":5604,"context_line":"        # Create the first two roles - the domain one is not inherited"},{"line_number":5605,"context_line":"        self.assignment_api.create_grant(user_id\u003duser1[\u0027id\u0027],"},{"line_number":5606,"context_line":"                                         project_id\u003dproject1[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a4dcd0f_f4f75a57","line":5603,"updated":"2015-08-14 10:39:15.000000000","message":"seems like it\u0027s creating two role assignments instead of creating roles.","commit_id":"09d91f0c3fefd38b21030dccbc633187785c7081"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6802fdf522046171f3c41d9d66b9198559d5e2a7","unresolved":false,"context_lines":[{"line_number":5600,"context_line":"            user_id\u003duser1[\u0027id\u0027],"},{"line_number":5601,"context_line":"            project_id\u003dproject1[\u0027id\u0027])"},{"line_number":5602,"context_line":"        self.assertEqual(0, len(roles_ref))"},{"line_number":5603,"context_line":""},{"line_number":5604,"context_line":"        # Create the first two roles - the domain one is not inherited"},{"line_number":5605,"context_line":"        self.assignment_api.create_grant(user_id\u003duser1[\u0027id\u0027],"},{"line_number":5606,"context_line":"                                         project_id\u003dproject1[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a4dcd0f_687b452a","line":5603,"in_reply_to":"1a4dcd0f_f4f75a57","updated":"2015-08-15 11:29:10.000000000","message":"true - I\u0027ll leave this for a follow on tidy up","commit_id":"09d91f0c3fefd38b21030dccbc633187785c7081"}]}