)]}'
{"keystone/contrib/endpoint_filter/migrate_repo/versions/002_add_endpoint_groups.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a50af0389cc7d6a49eddc7ce20138c2a3873bb88","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027project_endpoint_group\u0027,"},{"line_number":35,"context_line":"        meta,"},{"line_number":36,"context_line":"        sql.Column(\u0027endpoint_group_id\u0027, sql.String(64),"},{"line_number":37,"context_line":"                   sql.ForeignKey(\u0027endpoint_group.id\u0027), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sql.Column(\u0027project_id\u0027, sql.String(64), nullable\u003dFalse),"},{"line_number":39,"context_line":"        sql.PrimaryKeyConstraint(\u0027endpoint_group_id\u0027,"},{"line_number":40,"context_line":"                                 \u0027project_id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_2eaf0f2d","line":37,"updated":"2015-02-09 04:16:33.000000000","message":"actually, i think it should be:\n\n  sql.ForeignKey(\u0027endpoint_group.id\u0027, ondelete\u003d\u0027CASCADE\u0027)\n\nso any endpoint_groups that are deleted then they no longer exist in the project-endpoint-group table","commit_id":"a0003da744ad983ec63bdaa20b1eb53141c3e816"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"2bdeb6b91ee94cef1f1133f81549ac2efa9e9776","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027project_endpoint_group\u0027,"},{"line_number":35,"context_line":"        meta,"},{"line_number":36,"context_line":"        sql.Column(\u0027endpoint_group_id\u0027, sql.String(64),"},{"line_number":37,"context_line":"                   sql.ForeignKey(\u0027endpoint_group.id\u0027), nullable\u003dFalse),"},{"line_number":38,"context_line":"        sql.Column(\u0027project_id\u0027, sql.String(64), nullable\u003dFalse),"},{"line_number":39,"context_line":"        sql.PrimaryKeyConstraint(\u0027endpoint_group_id\u0027,"},{"line_number":40,"context_line":"                                 \u0027project_id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_9aed95f2","line":37,"in_reply_to":"da86d52c_2eaf0f2d","updated":"2015-02-09 07:49:37.000000000","message":"Done","commit_id":"a0003da744ad983ec63bdaa20b1eb53141c3e816"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"e1802b1e2f15689187f76892af8b2ea482d6d3c9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027project_endpoint_group\u0027,"},{"line_number":35,"context_line":"        meta,"},{"line_number":36,"context_line":"        sql.Column(\u0027endpoint_group_id\u0027, sql.String(64),"},{"line_number":37,"context_line":"                   sql.ForeignKey(\u0027endpoint_group.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":38,"context_line":"                   nullable\u003dFalse),"},{"line_number":39,"context_line":"        sql.Column(\u0027project_id\u0027, sql.String(64), nullable\u003dFalse),"},{"line_number":40,"context_line":"        sql.PrimaryKeyConstraint(\u0027endpoint_group_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_13126b58","line":37,"updated":"2015-02-09 11:18:12.000000000","message":"this ondelete is unrelated and should be in a separate patch imo","commit_id":"178ed91052fe292899e0363421c384f36e1e5be8"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d227aed21ac628df9f73a5b24e5cd1641ae97f7f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027project_endpoint_group\u0027,"},{"line_number":35,"context_line":"        meta,"},{"line_number":36,"context_line":"        sql.Column(\u0027endpoint_group_id\u0027, sql.String(64),"},{"line_number":37,"context_line":"                   sql.ForeignKey(\u0027endpoint_group.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":38,"context_line":"                   nullable\u003dFalse),"},{"line_number":39,"context_line":"        sql.Column(\u0027project_id\u0027, sql.String(64), nullable\u003dFalse),"},{"line_number":40,"context_line":"        sql.PrimaryKeyConstraint(\u0027endpoint_group_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_963d68be","line":37,"in_reply_to":"da86d52c_13126b58","updated":"2015-02-09 12:19:30.000000000","message":"Boris, this is somehow unrelated with bug but take into the consideration of the change here is make sense and also suggested to be added by other reviewer, so just let it be there unless you or someone else strongly object to this change, thanks.","commit_id":"178ed91052fe292899e0363421c384f36e1e5be8"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"4c05157476f275fc87c78d1435a697940d9cdc22","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027project_endpoint_group\u0027,"},{"line_number":35,"context_line":"        meta,"},{"line_number":36,"context_line":"        sql.Column(\u0027endpoint_group_id\u0027, sql.String(64),"},{"line_number":37,"context_line":"                   sql.ForeignKey(\u0027endpoint_group.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":38,"context_line":"                   nullable\u003dFalse),"},{"line_number":39,"context_line":"        sql.Column(\u0027project_id\u0027, sql.String(64), nullable\u003dFalse),"},{"line_number":40,"context_line":"        sql.PrimaryKeyConstraint(\u0027endpoint_group_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_e505e814","line":37,"in_reply_to":"da86d52c_3c7c9b72","updated":"2015-02-10 00:38:34.000000000","message":"I agree with Boris, this should be a separate review. Lets keep it focus.","commit_id":"178ed91052fe292899e0363421c384f36e1e5be8"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"bdb7a9aa8f023655a39b64911038215c2b636e7f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027project_endpoint_group\u0027,"},{"line_number":35,"context_line":"        meta,"},{"line_number":36,"context_line":"        sql.Column(\u0027endpoint_group_id\u0027, sql.String(64),"},{"line_number":37,"context_line":"                   sql.ForeignKey(\u0027endpoint_group.id\u0027, ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":38,"context_line":"                   nullable\u003dFalse),"},{"line_number":39,"context_line":"        sql.Column(\u0027project_id\u0027, sql.String(64), nullable\u003dFalse),"},{"line_number":40,"context_line":"        sql.PrimaryKeyConstraint(\u0027endpoint_group_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_3c7c9b72","line":37,"in_reply_to":"da86d52c_963d68be","updated":"2015-02-09 13:41:18.000000000","message":"I agree that this line might be required; but I have the following concerns about it:\n\n1. It is not related to the bug;\n2. We use CASCADE almost nowhere in Keystone;\n3. It is not tested.\n\nThe last concern is the biggest. But if we add tests for this new behaviour, it will bloat the patch.","commit_id":"178ed91052fe292899e0363421c384f36e1e5be8"}]}