)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"f42079f3b742885a9d1f785699407ab9914de14a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issue with table drops for endpoint filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were issues when dropping tables from 2 to 1, and from"},{"line_number":10,"context_line":"1 to 0."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1419546"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_ce0913df","line":9,"updated":"2015-02-09 03:46:17.000000000","message":"Would really be more helpful to provide more detail in the commit message. Something like the following: \n\nTables were being dropped in the incorrect order, the one with the foreign key should be dropped first. So \u0027project_endpoint_group\u0027 should be dropped before \u0027endpoint_group\u0027.\n\nAlso, when trying to downgrade from 1 to 0, the table \u0027project_endpoint\u0027 cannot be found when mysql is used.","commit_id":"0ab48666804cc13ffe1014e9c796c2b362f4ffe3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"085e9ca9814634072afcceaef136363669ae3652","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issue with table drops for endpoint filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There were issues when dropping tables from 2 to 1, and from"},{"line_number":10,"context_line":"1 to 0."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1419546"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_d908ff93","line":9,"in_reply_to":"da86d52c_ce0913df","updated":"2015-02-09 05:08:35.000000000","message":"Done","commit_id":"0ab48666804cc13ffe1014e9c796c2b362f4ffe3"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"6fed208934776046c08b3ca0dfaad718966f42d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When trying to downgrade from 1 to 0, the table \u0027project_endpoint\u0027"},{"line_number":10,"context_line":"cannot be found when mysql is used. To resolve this issue, the"},{"line_number":11,"context_line":"upgrade from 0 to 1 must be fixed to take mysql into account."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1419546"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_dfe1bfd1","line":11,"updated":"2015-02-09 07:15:21.000000000","message":"Actually, I cannot reproduce this bug, maybe we have different working env. as to MYSQL storage engine, the interesting is what storage engine are you using while \"InnoDB\" become a default MYSQL storage engine.\n\nhttp://dev.mysql.com/doc/refman/5.5/en/innodb-default-se.html","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"}],"keystone/contrib/endpoint_filter/migrate_repo/versions/001_add_endpoint_filtering_table.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"6fed208934776046c08b3ca0dfaad718966f42d3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            nullable\u003dFalse),"},{"line_number":37,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":38,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    endpoint_filtering_table.create(migrate_engine, checkfirst\u003dTrue)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7fda9318","line":39,"updated":"2015-02-09 07:15:21.000000000","message":"If this fix works, maybe we still need fix other DB scripts for updating tables, such as \"001_add_identity_provider_table\".","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"}],"keystone/tests/test_sql_migrate_extensions.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e5553e35d41c790976e0b53ba804ea15c8ea7192","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint\u0027)"},{"line_number":176,"context_line":"        self.upgrade(1)"},{"line_number":177,"context_line":"        self._assert_v1_tables()"},{"line_number":178,"context_line":"        self.assertTableColumns(\u0027project_endpoint\u0027,"},{"line_number":179,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"},{"line_number":180,"context_line":"        self.upgrade(2)"},{"line_number":181,"context_line":"        self._assert_v2_tables()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_05feaf38","side":"PARENT","line":178,"updated":"2015-02-08 21:52:59.000000000","message":"this is pointless since it was done in _assert_v1_tables","commit_id":"483f9b2e09c012580f70acc77147ac21fc1a6be4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"463f05207803c2adf35866815ed65f11e01541b6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint\u0027)"},{"line_number":176,"context_line":"        self.upgrade(1)"},{"line_number":177,"context_line":"        self._assert_v1_tables()"},{"line_number":178,"context_line":"        self.assertTableColumns(\u0027project_endpoint\u0027,"},{"line_number":179,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"},{"line_number":180,"context_line":"        self.upgrade(2)"},{"line_number":181,"context_line":"        self._assert_v2_tables()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_65492b8e","side":"PARENT","line":178,"updated":"2015-02-08 22:11:14.000000000","message":"this is pointless, as it\u0027s performed in _assert_v1_tables","commit_id":"483f9b2e09c012580f70acc77147ac21fc1a6be4"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7154933e2713d489465eaec55d50683a7d8b5b01","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _assert_v1_tables(self):"},{"line_number":161,"context_line":"        self.assertTableColumns(\u0027project_endpoint\u0027,"},{"line_number":162,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"},{"line_number":163,"context_line":"        self.assertTableDoesNotExist(\u0027endpoint_group\u0027)"},{"line_number":164,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint_group\u0027)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7419da21","line":162,"updated":"2015-02-09 06:06:10.000000000","message":"duplicated here.","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9cae626ae73320c0ab3bd9a93a8dd30d5a69a4ef","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _assert_v1_tables(self):"},{"line_number":161,"context_line":"        self.assertTableColumns(\u0027project_endpoint\u0027,"},{"line_number":162,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"},{"line_number":163,"context_line":"        self.assertTableDoesNotExist(\u0027endpoint_group\u0027)"},{"line_number":164,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint_group\u0027)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_942bae93","line":162,"in_reply_to":"da86d52c_7419da21","updated":"2015-02-09 06:39:15.000000000","message":"Not sure I understand what you mean here","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"02d5c034daae0ec3f2e07ac3bcb135d44a380227","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _assert_v1_tables(self):"},{"line_number":161,"context_line":"        self.assertTableColumns(\u0027project_endpoint\u0027,"},{"line_number":162,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"},{"line_number":163,"context_line":"        self.assertTableDoesNotExist(\u0027endpoint_group\u0027)"},{"line_number":164,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint_group\u0027)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7f5453ca","line":162,"in_reply_to":"da86d52c_942bae93","updated":"2015-02-09 06:55:53.000000000","message":":), I mark the wrong place, just meant that the added assertion in test_downgrade(...) has been done in _assert_v1_tables, i.e. the follow two lines. no need the extra assertion.","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7154933e2713d489465eaec55d50683a7d8b5b01","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"},{"line_number":163,"context_line":"        self.assertTableDoesNotExist(\u0027endpoint_group\u0027)"},{"line_number":164,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint_group\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _assert_v2_tables(self):"},{"line_number":167,"context_line":"        self.assertTableColumns(\u0027project_endpoint\u0027,"},{"line_number":168,"context_line":"                                [\u0027endpoint_id\u0027, \u0027project_id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_94164ef0","line":165,"updated":"2015-02-09 06:06:10.000000000","message":"same here.","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7154933e2713d489465eaec55d50683a7d8b5b01","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.downgrade(1)"},{"line_number":192,"context_line":"        self._assert_v1_tables()"},{"line_number":193,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint_group\u0027)"},{"line_number":194,"context_line":"        self.assertTableDoesNotExist(\u0027endpoint_group\u0027)"},{"line_number":195,"context_line":"        self.downgrade(0)"},{"line_number":196,"context_line":"        self.assertTableDoesNotExist(\u0027project_endpoint\u0027)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_341f620b","line":194,"updated":"2015-02-09 06:06:10.000000000","message":"Steve, those assertion is duplicated in _assert_v1_tables(), expected to remove these changes.","commit_id":"436e9bed25d18f1d57baebcefa6bccdd8a5dc917"}]}