)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1c9823447ec3fcaa842cea634ca70a34d71bf8c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improves support for sample data script with ssl"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SSL certs not providing subjectAuthName - such as those generated"},{"line_number":10,"context_line":" with the keystone-manage ssl_setup command result in a warning"},{"line_number":11,"context_line":" with each response.  Added some string mangling to ensure that"},{"line_number":12,"context_line":" the sample data script isn\u0027t affected by the ssl warning.  The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_09cd92b7","line":9,"updated":"2015-03-18 18:40:07.000000000","message":"SSL certs do not*","commit_id":"0a48c797fa78f26f1344b5dc123dcdb66cb98aee"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"449cd406db20a139aa2099829eb733a768056236","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improves support for sample data script with ssl"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SSL certs not providing subjectAuthName - such as those generated"},{"line_number":10,"context_line":" with the keystone-manage ssl_setup command result in a warning"},{"line_number":11,"context_line":" with each response.  Added some string mangling to ensure that"},{"line_number":12,"context_line":" the sample data script isn\u0027t affected by the ssl warning.  The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_d8eec78a","line":9,"in_reply_to":"9a80dd14_09cd92b7","updated":"2015-03-19 09:30:58.000000000","message":"Yes, that\u0027s kind of the point.  The python libraries used issue this warning when not finding subjectAuthName in the cert - and the script fails if keystone is operating over https.","commit_id":"0a48c797fa78f26f1344b5dc123dcdb66cb98aee"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1c9823447ec3fcaa842cea634ca70a34d71bf8c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":" with each response.  Added some string mangling to ensure that"},{"line_number":12,"context_line":" the sample data script isn\u0027t affected by the ssl warning.  The"},{"line_number":13,"context_line":" text up to and including \u0027SecurityWarning\u0027 in the response is"},{"line_number":14,"context_line":" discarded."},{"line_number":15,"context_line":"Parse the protocol out of the endpoint against which the script is"},{"line_number":16,"context_line":" running so that the service endpoint declares https where this is"},{"line_number":17,"context_line":" configured."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_89b8a212","line":14,"updated":"2015-03-18 18:40:07.000000000","message":"Interesting indentation going on here.","commit_id":"0a48c797fa78f26f1344b5dc123dcdb66cb98aee"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"449cd406db20a139aa2099829eb733a768056236","unresolved":false,"context_lines":[{"line_number":11,"context_line":" with each response.  Added some string mangling to ensure that"},{"line_number":12,"context_line":" the sample data script isn\u0027t affected by the ssl warning.  The"},{"line_number":13,"context_line":" text up to and including \u0027SecurityWarning\u0027 in the response is"},{"line_number":14,"context_line":" discarded."},{"line_number":15,"context_line":"Parse the protocol out of the endpoint against which the script is"},{"line_number":16,"context_line":" running so that the service endpoint declares https where this is"},{"line_number":17,"context_line":" configured."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_b87af3b7","line":14,"in_reply_to":"9a80dd14_89b8a212","updated":"2015-03-19 09:30:58.000000000","message":"I don\u0027t think it\u0027s particularly interesting but I do like it because it adds grouping to the statements.  However, if you want it gone then I shall do that.","commit_id":"0a48c797fa78f26f1344b5dc123dcdb66cb98aee"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SSL certs generated by \"keystone-manage ssl_setup\" do not provide"},{"line_number":10,"context_line":"subjectAuthName.  This results in a warning with each response."},{"line_number":11,"context_line":"The sample_data script fails to cope with this."},{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa041b7_f8dd1943","line":12,"updated":"2015-04-02 21:19:23.000000000","message":"Confiurable -\u003e configurable","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"fdeb589fca254e5583ee724b796f789efcbe5f21","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SSL certs generated by \"keystone-manage ssl_setup\" do not provide"},{"line_number":10,"context_line":"subjectAuthName.  This results in a warning with each response."},{"line_number":11,"context_line":"The sample_data script fails to cope with this."},{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa041b7_582be594","line":12,"updated":"2015-04-02 21:26:57.000000000","message":"Maybe start a new paragraph here...or some other separator.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SSL certs generated by \"keystone-manage ssl_setup\" do not provide"},{"line_number":10,"context_line":"subjectAuthName.  This results in a warning with each response."},{"line_number":11,"context_line":"The sample_data script fails to cope with this."},{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa53dc9_443b1bec","line":12,"in_reply_to":"baa041b7_582be594","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SSL certs generated by \"keystone-manage ssl_setup\" do not provide"},{"line_number":10,"context_line":"subjectAuthName.  This results in a warning with each response."},{"line_number":11,"context_line":"The sample_data script fails to cope with this."},{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa53dc9_8431230e","line":12,"in_reply_to":"baa041b7_f8dd1943","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"},{"line_number":16,"context_line":"this is used to generate certs too."},{"line_number":17,"context_line":"Updated test fixtures where necessary."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa041b7_f8b4f9f2","line":15,"updated":"2015-04-02 21:19:23.000000000","message":"Can you prefix each item with - so this appears as a billeted list.  Thanks","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"fdeb589fca254e5583ee724b796f789efcbe5f21","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"},{"line_number":16,"context_line":"this is used to generate certs too."},{"line_number":17,"context_line":"Updated test fixtures where necessary."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa041b7_181c3d76","line":15,"updated":"2015-04-02 21:26:57.000000000","message":"a new paragraph here... or some other separator.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"},{"line_number":16,"context_line":"this is used to generate certs too."},{"line_number":17,"context_line":"Updated test fixtures where necessary."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa53dc9_c42f2ba0","line":15,"in_reply_to":"baa041b7_181c3d76","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Added a subjectAltName field to the certs generated - confiurable"},{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"},{"line_number":16,"context_line":"this is used to generate certs too."},{"line_number":17,"context_line":"Updated test fixtures where necessary."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa53dc9_042633ce","line":15,"in_reply_to":"baa041b7_f8b4f9f2","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"},{"line_number":16,"context_line":"this is used to generate certs too."},{"line_number":17,"context_line":"Updated test fixtures where necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug #1419825"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa041b7_f882b9ff","line":16,"updated":"2015-04-02 21:19:23.000000000","message":"Nit: too used twice in the same sentence sounds a little awkward.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in the [ssl] section of the config file as a multi string opt"},{"line_number":14,"context_line":"\u0027subject_alt_names\u0027."},{"line_number":15,"context_line":"Added \u0027subject_alt_names\u0027 to [signing] section in config too as"},{"line_number":16,"context_line":"this is used to generate certs too."},{"line_number":17,"context_line":"Updated test fixtures where necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug #1419825"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa53dc9_e4090f33","line":16,"in_reply_to":"baa041b7_f882b9ff","updated":"2015-04-07 10:10:35.000000000","message":"Not awkward, just rubbish.  Thanks for saving me from myself.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"}],"etc/keystone.conf.sample":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"baa041b7_d8d495be","updated":"2015-04-02 21:19:23.000000000","message":"I think this file is generally updated using execution of he Oslo config generator in a separate patch not manually.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9aa53dc9_c4584b59","in_reply_to":"baa041b7_9b0f272e","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9aa53dc9_a455471e","in_reply_to":"baa041b7_d8d495be","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"fdeb589fca254e5583ee724b796f789efcbe5f21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"baa041b7_9b0f272e","in_reply_to":"baa041b7_d8d495be","updated":"2015-04-02 21:26:57.000000000","message":"don\u0027t include this file, one of the cores will upload a version for you","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"}],"keystone/common/config.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                   help\u003d\u0027SSL certificate subject (auto generated \u0027"},{"line_number":391,"context_line":"                        \u0027certificate).\u0027),"},{"line_number":392,"context_line":"        cfg.MultiStrOpt(\u0027subject_alt_names\u0027,"},{"line_number":393,"context_line":"                        default\u003d[\u0027localhost\u0027],"},{"line_number":394,"context_line":"                        help\u003d\u0027SSL certificate subject alternative names \u0027"},{"line_number":395,"context_line":"                        \u0027(auto generated certificate).\u0027),"},{"line_number":396,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_98c60d48","line":393,"updated":"2015-04-02 21:19:23.000000000","message":"It would be nice if this maybe defaulted to the host name of where the script was run.  Using local host in the subAltName is probably worse than having none.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                   help\u003d\u0027SSL certificate subject (auto generated \u0027"},{"line_number":391,"context_line":"                        \u0027certificate).\u0027),"},{"line_number":392,"context_line":"        cfg.MultiStrOpt(\u0027subject_alt_names\u0027,"},{"line_number":393,"context_line":"                        default\u003d[\u0027localhost\u0027],"},{"line_number":394,"context_line":"                        help\u003d\u0027SSL certificate subject alternative names \u0027"},{"line_number":395,"context_line":"                        \u0027(auto generated certificate).\u0027),"},{"line_number":396,"context_line":"    ],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_045f5342","line":393,"in_reply_to":"baa041b7_98c60d48","updated":"2015-04-07 10:10:35.000000000","message":"Although I agree that systems that just work are attractive, in this case we\u0027re adding properties for generating a dev environment certificate only.  I think magic should be kept to a minimum.  Although getting the hostname is possible with only std lib dependencies I am reluctant to add anything here.  I just don\u0027t think there\u0027s sufficient benefit.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6cfb101562339293252c938324d4af4cf6e90283","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        cfg.MultiStrOpt(\u0027subject_alt_names\u0027,"},{"line_number":389,"context_line":"                        default\u003d[\u0027localhost\u0027],"},{"line_number":390,"context_line":"                        help\u003d\u0027SSL certificate subject alternative names \u0027"},{"line_number":391,"context_line":"                        \u0027(auto generated certificate).\u0027),"},{"line_number":392,"context_line":"    ],"},{"line_number":393,"context_line":"    \u0027signing\u0027: ["},{"line_number":394,"context_line":"        cfg.StrOpt(\u0027certfile\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_a7c9e4ae","line":391,"updated":"2015-06-04 19:17:06.000000000","message":"This help text is the same as the subject_alt_names configuration option added below. Is there anyway that we could differentiate it if both config options are used for different purposes? If they aren\u0027t used for different purposes then should they be collapsed?","commit_id":"2ec9e8fbf2bf2e057e8f7b325f60f60e5a51cc1f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"882c31ecd9152939618e9356c5cf5acd5b7b5b2d","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                   default\u003d\u0027/C\u003dUS/ST\u003dUnset/L\u003dUnset/O\u003dUnset/CN\u003dlocalhost\u0027,"},{"line_number":344,"context_line":"                   help\u003d\u0027SSL certificate subject (auto generated \u0027"},{"line_number":345,"context_line":"                        \u0027certificate).\u0027),"},{"line_number":346,"context_line":"        cfg.MultiStrOpt(\u0027subject_alt_names\u0027,"},{"line_number":347,"context_line":"                        default\u003d[\u0027localhost\u0027],"},{"line_number":348,"context_line":"                        help\u003d\u0027SSL certificate subject alternative names \u0027"},{"line_number":349,"context_line":"                        \u0027(auto generated certificate).\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_3100ce65","line":346,"updated":"2016-02-01 19:33:23.000000000","message":"Not sure this is really worth doing (Open to it?) because using keystone to autogen certs is probably the wrong choice.","commit_id":"099fc0756639354a434dafb9f08df17724b20fbc"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"882c31ecd9152939618e9356c5cf5acd5b7b5b2d","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                            \u0027CN\u003dwww.example.com\u0027),"},{"line_number":376,"context_line":"                   help\u003d\u0027Certificate subject (auto generated certificate) for \u0027"},{"line_number":377,"context_line":"                        \u0027token signing.\u0027),"},{"line_number":378,"context_line":"        cfg.MultiStrOpt(\u0027subject_alt_names\u0027,"},{"line_number":379,"context_line":"                        default\u003d([\u0027localhost\u0027]),"},{"line_number":380,"context_line":"                        help\u003d\u0027SSL certificate subject alternative names \u0027"},{"line_number":381,"context_line":"                        \u0027(auto generated certificate).\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_d1d4daec","line":378,"updated":"2016-02-01 19:33:23.000000000","message":"Don\u0027t add more into the PKI stuff. PKI tokens are deprecated and use of pkisetup was discouraged anyway.","commit_id":"099fc0756639354a434dafb9f08df17724b20fbc"}],"keystone/common/openssl.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":38,"context_line":"def generate_san(subject_alt_names):"},{"line_number":39,"context_line":"    san_block \u003d \u0027\u0027"},{"line_number":40,"context_line":"    for san in subject_alt_names:"},{"line_number":41,"context_line":"        san_block \u003d \u0027%s%s \u003d %s\\n\u0027 %\\"},{"line_number":42,"context_line":"                    (san_block,"},{"line_number":43,"context_line":"                     (\u0027DNS.%s\u0027 % subject_alt_names.index(san)),"},{"line_number":44,"context_line":"                     san)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_182f9df7","line":41,"updated":"2015-04-02 21:19:23.000000000","message":"Use of \\ should be avoided here.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":38,"context_line":"def generate_san(subject_alt_names):"},{"line_number":39,"context_line":"    san_block \u003d \u0027\u0027"},{"line_number":40,"context_line":"    for san in subject_alt_names:"},{"line_number":41,"context_line":"        san_block \u003d \u0027%s%s \u003d %s\\n\u0027 %\\"},{"line_number":42,"context_line":"                    (san_block,"},{"line_number":43,"context_line":"                     (\u0027DNS.%s\u0027 % subject_alt_names.index(san)),"},{"line_number":44,"context_line":"                     san)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_24d6d7c5","line":41,"in_reply_to":"baa041b7_182f9df7","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    for san in subject_alt_names:"},{"line_number":41,"context_line":"        san_block \u003d \u0027%s%s \u003d %s\\n\u0027 %\\"},{"line_number":42,"context_line":"                    (san_block,"},{"line_number":43,"context_line":"                     (\u0027DNS.%s\u0027 % subject_alt_names.index(san)),"},{"line_number":44,"context_line":"                     san)"},{"line_number":45,"context_line":"    return san_block"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_782109fb","line":43,"updated":"2015-04-02 21:19:23.000000000","message":"What about subAltNames with IP. ? For systems that have no host name, it\u0027s better to use a static IP using IP.xxx.xxx.xxx.xxx rather than DNS.","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8f7e9d171a98221d05f56d4ae9257b7d76394925","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    for san in subject_alt_names:"},{"line_number":41,"context_line":"        san_block \u003d \u0027%s%s \u003d %s\\n\u0027 %\\"},{"line_number":42,"context_line":"                    (san_block,"},{"line_number":43,"context_line":"                     (\u0027DNS.%s\u0027 % subject_alt_names.index(san)),"},{"line_number":44,"context_line":"                     san)"},{"line_number":45,"context_line":"    return san_block"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa53dc9_04dcf3e2","line":43,"in_reply_to":"baa041b7_782109fb","updated":"2015-04-07 10:10:35.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"122ecda4133372e683be1c7797ddcb49edde7d46","unresolved":false,"context_lines":[{"line_number":358,"context_line":"basicConstraints       \u003d CA:FALSE"},{"line_number":359,"context_line":"subjectKeyIdentifier   \u003d hash"},{"line_number":360,"context_line":"authorityKeyIdentifier \u003d keyid:always"},{"line_number":361,"context_line":"subjectAltName\u003d@alt_names"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"[ alt_names ]"},{"line_number":364,"context_line":"%(subject_alt_names)s"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa041b7_f883d9ca","line":361,"updated":"2015-04-02 21:19:23.000000000","message":"Might want to keep that same indenting","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"c90aaadb89b14ba632bde4c2a8e9ca736b74a8d0","unresolved":false,"context_lines":[{"line_number":358,"context_line":"basicConstraints       \u003d CA:FALSE"},{"line_number":359,"context_line":"subjectKeyIdentifier   \u003d hash"},{"line_number":360,"context_line":"authorityKeyIdentifier \u003d keyid:always"},{"line_number":361,"context_line":"subjectAltName\u003d@alt_names"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"[ alt_names ]"},{"line_number":364,"context_line":"%(subject_alt_names)s"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_96e82212","line":361,"in_reply_to":"baa041b7_f883d9ca","updated":"2015-04-21 10:37:53.000000000","message":"Done","commit_id":"b589cf042ebc5763b461cb1e6bebe15845c3c066"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"39dbadbafb6db5f2ce005c19aa3d2bdad8930790","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def generate_san(subject_alt_names):"},{"line_number":40,"context_line":"    san_block \u003d \u0027\u0027"},{"line_number":41,"context_line":"    for san in subject_alt_names:"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            socket.inet_aton(san)"},{"line_number":44,"context_line":"            # san is a valid ip address"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_28e8bab3","line":41,"updated":"2015-10-20 20:37:51.000000000","message":"Maybe more clear and DRY like this:\n\ntry:\n    socket.inet_aton(san)\n    san_type \u003d \u0027IP\u0027  # san is a valid IP address\nexcept socket.error:\n   # assume san to be FQDN\n    san_type \u003d \u0027DNS\u0027\n\nsan_block \u003d (\u0027%s%s \u003d %s\\n\u0027 %\n                      (san_block,\n\t\t      (\u0027%s.%s\u0027 % (san_type, subject_alt_names.index(san))), san))","commit_id":"2ec9e8fbf2bf2e057e8f7b325f60f60e5a51cc1f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"25a542d328d81e69ef3de1af6310616de015aa08","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def generate_san(subject_alt_names):"},{"line_number":40,"context_line":"    san_block \u003d \u0027\u0027"},{"line_number":41,"context_line":"    for san in subject_alt_names:"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            socket.inet_aton(san)"},{"line_number":44,"context_line":"            # san is a valid ip address"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_85b95bce","line":41,"in_reply_to":"3a29b11f_28e8bab3","updated":"2015-10-22 14:42:27.000000000","message":"IMO the nesting of the % operations is the bigger problem. It would be much clearer over multiple lines. It may be nicer to build this up using a list and join before returning.","commit_id":"2ec9e8fbf2bf2e057e8f7b325f60f60e5a51cc1f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6cfb101562339293252c938324d4af4cf6e90283","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                               \u0027cert_subject\u0027: conf_obj.cert_subject,"},{"line_number":82,"context_line":"                               \u0027subject_alt_names\u0027:"},{"line_number":83,"context_line":"                                   generate_san("},{"line_number":84,"context_line":"                                       conf_obj.subject_alt_names)}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            # OpenSSL 1.0 and newer support default_md \u003d default, olders do not"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_07bb1810","line":84,"updated":"2015-06-04 19:17:06.000000000","message":"This is using the CONF.ssl.subject_alt_names from the config, right? Are the CONF.signing.subject_alt_names used anywhere in this patch?","commit_id":"2ec9e8fbf2bf2e057e8f7b325f60f60e5a51cc1f"}],"keystone/tests/unit/test_cert_setup.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"d3b0d6c12c75891c4e9c3a088acf42e3d96bb2fe","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            certfile\u003dos.path.join(CERTDIR, \u0027keystone.pem\u0027),"},{"line_number":70,"context_line":"            keyfile\u003dos.path.join(KEYDIR, \u0027keystonekey.pem\u0027))"},{"line_number":71,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, provider\u003d\u0027pkiz\u0027)"},{"line_number":72,"context_line":"        self.config_fixture.config("},{"line_number":73,"context_line":"            group\u003d\u0027ssl\u0027,"},{"line_number":74,"context_line":"            subject_alt_names\u003d[\u0027localhost\u0027]"},{"line_number":75,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_a57fb7de","line":72,"updated":"2015-10-22 14:43:12.000000000","message":"Is there any way to test that this actually did something?","commit_id":"2ec9e8fbf2bf2e057e8f7b325f60f60e5a51cc1f"}]}