)]}'
{"keystone/common/cache/_memcache_pool.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"9f1b6c9d643e41c6c490313c566f270bec575d35","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self._debug_logger(\u0027Releasing connection %s\u0027, id(conn))"},{"line_number":119,"context_line":"            self._drop_expired_connections()"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                queue.Queue.put(self, conn, block\u003dFalse)"},{"line_number":122,"context_line":"            except queue.Full:"},{"line_number":123,"context_line":"                self._debug_logger(\u0027Reaping exceeding connection %s\u0027, id(conn))"},{"line_number":124,"context_line":"                self._destroy_connection(conn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_77f1f269","line":121,"updated":"2015-02-13 15:27:39.000000000","message":"an inline comment explaining why you\u0027re doing this would be beneficial for future reference, otherwise this is just going to be rewritten and the bug re-introduced","commit_id":"1204de2aa36156022f7ff13f7aee24cf528c65c9"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"2ac5ec3bf49b571b5cee526cdd6073f03c149565","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self._debug_logger(\u0027Releasing connection %s\u0027, id(conn))"},{"line_number":119,"context_line":"            self._drop_expired_connections()"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                queue.Queue.put(self, conn, block\u003dFalse)"},{"line_number":122,"context_line":"            except queue.Full:"},{"line_number":123,"context_line":"                self._debug_logger(\u0027Reaping exceeding connection %s\u0027, id(conn))"},{"line_number":124,"context_line":"                self._destroy_connection(conn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_9adbeb4e","line":121,"in_reply_to":"da86d52c_77f1f269","updated":"2015-02-13 15:36:06.000000000","message":"It is used multiple times like this, on lines 70, 181, 221. Do you think that a comment should be added for each usage?","commit_id":"1204de2aa36156022f7ff13f7aee24cf528c65c9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9fc4ee12f70912d1a48bad754abcc45b0eebc45d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self._debug_logger(\u0027Releasing connection %s\u0027, id(conn))"},{"line_number":119,"context_line":"            self._drop_expired_connections()"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                queue.Queue.put(self, conn, block\u003dFalse)"},{"line_number":122,"context_line":"            except queue.Full:"},{"line_number":123,"context_line":"                self._debug_logger(\u0027Reaping exceeding connection %s\u0027, id(conn))"},{"line_number":124,"context_line":"                self._destroy_connection(conn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a04dd99b","line":121,"in_reply_to":"da86d52c_9adbeb4e","updated":"2015-02-13 18:07:57.000000000","message":"I think it would make sense if it were written on each call. If it only exists on one then someone might miss it and continue rewriting the logic to reintroduce the bug. Or attempt consolidating this into a function that can be well documented that we implement in each place.","commit_id":"1204de2aa36156022f7ff13f7aee24cf528c65c9"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"7741c4ff324a4f6019d497d948165d7b78830e75","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            self._debug_logger(\u0027Releasing connection %s\u0027, id(conn))"},{"line_number":119,"context_line":"            self._drop_expired_connections()"},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                queue.Queue.put(self, conn, block\u003dFalse)"},{"line_number":122,"context_line":"            except queue.Full:"},{"line_number":123,"context_line":"                self._debug_logger(\u0027Reaping exceeding connection %s\u0027, id(conn))"},{"line_number":124,"context_line":"                self._destroy_connection(conn)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_90bc75dd","line":121,"in_reply_to":"da86d52c_a04dd99b","updated":"2015-02-16 13:44:07.000000000","message":"Done","commit_id":"1204de2aa36156022f7ff13f7aee24cf528c65c9"}]}