)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"2bdf91997b263f97ab26e417b137770235900796","unresolved":false,"context_lines":[{"line_number":13,"context_line":"as string. Any attribute value that is equal to \u0027TRUE\u0027 or \u0027FALSE\u0027"},{"line_number":14,"context_line":"are converted to boolean value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Only \u0027enabled\u0027 attribute require this type of handling, and it is"},{"line_number":17,"context_line":"already by enabled2py function. The additional handling on ldap2py"},{"line_number":18,"context_line":"function should be removed."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_f67f29de","line":16,"updated":"2015-02-11 03:25:20.000000000","message":"Great commit message!","commit_id":"5b82b8ab6fd181124b9fb0fdb5f8ab76ff715435"}],"keystone/common/ldap/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"79547b543807f2cf02e62f0ec29859b5fce15623","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    \"\"\"Convert an LDAP formatted value to Python type used by OpenStack."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    Virtually all LDAP values are stored as UTF-8 encoded strings."},{"line_number":127,"context_line":"    OpenStack prefers values which are Python types, e.g. unicode, etc."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param val: LDAP formatted value"},{"line_number":130,"context_line":"    :returns: val converted to preferred Python type"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_98b8dc12","line":127,"updated":"2015-02-11 01:32:03.000000000","message":"i suppose this could just be \"OpenStack prefers values which are unicode friendly\"","commit_id":"77b02ba2860f476d2de5497fa45efee3af8fe125"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"2bdf91997b263f97ab26e417b137770235900796","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    :param val: LDAP formatted value"},{"line_number":130,"context_line":"    :returns: val converted to preferred Python type"},{"line_number":131,"context_line":"    \"\"\""},{"line_number":132,"context_line":"    return utf8_decode(val)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_7624190d","line":131,"updated":"2015-02-11 03:25:20.000000000","message":"Nice catch!","commit_id":"5b82b8ab6fd181124b9fb0fdb5f8ab76ff715435"}],"keystone/tests/test_backend_ldap.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"79547b543807f2cf02e62f0ec29859b5fce15623","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        # Ensure that any attribute that is equal to the string \u0027TRUE\u0027"},{"line_number":666,"context_line":"        # or \u0027FALSE\u0027 will not be converted to a boolean value, it"},{"line_number":667,"context_line":"        # should be returned as is."},{"line_number":668,"context_line":"        boolean_strings \u003d [\u0027TRUE\u0027, \u0027FALSE\u0027]"},{"line_number":669,"context_line":"        for name in boolean_strings:"},{"line_number":670,"context_line":"            user \u003d {"},{"line_number":671,"context_line":"                \u0027name\u0027: name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_58702472","line":668,"updated":"2015-02-11 01:32:03.000000000","message":"i wouldn\u0027t mind adding \u0027true\u0027, \u0027false\u0027, \u0027True\u0027, \u0027False\u0027, \u0027FaLse\u0027 into the mix either","commit_id":"77b02ba2860f476d2de5497fa45efee3af8fe125"}],"keystone/tests/unit/common/test_ldap.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d6bcebd0d728a5ff8938a93100cd6d509e8ffe60","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                }"},{"line_number":499,"context_line":"            ), ]"},{"line_number":500,"context_line":"            py_result \u003d ks_ldap.convert_ldap_result(result)"},{"line_number":501,"context_line":"            # The user id should be 0123456, and the user name"},{"line_number":502,"context_line":"            # should be a string value."},{"line_number":503,"context_line":"            self.assertEqual(user_id, py_result[0][1][\u0027user_id\u0027][0])"},{"line_number":504,"context_line":"            self.assertEqual(user_name, py_result[0][1][\u0027user_name\u0027][0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_b861203b","line":501,"updated":"2015-02-11 01:56:18.000000000","message":"this comment is not related to this test case :)","commit_id":"33b10732c1f73916bdc5b9e84e5843da81e51609"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bfe413244903d846244cf3e41f9d633a0539cba0","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                }"},{"line_number":499,"context_line":"            ), ]"},{"line_number":500,"context_line":"            py_result \u003d ks_ldap.convert_ldap_result(result)"},{"line_number":501,"context_line":"            # The user id should be 0123456, and the user name"},{"line_number":502,"context_line":"            # should be a string value."},{"line_number":503,"context_line":"            self.assertEqual(user_id, py_result[0][1][\u0027user_id\u0027][0])"},{"line_number":504,"context_line":"            self.assertEqual(user_name, py_result[0][1][\u0027user_name\u0027][0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_dbefae1c","line":501,"in_reply_to":"da86d52c_b861203b","updated":"2015-02-11 02:20:31.000000000","message":"copy/paste :P","commit_id":"33b10732c1f73916bdc5b9e84e5843da81e51609"}]}