)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7bdec06067a37e65a62bd0c9a8422f67fe205be2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Made project_id required for ec2 credential"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ec2 tokens cannot be created without the user and project"},{"line_number":10,"context_line":"associated with the credentials. The project_id must be"},{"line_number":11,"context_line":"required when creating ec2 credentials."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updating json schema to check:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_62d0a01f","line":10,"updated":"2015-03-13 21:10:07.000000000","message":"change \"must be\" to \"is\"","commit_id":"a9f257dc0597a393aac4b2165b5066b35165dbcf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7bdec06067a37e65a62bd0c9a8422f67fe205be2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- if ec2 type, project_id is required"},{"line_number":15,"context_line":"- else, project_id is optional"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":" Closes-Bug: #1268977"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id7118e028d8c3ff607ac24cd9ecba90a905ce91f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_82cbd470","line":17,"updated":"2015-03-13 21:10:07.000000000","message":"formatting is off, remove leading space.","commit_id":"a9f257dc0597a393aac4b2165b5066b35165dbcf"}],"keystone/tests/unit/test_v3_credential.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"7088e17518ebca48cdabb665952451961a5bfaf3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027/credentials/%(credential_id)s\u0027 % {"},{"line_number":131,"context_line":"                \u0027credential_id\u0027: self.credential_id})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_create_ec2_credential(self):"},{"line_number":134,"context_line":"        \"\"\"Call ``POST /credentials`` for creating ec2 credential.\"\"\""},{"line_number":135,"context_line":"        ref \u003d self.new_credential_ref(user_id\u003dself.user[\u0027id\u0027],"},{"line_number":136,"context_line":"                                      project_id\u003dself.project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c52d0900","line":133,"updated":"2015-03-06 15:33:26.000000000","message":"I\u0027d like to see a test where similar call is failing as there is no project_id specified.","commit_id":"0ad595c29ec20a48641edeedfae6c86f5834f91b"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d03e39dfdfb71a8abcbae8cb68323b436f45e76d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027/credentials/%(credential_id)s\u0027 % {"},{"line_number":131,"context_line":"                \u0027credential_id\u0027: self.credential_id})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_create_ec2_credential(self):"},{"line_number":134,"context_line":"        \"\"\"Call ``POST /credentials`` for creating ec2 credential.\"\"\""},{"line_number":135,"context_line":"        ref \u003d self.new_credential_ref(user_id\u003dself.user[\u0027id\u0027],"},{"line_number":136,"context_line":"                                      project_id\u003dself.project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_460d95e7","line":133,"in_reply_to":"9a80dd14_12159b9b","updated":"2015-03-13 07:52:16.000000000","message":"The point was to make sure that this validation will be properly fired away when we call it via API and over the \"Internet\" :-)","commit_id":"0ad595c29ec20a48641edeedfae6c86f5834f91b"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9ca1c2c217ba4d74d6332c4d373a27491431f2c2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027/credentials/%(credential_id)s\u0027 % {"},{"line_number":131,"context_line":"                \u0027credential_id\u0027: self.credential_id})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_create_ec2_credential(self):"},{"line_number":134,"context_line":"        \"\"\"Call ``POST /credentials`` for creating ec2 credential.\"\"\""},{"line_number":135,"context_line":"        ref \u003d self.new_credential_ref(user_id\u003dself.user[\u0027id\u0027],"},{"line_number":136,"context_line":"                                      project_id\u003dself.project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_12159b9b","line":133,"in_reply_to":"9a80dd14_c52d0900","updated":"2015-03-06 18:31:00.000000000","message":"There is already a test in the schema for that scenario, thought that was enough.\n\nSure, I can add it hear too to validate the flow.","commit_id":"0ad595c29ec20a48641edeedfae6c86f5834f91b"}],"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7bdec06067a37e65a62bd0c9a8422f67fe205be2","unresolved":false,"context_lines":[{"line_number":698,"context_line":"    def test_validate_credential_ec2_without_project_id_fails(self):"},{"line_number":699,"context_line":"        \"\"\"Validate `project_id` is required for ec2."},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        Test that an exception is raised when type is ec2 and no `project_id`"},{"line_number":702,"context_line":"        is provided in create request."},{"line_number":703,"context_line":"        \"\"\""},{"line_number":704,"context_line":"        request_to_validate \u003d {\u0027blob\u0027: \u0027some credential blob\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_e233b011","line":701,"updated":"2015-03-13 21:10:07.000000000","message":"suggest say SchemaValidationError rather than exception, since it matters.","commit_id":"a9f257dc0597a393aac4b2165b5066b35165dbcf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7bdec06067a37e65a62bd0c9a8422f67fe205be2","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                               \u0027user_id\u0027: uuid.uuid4().hex}"},{"line_number":717,"context_line":"        self.create_credential_validator.validate(request_to_validate)"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def test_validate_credential_non_ec2_with_project_id_succeeds(self):"},{"line_number":720,"context_line":"        \"\"\"Test that credential request works for non-ec2.\"\"\""},{"line_number":721,"context_line":"        cred_types \u003d [\u0027cert\u0027, uuid.uuid4().hex]"},{"line_number":722,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_85103e4f","line":719,"updated":"2015-03-13 21:10:07.000000000","message":"this test could be combined with the previous one, since it should work with all types.","commit_id":"a9f257dc0597a393aac4b2165b5066b35165dbcf"}]}