)]}'
{"keystone/resource/core.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c15dc76a8c633a72f4700ece01abec3b5874df67","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            raise AssertionError(_(\u0027Domain is disabled: %s\u0027) % domain_id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def assert_domain_not_federated(self, domain_id, domain):"},{"line_number":126,"context_line":"        \"\"\"Assert the Domain\u0027s name and id are not \"Federated\"."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        Note that the reserved keyword \u0027Federated\u0027 is case insensitive"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a1459216","line":126,"updated":"2015-02-17 04:44:24.000000000","message":"(NIT) This docstring is incorrect now, please update.","commit_id":"3ba3a3302f43484cfa178b74c3426cf30a93410d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c15dc76a8c633a72f4700ece01abec3b5874df67","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        if domain.get(\u0027name\u0027) is not None:"},{"line_number":134,"context_line":"            if (domain[\u0027name\u0027].lower() \u003d\u003d"},{"line_number":135,"context_line":"                (CONF.federation.federated_domain_name).lower()):"},{"line_number":136,"context_line":"                raise AssertionError(_(\u0027Domain cannot be named %s: %s\u0027)"},{"line_number":137,"context_line":"                                     % (CONF.federation.federated_domain_name,"},{"line_number":138,"context_line":"                                     domain_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e166aaba","line":135,"updated":"2015-02-17 04:44:24.000000000","message":"Recommend only performing CONF.federation.federated_domain_name.lower() only once. this is duplicated on line 141.","commit_id":"3ba3a3302f43484cfa178b74c3426cf30a93410d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6ae3cb34bf93b1b8c1d7f236cdfa22cd1af03fbd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :raise AssertionError if domain named match the value in the config."},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        reserved_name \u003d CONF.federation.federated_domain_name"},{"line_number":135,"context_line":"        if domain.get(\u0027name\u0027) is not None:"},{"line_number":136,"context_line":"            if (domain[\u0027name\u0027].lower() \u003d\u003d reserved_name.lower()):"},{"line_number":137,"context_line":"                raise AssertionError(_(\u0027Domain cannot be named %s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_5c5bddf5","line":134,"updated":"2015-02-17 05:50:45.000000000","message":".lower() here.","commit_id":"1c7c231a51618b40003c23cfc6a8b074ef595385"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a46ad4e1d0865429a4f4de3dc402afa50e626ff0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        reserved_name \u003d CONF.federation.federated_domain_name.lower()"},{"line_number":135,"context_line":"        if domain.get(\u0027name\u0027) is not None:"},{"line_number":136,"context_line":"            if (domain[\u0027name\u0027].lower() \u003d\u003d reserved_name):"},{"line_number":137,"context_line":"                raise AssertionError(_(\u0027Domain cannot be named %s\u0027)"},{"line_number":138,"context_line":"                                     % reserved_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_9c1ab516","line":135,"updated":"2015-02-17 05:53:20.000000000","message":"We should probably not start if this value is an untrue value (e.g. \"\" or None)","commit_id":"cf01d6aefda528c3db144179cd9501cf564e6f17"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"cbb5f370b84bd80564376c3ee3f3b265c4f32598","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        reserved_name \u003d CONF.federation.federated_domain_name.lower()"},{"line_number":135,"context_line":"        if domain.get(\u0027name\u0027) is not None:"},{"line_number":136,"context_line":"            if (domain[\u0027name\u0027].lower() \u003d\u003d reserved_name):"},{"line_number":137,"context_line":"                raise AssertionError(_(\u0027Domain cannot be named %s\u0027)"},{"line_number":138,"context_line":"                                     % reserved_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_76399d3e","line":135,"in_reply_to":"da86d52c_9c1ab516","updated":"2015-02-17 08:29:56.000000000","message":"Done","commit_id":"cf01d6aefda528c3db144179cd9501cf564e6f17"}]}