)]}'
{"keystone/trust/controllers.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"480d0c0059bfe9686e2275f9e4525bb115f073e2","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @controller.protected()"},{"line_number":269,"context_line":"    def get_role_for_trust(self, context, trust_id, role_id):"},{"line_number":270,"context_line":"        \"\"\"Get a role that has been assigned to a trust.\"\"\""},{"line_number":271,"context_line":"        self._check_role_for_trust(context, trust_id, role_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_28e7a313","line":268,"updated":"2015-02-17 20:49:34.000000000","message":"Any reason not to leave this method.  I suspect that the check_role_for_trust call was supposed to be a public API.  Its not a huge deal to drop pit, but since it was a public method before,  it is more strictly correct to keep it as one.","commit_id":"6c597ea22cb6ea4e9296b9466bed33afa2c5f713"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9c3ab93f87c322ae960aa79ae243f664763c1a1a","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @controller.protected()"},{"line_number":269,"context_line":"    def get_role_for_trust(self, context, trust_id, role_id):"},{"line_number":270,"context_line":"        \"\"\"Get a role that has been assigned to a trust.\"\"\""},{"line_number":271,"context_line":"        self._check_role_for_trust(context, trust_id, role_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f3c6609b","line":268,"in_reply_to":"da86d52c_28e7a313","updated":"2015-02-17 21:08:11.000000000","message":"Thought of hiding methods we don\u0027t expose in external routers.\n\nAdding this back in the next patch","commit_id":"6c597ea22cb6ea4e9296b9466bed33afa2c5f713"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c975152bebb4f336d5c9031955bed386923be33e","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @controller.protected()"},{"line_number":269,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":270,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_425e7346","line":268,"updated":"2015-02-17 22:13:20.000000000","message":"we shouldn\u0027t have a protected function that doesn\u0027t have a line in the policy.json files, so this should also be removed.","commit_id":"1fa26bd743a13c5c69b9147b289147d1b7d8d14d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"36df28b1b3ceb202db92353ae49e4f37fa665eb4","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @controller.protected()"},{"line_number":269,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":270,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_bb82fa4f","line":268,"in_reply_to":"da86d52c_425e7346","updated":"2015-02-17 23:04:31.000000000","message":"Done","commit_id":"1fa26bd743a13c5c69b9147b289147d1b7d8d14d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c82416e11146800b349f747257b5c5f8877bcac3","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_6792a158","line":268,"updated":"2015-02-18 01:29:15.000000000","message":"This method should be removed since there\u0027s no router for it.","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"712da08d0388175ea1fb643b5486a33bdfe102ef","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a7f8184b","line":268,"in_reply_to":"da86d52c_6713805c","updated":"2015-02-18 02:43:41.000000000","message":"How about we add a versionutils.deprecated(), then we can get rid of it next release.","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5949e699dd762ff5781d72b7f7960df75b603757","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_6713805c","line":268,"in_reply_to":"da86d52c_677461cf","updated":"2015-02-18 02:05:12.000000000","message":"I guess since it was a public function, someone, somewhere could be leveraging it. I think having it publicly available is enough, but not wrapped with a policy decorator","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b0cb9fe7c50b5755808cc19398dfffc11010d5d9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_e77e91e3","line":268,"in_reply_to":"da86d52c_6792a158","updated":"2015-02-18 01:43:35.000000000","message":"I actually removed this on PS1, but then ayoung asked the public method to be added back for compatibility reason (including the protected - from IRC).","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bce65744599d413faad35ae9c6376d6cfe02e5a2","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_677461cf","line":268,"in_reply_to":"da86d52c_878f95cc","updated":"2015-02-18 01:57:25.000000000","message":"ayoung\u0027s comments: \"Any reason not to leave this method. I suspect that the check_role_for_trust call was supposed to be a public API. Its not a huge deal to drop pit, but since it was a public method before, it is more strictly correct to keep it as one.\"\n\nI guess based on principal, since the method was already exposed and someone might already calling or extending it. \n\nI am fine either way.  Let me know if I should go ahead and just drop it","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"75cd75a2cf6e217c17353a0dacc37ded9277e001","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_d0b7841f","line":268,"in_reply_to":"da86d52c_a7f8184b","updated":"2015-02-18 04:30:36.000000000","message":"Heh Brant don\u0027t have any love for this method. :) \n\nI think that\u0027s a reasonable compromise, I\u0027ll mark it deprecated for Kilo then.","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"91bf2567341f0ec8a46a74418267273c90e878ba","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        return {\u0027roles\u0027: trust[\u0027roles\u0027],"},{"line_number":266,"context_line":"                \u0027links\u0027: trust[\u0027roles_links\u0027]}"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":269,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_878f95cc","line":268,"in_reply_to":"da86d52c_e77e91e3","updated":"2015-02-18 01:53:20.000000000","message":"compatilibity with what?","commit_id":"290a1f3793990115582ac67dff12d4eb4e27adf8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"d3df7353d28a20bc09da8a7a895e4b9a3f559226","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @versionutils.deprecated("},{"line_number":270,"context_line":"        versionutils.deprecated.KILO,"},{"line_number":271,"context_line":"        remove_in\u003d+2)"},{"line_number":272,"context_line":"    def check_role_for_trust(self, context, trust_id, role_id):"},{"line_number":273,"context_line":"        return self._check_role_for_trust(self, context, trust_id, role_id)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_6fa15093","line":271,"updated":"2015-02-26 02:09:49.000000000","message":"it would be great if we could give a reason why this is deprecated, but I guess it\u0027ll be in the git history.","commit_id":"6ecf99c779c3373acaa6650f15116abade1207f1"}]}