)]}'
{"keystone/tests/unit/backend/core_ldap.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a9718e115700e3c4d1f2ac585d265ee7022110fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from keystone.common import ldap as common_ldap"},{"line_number":17,"context_line":"from keystone.common.ldap import core as common_ldap_core"},{"line_number":18,"context_line":"from keystone.common import sql"},{"line_number":19,"context_line":"from keystone import config"},{"line_number":20,"context_line":"from keystone.tests import unit as tests"},{"line_number":21,"context_line":"from keystone.tests.unit import default_fixtures"},{"line_number":22,"context_line":"from keystone.tests.unit import fakeldap"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_139c9969","line":19,"updated":"2015-03-13 20:16:31.000000000","message":"use from oslo.config import cfg instead.","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a9718e115700e3c4d1f2ac585d265ee7022110fa","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(BaseBackendLdapCommon, self).setUp()"},{"line_number":43,"context_line":"        self.clear_database()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        common_ldap.register_handler(\u0027fake://\u0027, fakeldap.FakeLdap)"},{"line_number":46,"context_line":"        self.load_backends()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_d33f6123","line":43,"updated":"2015-03-13 20:16:31.000000000","message":"is this necessary since there\u0027s an addCleanup?","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"36d55a47d9359eb1f21dfedfdac2bb396e82dbd7","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(BaseBackendLdapCommon, self).setUp()"},{"line_number":43,"context_line":"        self.clear_database()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        common_ldap.register_handler(\u0027fake://\u0027, fakeldap.FakeLdap)"},{"line_number":46,"context_line":"        self.load_backends()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_bb50960b","line":43,"in_reply_to":"9a80dd14_d33f6123","updated":"2015-03-17 14:40:58.000000000","message":"probably not....it was in the code I moved our of test_backend_ldap....so was trying to not change it...but I think is OK to remove...","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a9718e115700e3c4d1f2ac585d265ee7022110fa","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                return None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class BaseBackendLdap(object):"},{"line_number":95,"context_line":"    \"\"\"Mixin class to set up an all-LDAP configuration.\"\"\""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        # NOTE(dstanek): The database must be setup prior to calling the"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_73c235ea","line":94,"updated":"2015-03-13 20:16:31.000000000","message":"This is only used in test_ldap.py, so move it there, or use it here if that\u0027s the intention.","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7250e92f867537d855434507f6272ef01022df8a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                return None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class BaseBackendLdap(object):"},{"line_number":95,"context_line":"    \"\"\"Mixin class to set up an all-LDAP configuration.\"\"\""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        # NOTE(dstanek): The database must be setup prior to calling the"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_bb2df1aa","line":94,"in_reply_to":"9a80dd14_607f4fac","updated":"2015-03-17 14:56:47.000000000","message":"ok, I thought that might be the case. I\u0027m fine with it here.","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"36d55a47d9359eb1f21dfedfdac2bb396e82dbd7","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                return None"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class BaseBackendLdap(object):"},{"line_number":95,"context_line":"    \"\"\"Mixin class to set up an all-LDAP configuration.\"\"\""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        # NOTE(dstanek): The database must be setup prior to calling the"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_607f4fac","line":94,"in_reply_to":"9a80dd14_73c235ea","updated":"2015-03-17 14:40:58.000000000","message":"It\u0027s here, since it will be used by other ldap tests as we migrate them over (e.g. identity/test_ldap, assignment/test_ldap etc.). If you would prefer I move to test_ldap for now and then move it back when the next ldap pieces get migrated over, then let me know.","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a9718e115700e3c4d1f2ac585d265ee7022110fa","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.clear_database()"},{"line_number":122,"context_line":"        self.load_backends()"},{"line_number":123,"context_line":"        cache.configure_cache_region(cache.REGION)"},{"line_number":124,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":125,"context_line":"        self.addCleanup(sql.cleanup)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_5f15333e","line":124,"updated":"2015-03-13 20:16:31.000000000","message":"no need to save this variable, remove self.","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bd0ea04f1f652ea9a9a85ae872a70c03a1f0aee9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.clear_database()"},{"line_number":122,"context_line":"        self.load_backends()"},{"line_number":123,"context_line":"        cache.configure_cache_region(cache.REGION)"},{"line_number":124,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":125,"context_line":"        self.addCleanup(sql.cleanup)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_9fe32ba3","line":124,"in_reply_to":"9a80dd14_5f15333e","updated":"2015-03-13 20:30:27.000000000","message":"took care of this in https://review.openstack.org/#/c/164340/","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"36d55a47d9359eb1f21dfedfdac2bb396e82dbd7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.clear_database()"},{"line_number":122,"context_line":"        self.load_backends()"},{"line_number":123,"context_line":"        cache.configure_cache_region(cache.REGION)"},{"line_number":124,"context_line":"        self.engine \u003d sql.get_engine()"},{"line_number":125,"context_line":"        self.addCleanup(sql.cleanup)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        sql.ModelBase.metadata.create_all(bind\u003dself.engine)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_9c416cab","line":124,"in_reply_to":"9a80dd14_9fe32ba3","updated":"2015-03-17 14:40:58.000000000","message":"Thanks","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"064e89325d7a050229922b161e9d7fb243d4fbc4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from keystone.common import ldap as common_ldap"},{"line_number":17,"context_line":"from keystone.common.ldap import core as common_ldap_core"},{"line_number":18,"context_line":"from keystone.common import sql"},{"line_number":19,"context_line":"from keystone import config"},{"line_number":20,"context_line":"from keystone.tests import unit as tests"},{"line_number":21,"context_line":"from keystone.tests.unit import default_fixtures"},{"line_number":22,"context_line":"from keystone.tests.unit import fakeldap"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_1e4a5955","line":19,"updated":"2015-03-17 20:05:37.000000000","message":"use from oslo.config import cfg instead.","commit_id":"d3cfc9a01fa03ef8cf54b41b29cf40c53d68d122"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8f7b6b34f458412e45e621e04336142a420ca299","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from keystone.common import ldap as common_ldap"},{"line_number":17,"context_line":"from keystone.common.ldap import core as common_ldap_core"},{"line_number":18,"context_line":"from keystone.common import sql"},{"line_number":19,"context_line":"from keystone import config"},{"line_number":20,"context_line":"from keystone.tests import unit as tests"},{"line_number":21,"context_line":"from keystone.tests.unit import default_fixtures"},{"line_number":22,"context_line":"from keystone.tests.unit import fakeldap"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_99f1da97","line":19,"in_reply_to":"9a80dd14_1e4a5955","updated":"2015-03-18 15:48:35.000000000","message":"Done","commit_id":"d3cfc9a01fa03ef8cf54b41b29cf40c53d68d122"}],"keystone/tests/unit/backend/role/test_ldap.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a9718e115700e3c4d1f2ac585d265ee7022110fa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class LdapRole(LdapRoleCommon, core_ldap.BaseBackendLdap, tests.TestCase):"},{"line_number":38,"context_line":"    \"\"\"Test in an all-LDAP configuration."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Include additional tests that are unique to LDAP (or need to be overridden)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_9fb7ab39","line":37,"updated":"2015-03-13 20:16:31.000000000","message":"suggest call this TestLdapRole, unless we\u0027re really going away from that naming convention?","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7250e92f867537d855434507f6272ef01022df8a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class LdapRole(LdapRoleCommon, core_ldap.BaseBackendLdap, tests.TestCase):"},{"line_number":38,"context_line":"    \"\"\"Test in an all-LDAP configuration."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Include additional tests that are unique to LDAP (or need to be overridden)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_5b16b556","line":37,"in_reply_to":"9a80dd14_003f73d7","updated":"2015-03-17 14:56:47.000000000","message":"ok, if that\u0027s the convention now that\u0027s fine with me.","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"36d55a47d9359eb1f21dfedfdac2bb396e82dbd7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class LdapRole(LdapRoleCommon, core_ldap.BaseBackendLdap, tests.TestCase):"},{"line_number":38,"context_line":"    \"\"\"Test in an all-LDAP configuration."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Include additional tests that are unique to LDAP (or need to be overridden)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_003f73d7","line":37,"in_reply_to":"9a80dd14_9fb7ab39","updated":"2015-03-17 14:40:58.000000000","message":"so I called it LdapRole since the class these test are extract from was LdapIdentity (not TestLdapIdentity)...as far as I can see we don\u0027t tend to but \"Test\" in front of the backend test classes...","commit_id":"8585b1f04efead4852a084c750e48cbfe467a157"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"064e89325d7a050229922b161e9d7fb243d4fbc4","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystone import config"},{"line_number":17,"context_line":"from keystone import exception"},{"line_number":18,"context_line":"from keystone.tests import unit as tests"},{"line_number":19,"context_line":"from keystone.tests.unit.backend import core_ldap"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_9e7ba97a","line":16,"updated":"2015-03-17 20:05:37.000000000","message":"use from oslo.config import cfg instead.","commit_id":"d3cfc9a01fa03ef8cf54b41b29cf40c53d68d122"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8f7b6b34f458412e45e621e04336142a420ca299","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystone import config"},{"line_number":17,"context_line":"from keystone import exception"},{"line_number":18,"context_line":"from keystone.tests import unit as tests"},{"line_number":19,"context_line":"from keystone.tests.unit.backend import core_ldap"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_d92a72e6","line":16,"in_reply_to":"9a80dd14_9e7ba97a","updated":"2015-03-18 15:48:35.000000000","message":"Done","commit_id":"d3cfc9a01fa03ef8cf54b41b29cf40c53d68d122"}]}