)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89db751852eda7bce5bb58ffd813207a6c89f31e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use choices in config.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The oslo_config library supports the choices keyword argument. This comment"},{"line_number":10,"context_line":"leverages the use of choices for StrOpts in Keystone\u0027s configuration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib276e22e56eff09ac5a43fb7b93170776806fd12"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_29f77fd4","line":9,"updated":"2015-03-03 16:37:12.000000000","message":"comment -\u003e commit?","commit_id":"d9d3bb528cc31c8891333af82d01e4a40097e3b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"51f472c65fc71e7aee45fac45a8258f129d2b05d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use choices in config.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The oslo_config library supports the choices keyword argument. This comment"},{"line_number":10,"context_line":"leverages the use of choices for StrOpts in Keystone\u0027s configuration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib276e22e56eff09ac5a43fb7b93170776806fd12"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba7be1f8_c1d30fd3","line":9,"in_reply_to":"ba7be1f8_29f77fd4","updated":"2015-03-03 20:06:27.000000000","message":"Done","commit_id":"d9d3bb528cc31c8891333af82d01e4a40097e3b7"}],"keystone/common/config.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"940c8570e5b2196146f18112cc386c3ce37c8477","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                   default\u003d\u0027keystone.token.providers.uuid.Provider\u0027,"},{"line_number":216,"context_line":"                   choices\u003d[\u0027keystone.token.providers.uuid.Provider\u0027,"},{"line_number":217,"context_line":"                            \u0027keystone.token.providers.pki.Provider\u0027,"},{"line_number":218,"context_line":"                            \u0027keystone.token.providers.pkiz.Provider\u0027],"},{"line_number":219,"context_line":"                   help\u003d\u0027Controls the token construction, validation, and \u0027"},{"line_number":220,"context_line":"                        \u0027revocation operations. Core providers are \u0027"},{"line_number":221,"context_line":"                        \u0027\"keystone.token.providers.[pkiz|pki|uuid].\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_33269617","line":218,"updated":"2015-02-20 18:02:47.000000000","message":"we need to allow other options here, since deployments might have plugins.","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1a3fdbe9f6d838f7565c3992216a3de1b7ce7a1","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                   default\u003d\u0027keystone.token.providers.uuid.Provider\u0027,"},{"line_number":216,"context_line":"                   choices\u003d[\u0027keystone.token.providers.uuid.Provider\u0027,"},{"line_number":217,"context_line":"                            \u0027keystone.token.providers.pki.Provider\u0027,"},{"line_number":218,"context_line":"                            \u0027keystone.token.providers.pkiz.Provider\u0027],"},{"line_number":219,"context_line":"                   help\u003d\u0027Controls the token construction, validation, and \u0027"},{"line_number":220,"context_line":"                        \u0027revocation operations. Core providers are \u0027"},{"line_number":221,"context_line":"                        \u0027\"keystone.token.providers.[pkiz|pki|uuid].\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4b6272d9","line":218,"in_reply_to":"ba7be1f8_33269617","updated":"2015-02-20 19:00:51.000000000","message":"good point, done.","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"940c8570e5b2196146f18112cc386c3ce37c8477","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                            \u0027default\u0027],"},{"line_number":525,"context_line":"                   help\u003d\u0027The LDAP dereferencing option for queries. This \u0027"},{"line_number":526,"context_line":"                        \u0027can be either \"never\", \"searching\", \"always\", \u0027"},{"line_number":527,"context_line":"                        \u0027\"finding\" or \"default\". The \"default\" option falls \u0027"},{"line_number":528,"context_line":"                        \u0027back to using default dereferencing configured by \u0027"},{"line_number":529,"context_line":"                        \u0027your ldap.conf.\u0027),"},{"line_number":530,"context_line":"        cfg.IntOpt(\u0027debug_level\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b379a6fe","line":527,"updated":"2015-02-20 18:02:47.000000000","message":"Can we remove the choices from the help text?","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"940c8570e5b2196146f18112cc386c3ce37c8477","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        cfg.StrOpt(\u0027tls_req_cert\u0027, default\u003d\u0027demand\u0027,"},{"line_number":751,"context_line":"                   choices\u003d[\u0027demand\u0027, \u0027never\u0027, \u0027allow\u0027],"},{"line_number":752,"context_line":"                   help\u003d\u0027Valid options for tls_req_cert are demand, never, \u0027"},{"line_number":753,"context_line":"                        \u0027and allow.\u0027),"},{"line_number":754,"context_line":"        cfg.BoolOpt(\u0027use_pool\u0027, default\u003dFalse,"},{"line_number":755,"context_line":"                    help\u003d\u0027Enable LDAP connection pooling.\u0027),"},{"line_number":756,"context_line":"        cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b360c636","line":753,"updated":"2015-02-20 18:02:47.000000000","message":"update the help text?","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1a3fdbe9f6d838f7565c3992216a3de1b7ce7a1","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        cfg.StrOpt(\u0027tls_req_cert\u0027, default\u003d\u0027demand\u0027,"},{"line_number":751,"context_line":"                   choices\u003d[\u0027demand\u0027, \u0027never\u0027, \u0027allow\u0027],"},{"line_number":752,"context_line":"                   help\u003d\u0027Valid options for tls_req_cert are demand, never, \u0027"},{"line_number":753,"context_line":"                        \u0027and allow.\u0027),"},{"line_number":754,"context_line":"        cfg.BoolOpt(\u0027use_pool\u0027, default\u003dFalse,"},{"line_number":755,"context_line":"                    help\u003d\u0027Enable LDAP connection pooling.\u0027),"},{"line_number":756,"context_line":"        cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4b90b295","line":753,"in_reply_to":"ba7be1f8_b360c636","updated":"2015-02-20 19:00:51.000000000","message":"Done","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b2295de349935280618d05085524283e1f2a4ab5","unresolved":false,"context_lines":[{"line_number":912,"context_line":"        cfg.StrOpt(\u0027idp_contact_email\u0027,"},{"line_number":913,"context_line":"                   help\u003d\u0027Email address of contact person.\u0027),"},{"line_number":914,"context_line":"        cfg.StrOpt(\u0027idp_contact_telephone\u0027,"},{"line_number":915,"context_line":"                   help\u003d\u0027Telephone number of contact person.\u0027),"},{"line_number":916,"context_line":"        cfg.StrOpt(\u0027idp_contact_type\u0027, default\u003d\u0027other\u0027,"},{"line_number":917,"context_line":"                   help\u003d\u0027Contact type. Allowed values are: \u0027"},{"line_number":918,"context_line":"                        \u0027technical, support, administrative \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_73200ef8","line":915,"updated":"2015-02-20 18:02:27.000000000","message":"you can update this one too, or i\u0027ll do it with another patch, whatever works.","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1a3fdbe9f6d838f7565c3992216a3de1b7ce7a1","unresolved":false,"context_lines":[{"line_number":912,"context_line":"        cfg.StrOpt(\u0027idp_contact_email\u0027,"},{"line_number":913,"context_line":"                   help\u003d\u0027Email address of contact person.\u0027),"},{"line_number":914,"context_line":"        cfg.StrOpt(\u0027idp_contact_telephone\u0027,"},{"line_number":915,"context_line":"                   help\u003d\u0027Telephone number of contact person.\u0027),"},{"line_number":916,"context_line":"        cfg.StrOpt(\u0027idp_contact_type\u0027, default\u003d\u0027other\u0027,"},{"line_number":917,"context_line":"                   help\u003d\u0027Contact type. Allowed values are: \u0027"},{"line_number":918,"context_line":"                        \u0027technical, support, administrative \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_abee8e20","line":915,"in_reply_to":"ba7be1f8_73200ef8","updated":"2015-02-20 19:00:51.000000000","message":"Done, thanks for catching this!","commit_id":"cbc42081a4b54456383870f852ff1d5e70ce7ea3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ecdf2e6fbb58ff8785fab2400ed360990fbb7470","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                         \u0027Only enable this option if your LDAP server \u0027"},{"line_number":511,"context_line":"                         \u0027supports subtree deletion.\u0027),"},{"line_number":512,"context_line":"        cfg.StrOpt(\u0027query_scope\u0027, default\u003d\u0027one\u0027,"},{"line_number":513,"context_line":"                   help\u003d\u0027The LDAP scope for queries, this can be either \u0027"},{"line_number":514,"context_line":"                        \u0027\"one\" (onelevel/singleLevel) or \"sub\" \u0027"},{"line_number":515,"context_line":"                        \u0027(subtree/wholeSubtree).\u0027),"},{"line_number":516,"context_line":"        cfg.IntOpt(\u0027page_size\u0027, default\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_c789aa27","line":513,"updated":"2015-02-24 05:08:59.000000000","message":"Couldn\u0027t choices be used here also?  Choice of \u0027one\u0027 or \u0027sub\u0027","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a745ec044d9177821f79624a3c7be4a6737b07fd","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                         \u0027Only enable this option if your LDAP server \u0027"},{"line_number":511,"context_line":"                         \u0027supports subtree deletion.\u0027),"},{"line_number":512,"context_line":"        cfg.StrOpt(\u0027query_scope\u0027, default\u003d\u0027one\u0027,"},{"line_number":513,"context_line":"                   help\u003d\u0027The LDAP scope for queries, this can be either \u0027"},{"line_number":514,"context_line":"                        \u0027\"one\" (onelevel/singleLevel) or \"sub\" \u0027"},{"line_number":515,"context_line":"                        \u0027(subtree/wholeSubtree).\u0027),"},{"line_number":516,"context_line":"        cfg.IntOpt(\u0027page_size\u0027, default\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_40a1e7f6","line":513,"in_reply_to":"ba7be1f8_c789aa27","updated":"2015-03-03 15:55:16.000000000","message":"Done","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"25cbc2e186192a1a3fc09b2ab4a2b124ea074a23","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                         \u0027Only enable this option if your LDAP server \u0027"},{"line_number":511,"context_line":"                         \u0027supports subtree deletion.\u0027),"},{"line_number":512,"context_line":"        cfg.StrOpt(\u0027query_scope\u0027, default\u003d\u0027one\u0027,"},{"line_number":513,"context_line":"                   help\u003d\u0027The LDAP scope for queries, this can be either \u0027"},{"line_number":514,"context_line":"                        \u0027\"one\" (onelevel/singleLevel) or \"sub\" \u0027"},{"line_number":515,"context_line":"                        \u0027(subtree/wholeSubtree).\u0027),"},{"line_number":516,"context_line":"        cfg.IntOpt(\u0027page_size\u0027, default\u003d0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_539f3850","line":513,"in_reply_to":"ba7be1f8_c789aa27","updated":"2015-02-24 08:06:52.000000000","message":"There is a chance for missing such things, so feel free to upload this patch and fixing it.","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"768700da8cc41c79377d4fc2d88c34e5f16e824f","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        cfg.BoolOpt(\u0027use_tls\u0027, default\u003dFalse,"},{"line_number":744,"context_line":"                    help\u003d\u0027Enable TLS for communicating with LDAP servers.\u0027),"},{"line_number":745,"context_line":"        cfg.StrOpt(\u0027tls_req_cert\u0027, default\u003d\u0027demand\u0027,"},{"line_number":746,"context_line":"                   choices\u003d[\u0027demand\u0027, \u0027never\u0027, \u0027allow\u0027]),"},{"line_number":747,"context_line":"        cfg.BoolOpt(\u0027use_pool\u0027, default\u003dFalse,"},{"line_number":748,"context_line":"                    help\u003d\u0027Enable LDAP connection pooling.\u0027),"},{"line_number":749,"context_line":"        cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_4bdb521b","line":746,"updated":"2015-02-20 19:10:03.000000000","message":"now this option has no help  :(  \nbut that\u0027s a separate issue, the help was awful before","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5f54eb2d50e4d9b1ce6a25f4e4bd80487b3674d3","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        cfg.BoolOpt(\u0027use_tls\u0027, default\u003dFalse,"},{"line_number":744,"context_line":"                    help\u003d\u0027Enable TLS for communicating with LDAP servers.\u0027),"},{"line_number":745,"context_line":"        cfg.StrOpt(\u0027tls_req_cert\u0027, default\u003d\u0027demand\u0027,"},{"line_number":746,"context_line":"                   choices\u003d[\u0027demand\u0027, \u0027never\u0027, \u0027allow\u0027]),"},{"line_number":747,"context_line":"        cfg.BoolOpt(\u0027use_pool\u0027, default\u003dFalse,"},{"line_number":748,"context_line":"                    help\u003d\u0027Enable LDAP connection pooling.\u0027),"},{"line_number":749,"context_line":"        cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ce44b076","line":746,"in_reply_to":"ba7be1f8_4bdb521b","updated":"2015-02-20 19:50:25.000000000","message":"agreed... I sat and stared trying to figure what to put here but couldn\u0027t think of anything useful, which is probably why the help text wasn\u0027t helpful before.","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c8aaa08c0e707432ebe2a8fb2d8a2e1d5379729a","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        cfg.StrOpt(\u0027idp_contact_type\u0027, default\u003d\u0027other\u0027,"},{"line_number":910,"context_line":"                   choices\u003d[\u0027technical\u0027, \u0027support\u0027, \u0027administrative\u0027,"},{"line_number":911,"context_line":"                            \u0027billing\u0027, \u0027other\u0027],"},{"line_number":912,"context_line":"                   help\u003d\u0027Contact type.\u0027),"},{"line_number":913,"context_line":"        cfg.StrOpt(\u0027idp_metadata_path\u0027,"},{"line_number":914,"context_line":"                   default\u003d\u0027/etc/keystone/saml2_idp_metadata.xml\u0027,"},{"line_number":915,"context_line":"                   help\u003d\u0027Path to the Identity Provider Metadata file. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_b66c2a9e","line":912,"updated":"2015-02-20 22:45:26.000000000","message":"this doesn\u0027t look helpful, maybe expound to something like \"Preferred contact type of contact person.\"? Something to consider for improvement","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a745ec044d9177821f79624a3c7be4a6737b07fd","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        cfg.StrOpt(\u0027idp_contact_type\u0027, default\u003d\u0027other\u0027,"},{"line_number":910,"context_line":"                   choices\u003d[\u0027technical\u0027, \u0027support\u0027, \u0027administrative\u0027,"},{"line_number":911,"context_line":"                            \u0027billing\u0027, \u0027other\u0027],"},{"line_number":912,"context_line":"                   help\u003d\u0027Contact type.\u0027),"},{"line_number":913,"context_line":"        cfg.StrOpt(\u0027idp_metadata_path\u0027,"},{"line_number":914,"context_line":"                   default\u003d\u0027/etc/keystone/saml2_idp_metadata.xml\u0027,"},{"line_number":915,"context_line":"                   help\u003d\u0027Path to the Identity Provider Metadata file. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_e051fbd9","line":912,"in_reply_to":"ba7be1f8_b66c2a9e","updated":"2015-03-03 15:55:16.000000000","message":"Done","commit_id":"fb3523842e222f3023440896e7f0ca6a39d2e7eb"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89db751852eda7bce5bb58ffd813207a6c89f31e","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                         \u0027Only enable this option if your LDAP server \u0027"},{"line_number":511,"context_line":"                         \u0027supports subtree deletion.\u0027),"},{"line_number":512,"context_line":"        cfg.StrOpt(\u0027query_scope\u0027, default\u003d\u0027one\u0027,"},{"line_number":513,"context_line":"                   choices\u003d[\u0027one\u0027, \u0027sub\u0027],"},{"line_number":514,"context_line":"                   help\u003d\u0027The LDAP scope for queries, \"one\" represents \u0027"},{"line_number":515,"context_line":"                        \u0027oneLevel/singleLevel and \"sub\" represents \u0027"},{"line_number":516,"context_line":"                        \u0027subtree/wholeSubtree options.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_09a47ba4","line":513,"updated":"2015-03-03 16:37:12.000000000","message":"Doesn\u0027t matter too much, but a tuple can be used here instead which is immutable.","commit_id":"d9d3bb528cc31c8891333af82d01e4a40097e3b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"51f472c65fc71e7aee45fac45a8258f129d2b05d","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                         \u0027Only enable this option if your LDAP server \u0027"},{"line_number":511,"context_line":"                         \u0027supports subtree deletion.\u0027),"},{"line_number":512,"context_line":"        cfg.StrOpt(\u0027query_scope\u0027, default\u003d\u0027one\u0027,"},{"line_number":513,"context_line":"                   choices\u003d[\u0027one\u0027, \u0027sub\u0027],"},{"line_number":514,"context_line":"                   help\u003d\u0027The LDAP scope for queries, \"one\" represents \u0027"},{"line_number":515,"context_line":"                        \u0027oneLevel/singleLevel and \"sub\" represents \u0027"},{"line_number":516,"context_line":"                        \u0027subtree/wholeSubtree options.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_811837d4","line":513,"in_reply_to":"ba7be1f8_09a47ba4","updated":"2015-03-03 20:06:27.000000000","message":"Done","commit_id":"d9d3bb528cc31c8891333af82d01e4a40097e3b7"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89db751852eda7bce5bb58ffd813207a6c89f31e","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        cfg.BoolOpt(\u0027use_tls\u0027, default\u003dFalse,"},{"line_number":745,"context_line":"                    help\u003d\u0027Enable TLS for communicating with LDAP servers.\u0027),"},{"line_number":746,"context_line":"        cfg.StrOpt(\u0027tls_req_cert\u0027, default\u003d\u0027demand\u0027,"},{"line_number":747,"context_line":"                   choices\u003d[\u0027demand\u0027, \u0027never\u0027, \u0027allow\u0027]),"},{"line_number":748,"context_line":"        cfg.BoolOpt(\u0027use_pool\u0027, default\u003dFalse,"},{"line_number":749,"context_line":"                    help\u003d\u0027Enable LDAP connection pooling.\u0027),"},{"line_number":750,"context_line":"        cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_e90e478b","line":747,"updated":"2015-03-03 16:37:12.000000000","message":"Can you add some help?  \n\nHow about?\n\"Specifies what checks to perform on client certificates in an incoming TLS session.\"\n\nReference: http://www.openldap.org/doc/admin24/tls.html","commit_id":"d9d3bb528cc31c8891333af82d01e4a40097e3b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"51f472c65fc71e7aee45fac45a8258f129d2b05d","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        cfg.BoolOpt(\u0027use_tls\u0027, default\u003dFalse,"},{"line_number":745,"context_line":"                    help\u003d\u0027Enable TLS for communicating with LDAP servers.\u0027),"},{"line_number":746,"context_line":"        cfg.StrOpt(\u0027tls_req_cert\u0027, default\u003d\u0027demand\u0027,"},{"line_number":747,"context_line":"                   choices\u003d[\u0027demand\u0027, \u0027never\u0027, \u0027allow\u0027]),"},{"line_number":748,"context_line":"        cfg.BoolOpt(\u0027use_pool\u0027, default\u003dFalse,"},{"line_number":749,"context_line":"                    help\u003d\u0027Enable LDAP connection pooling.\u0027),"},{"line_number":750,"context_line":"        cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_e1265315","line":747,"in_reply_to":"ba7be1f8_e90e478b","updated":"2015-03-03 20:06:27.000000000","message":"Done, nice catch.","commit_id":"d9d3bb528cc31c8891333af82d01e4a40097e3b7"}],"keystone/notifications.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"64325e490f8a99f85ef0e45a79cc8a1f35e616e5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027default_publisher_id\u0027,"},{"line_number":38,"context_line":"               help\u003d\u0027Default publisher_id for outgoing notifications\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027notification_format\u0027, default\u003d\u0027basic\u0027,"},{"line_number":40,"context_line":"               choices\u003d[\u0027basic\u0027, \u0027cadf\u0027],"},{"line_number":41,"context_line":"               help\u003d\u0027Define the notification format for Identity Service \u0027"},{"line_number":42,"context_line":"                    \u0027events. A \"basic\" notification has information about \u0027"},{"line_number":43,"context_line":"                    \u0027the resource being operated on. A \"cadf\" notification \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aaa499b_4d76c53f","line":40,"updated":"2015-04-10 18:42:28.000000000","message":"You can also use a tuple with is immutable, but no biggie.","commit_id":"23bf8c9cb764721032087def54c89190eed204b8"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a0fc1e83bd1a07c735e5519c87fbcc9ee2515af6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.StrOpt(\u0027default_publisher_id\u0027,"},{"line_number":38,"context_line":"               help\u003d\u0027Default publisher_id for outgoing notifications\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027notification_format\u0027, default\u003d\u0027basic\u0027,"},{"line_number":40,"context_line":"               choices\u003d[\u0027basic\u0027, \u0027cadf\u0027],"},{"line_number":41,"context_line":"               help\u003d\u0027Define the notification format for Identity Service \u0027"},{"line_number":42,"context_line":"                    \u0027events. A \"basic\" notification has information about \u0027"},{"line_number":43,"context_line":"                    \u0027the resource being operated on. A \"cadf\" notification \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aaa499b_45c57959","line":40,"in_reply_to":"7aaa499b_4d76c53f","updated":"2015-04-10 20:22:03.000000000","message":"Ah, interesting. I was wondering why that was. I can repush that with a new patch set if others have comments. Thanks Eric!","commit_id":"23bf8c9cb764721032087def54c89190eed204b8"}]}