)]}'
{"keystone/common/kvs/backends/memcached.py":[{"author":{"_account_id":14692,"name":"Lucas Fisher","email":"lucas.fisher@gmail.com","username":"lucas.fisher"},"change_message_id":"29edc4096688b9d317e00db2ad865c034eed3b5a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Keystone Memcached dogpile.cache backend implementation."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import random as _random"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dogpile.cache import api"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_2a58cd31","line":19,"updated":"2015-02-21 01:15:03.000000000","message":"how about:\n\n from random import SystemRandom as random\n\nThen get rid of the reassignment below.","commit_id":"2990953cd65b7deccfa48b54e4bb4c65480eb25e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6e7f946a006fbc7aeb3c7d9ac5b6f843961b9e2e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Keystone Memcached dogpile.cache backend implementation."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import random as _random"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dogpile.cache import api"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_79645349","line":19,"in_reply_to":"ba7be1f8_2a58cd31","updated":"2015-02-22 22:34:06.000000000","message":"OpenStack guidelines are to import only modules, see https://github.com/openstack-dev/hacking/blame/master/HACKING.rst#L44 . Also, I like the ranaming to _random because it will be an indicator that something \"different\" is happening and will hopefully convince others from using functions in _random.","commit_id":"2990953cd65b7deccfa48b54e4bb4c65480eb25e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e82f961e80f720037fb5dbe1e2014c375eced957","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Keystone Memcached dogpile.cache backend implementation."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import random as _random"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from dogpile.cache import api"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6bce4785","line":19,"in_reply_to":"ba7be1f8_2a58cd31","updated":"2015-02-21 07:58:59.000000000","message":"That doesn\u0027t really work since SystemRandom is a class and random is a module.  So you need to create an instance of SystemRandom.","commit_id":"2990953cd65b7deccfa48b54e4bb4c65480eb25e"}]}