)]}'
{"keystone/tests/unit/test_backend_sql.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"015b2afdff40cffae6e07a3daf383f8a68c128cb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return config_files"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_a38506d0","line":62,"updated":"2015-02-26 16:16:10.000000000","message":"I think oslotest.BaseTestCase should be inherited from","commit_id":"b0326e5db144a5fb0a19c89c92335db99459135e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"5947430b1ea3602a07ffd57a2404fb1325419456","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return config_files"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b933b960","line":62,"in_reply_to":"9a80dd14_28f7798c","updated":"2015-03-08 14:15:32.000000000","message":"If this class grows the need to the the additional fixtures then it can be changed. Unless a class is using all of the fixtures from BaseTestCase then it should not subclass it.","commit_id":"b0326e5db144a5fb0a19c89c92335db99459135e"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0ea6d8b0a8873488f3009295ccfca3916bf8d68e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return config_files"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_28f7798c","line":62,"in_reply_to":"9a80dd14_68a89177","updated":"2015-03-08 04:52:45.000000000","message":"Maybe \u0027OS_STDOUT_CAPTURE\u0027, \u0027OS_STDERR_CAPTURE\u0027or some EVN is set in oder to facilitate extra functionality end use needed?","commit_id":"b0326e5db144a5fb0a19c89c92335db99459135e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c94ba2cb67fd53eb61d98696fdfecaafe69854c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return config_files"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_68a89177","line":62,"in_reply_to":"9a80dd14_97c47941","updated":"2015-03-08 04:12:09.000000000","message":"I disagree. BaseTestCase has nothing I need and does extra setup that I don\u0027t. What would be the point in using it?","commit_id":"b0326e5db144a5fb0a19c89c92335db99459135e"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"69b4faa9e8deb70e6227ef5c0efc7f1603740561","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return config_files"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_97c47941","line":62,"in_reply_to":"ba7be1f8_a38506d0","updated":"2015-03-05 07:56:15.000000000","message":"++\n\noslotest.BaseTestCase provides more useful general usage.","commit_id":"b0326e5db144a5fb0a19c89c92335db99459135e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6a07a0cc028ea8225c7a302a146f38e2381b98dd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return config_files"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_087103e0","line":62,"updated":"2015-03-25 14:06:55.000000000","message":"all keystone unit tests should use a common base test class so that we can have common setup for all keystone tests.","commit_id":"73a65520b3e17c65e519f286dfb98c42faa9dba5"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"ad3f956bb31e5b7804cb617b68c493bd6904264d","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class SqlModels(testtools.TestCase):"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(SqlModels, self).setUp()"},{"line_number":66,"context_line":"        self.useFixture(database.Database())"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ab451fb_7f746efc","line":63,"updated":"2015-04-17 14:03:25.000000000","message":"I agree.  Instead of going straight to the top like this, perhaps the hierarchy can be altered so that the shared set up - the fixture use etc is pushed up into a super that SqlTests can share as a parent?","commit_id":"73a65520b3e17c65e519f286dfb98c42faa9dba5"}]}