)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"535c9d4be5b388357423ab6af9563996d37c5a2b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch wires up the underlying support for SQL based"},{"line_number":10,"context_line":"domain specific configuration to the identity manager, enabling"},{"line_number":11,"context_line":"it use."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially Implements: blueprint domain-config-ext"},{"line_number":14,"context_line":"Change-Id: I39ecf5efd9aed03a79de9c882cfd466ab5732ab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba7be1f8_6fb89711","line":11,"updated":"2015-03-03 17:00:14.000000000","message":"s/it/its ?","commit_id":"101cfd6e0ec90ae651f1eec3e59b10fe740bec2c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c035da5f37c1f6d3df9527acdf4357d0419c68ae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch wires up the underlying support for SQL based"},{"line_number":10,"context_line":"domain specific configuration to the identity manager, enabling"},{"line_number":11,"context_line":"it use."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially Implements: blueprint domain-config-ext"},{"line_number":14,"context_line":"Change-Id: I39ecf5efd9aed03a79de9c882cfd466ab5732ab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba7be1f8_1b111952","line":11,"in_reply_to":"ba7be1f8_6fb89711","updated":"2015-03-03 18:13:24.000000000","message":"Done","commit_id":"101cfd6e0ec90ae651f1eec3e59b10fe740bec2c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch wires up the underlying support for SQL based"},{"line_number":10,"context_line":"domain specific configuration to the identity manager, enabling"},{"line_number":11,"context_line":"its use. It is also includes a check to ensure that this"},{"line_number":12,"context_line":"capability is disabled by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partially Implements: blueprint domain-config-ext"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"9a80dd14_9a96e33d","line":11,"updated":"2015-03-09 14:41:20.000000000","message":"change \"It is also\" to \"It also\"","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch wires up the underlying support for SQL based"},{"line_number":10,"context_line":"domain specific configuration to the identity manager, enabling"},{"line_number":11,"context_line":"its use. It is also includes a check to ensure that this"},{"line_number":12,"context_line":"capability is disabled by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partially Implements: blueprint domain-config-ext"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"9a80dd14_a1a7d6bb","line":11,"in_reply_to":"9a80dd14_9a96e33d","updated":"2015-03-10 00:17:28.000000000","message":"Done","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"}],"keystone/identity/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"286754a77e11d1956a7a1497c12572ece5b9f58f","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":196,"context_line":"        self._assert_no_more_than_one_sql_driver(domain_id, domain_config)"},{"line_number":197,"context_line":"        self[domain_id] \u003d domain_config"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _setup_domain_drivers_from_database(self, standard_driver,"},{"line_number":200,"context_line":"                                            resource_api):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_5ff9dd7e","line":197,"updated":"2015-03-03 08:02:12.000000000","message":"this assignment seems strange","commit_id":"495c187994b1e17edb07e97fe3a4abbc6550c43c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8deb88699147423da5f645d9b5ae8ec8f56e1e2e","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":196,"context_line":"        self._assert_no_more_than_one_sql_driver(domain_id, domain_config)"},{"line_number":197,"context_line":"        self[domain_id] \u003d domain_config"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _setup_domain_drivers_from_database(self, standard_driver,"},{"line_number":200,"context_line":"                                            resource_api):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba7be1f8_26adece9","line":197,"in_reply_to":"ba7be1f8_5ff9dd7e","updated":"2015-03-03 18:13:15.000000000","message":"It\u0027s how the original (file based version) is done....basically just mean you can index this object directly by domain_id and get the domain_config structure for your driver...","commit_id":"495c187994b1e17edb07e97fe3a4abbc6550c43c"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"535c9d4be5b388357423ab6af9563996d37c5a2b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        defined, and for those that do we:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        - Create a new config structure, overriding any specific additional"},{"line_number":208,"context_line":"          options defined in this config file"},{"line_number":209,"context_line":"        - Initialise a new instance of the required driver with this new config"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_afefef1c","line":208,"updated":"2015-03-03 17:00:14.000000000","message":"\u0027config file\u0027 is not valid here, then please replace it.\nMaybe s/database config/config file","commit_id":"101cfd6e0ec90ae651f1eec3e59b10fe740bec2c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"c035da5f37c1f6d3df9527acdf4357d0419c68ae","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        defined, and for those that do we:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        - Create a new config structure, overriding any specific additional"},{"line_number":208,"context_line":"          options defined in this config file"},{"line_number":209,"context_line":"        - Initialise a new instance of the required driver with this new config"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba7be1f8_a037fcfd","line":208,"in_reply_to":"ba7be1f8_afefef1c","updated":"2015-03-03 18:13:24.000000000","message":"oops, good catch!!","commit_id":"101cfd6e0ec90ae651f1eec3e59b10fe740bec2c"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"9089ffa22258f562ba9d45bdbb0c888db5b2a103","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                            resource_api):"},{"line_number":201,"context_line":"        \"\"\"Read domain specific configuration from database and load drivers."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        Domain configuration files are stored in the domain-config backend,"},{"line_number":204,"context_line":"        so we go through each domain to find those that have a specific config"},{"line_number":205,"context_line":"        defined, and for those that do we:"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9a80dd14_65a29d9a","line":203,"updated":"2015-03-06 15:38:22.000000000","message":"Why are you talking about \"files\" in this docstring? This is only for database, isn\u0027t it?","commit_id":"0cc44ef7fba95576068cf8dd92dea6d8313f6318"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"536b713430ce80d39e630c31b132a8625515368c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                            resource_api):"},{"line_number":201,"context_line":"        \"\"\"Read domain specific configuration from database and load drivers."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        Domain configuration files are stored in the domain-config backend,"},{"line_number":204,"context_line":"        so we go through each domain to find those that have a specific config"},{"line_number":205,"context_line":"        defined, and for those that do we:"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9a80dd14_7cc6a69b","line":203,"in_reply_to":"9a80dd14_65a29d9a","updated":"2015-03-06 20:37:42.000000000","message":"oops, good catch..a bit too liberal in my copy \u0026 paste :-)","commit_id":"0cc44ef7fba95576068cf8dd92dea6d8313f6318"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":141,"context_line":"        self._assert_no_more_than_one_sql_driver(domain_ref[\u0027id\u0027],"},{"line_number":142,"context_line":"                                                 domain_config,"},{"line_number":143,"context_line":"                                                 config_file\u003dfile_list)"},{"line_number":144,"context_line":"        self[domain_ref[\u0027id\u0027]] \u003d domain_config"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _setup_domain_drivers_from_files(self, standard_driver, resource_api):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_facb5f50","line":143,"updated":"2015-03-09 14:41:20.000000000","message":"is config_file supposed to be a single file rather than a list? Otherwise, why not call the parameter file_list?","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":141,"context_line":"        self._assert_no_more_than_one_sql_driver(domain_ref[\u0027id\u0027],"},{"line_number":142,"context_line":"                                                 domain_config,"},{"line_number":143,"context_line":"                                                 config_file\u003dfile_list)"},{"line_number":144,"context_line":"        self[domain_ref[\u0027id\u0027]] \u003d domain_config"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _setup_domain_drivers_from_files(self, standard_driver, resource_api):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_c4921d4b","line":143,"in_reply_to":"9a80dd14_33b98179","updated":"2015-03-10 00:17:28.000000000","message":"So it is a single file....the existing parameter is poorly named. Since this is passed into this existing method, changing it would be outside the scope of this patch.  I\u0027d be happy to tidy this up in a follow on patch","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"12724f536e5968de785d968e36da9cd98947460c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":141,"context_line":"        self._assert_no_more_than_one_sql_driver(domain_ref[\u0027id\u0027],"},{"line_number":142,"context_line":"                                                 domain_config,"},{"line_number":143,"context_line":"                                                 config_file\u003dfile_list)"},{"line_number":144,"context_line":"        self[domain_ref[\u0027id\u0027]] \u003d domain_config"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _setup_domain_drivers_from_files(self, standard_driver, resource_api):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_33b98179","line":143,"in_reply_to":"9a80dd14_facb5f50","updated":"2015-03-09 21:09:03.000000000","message":"++ maybe \"config_files_list\"","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        config.configure(conf\u003ddomain_config[\u0027cfg\u0027])"},{"line_number":186,"context_line":"        domain_config[\u0027cfg\u0027](args\u003d[], project\u003d\u0027keystone\u0027)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # Override and options that have been passed in as specified in the"},{"line_number":189,"context_line":"        # database."},{"line_number":190,"context_line":"        for group in specific_config:"},{"line_number":191,"context_line":"            for option in specific_config[group]:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_5abf0baa","line":188,"updated":"2015-03-09 14:41:20.000000000","message":"change \"and options\" to \"any options\"","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        config.configure(conf\u003ddomain_config[\u0027cfg\u0027])"},{"line_number":186,"context_line":"        domain_config[\u0027cfg\u0027](args\u003d[], project\u003d\u0027keystone\u0027)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # Override and options that have been passed in as specified in the"},{"line_number":189,"context_line":"        # database."},{"line_number":190,"context_line":"        for group in specific_config:"},{"line_number":191,"context_line":"            for option in specific_config[group]:"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_249cd95c","line":188,"in_reply_to":"9a80dd14_5abf0baa","updated":"2015-03-10 00:17:28.000000000","message":"Done","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"}],"keystone/tests/unit/identity/test_core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        res \u003d domain_config.get_domain_conf(domain[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(conf[\u0027ldap\u0027][\u0027url\u0027], res.ldap.url)"},{"line_number":109,"context_line":"        self.assertEqual(conf[\u0027ldap\u0027][\u0027suffix\u0027], res.ldap.suffix)"},{"line_number":110,"context_line":"        self.assertEqual(CONF.ldap.query_scope, res.ldap.query_scope)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_faf99f80","line":110,"updated":"2015-03-09 14:41:20.000000000","message":"There should be a test to show what happens when \u0027domain_configurations_from_database\u0027\u003dFalse and you try to use it.\n\nThere should be a test for if a config option is the wrong type or has an invalid value.","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"12724f536e5968de785d968e36da9cd98947460c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        res \u003d domain_config.get_domain_conf(domain[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(conf[\u0027ldap\u0027][\u0027url\u0027], res.ldap.url)"},{"line_number":109,"context_line":"        self.assertEqual(conf[\u0027ldap\u0027][\u0027suffix\u0027], res.ldap.suffix)"},{"line_number":110,"context_line":"        self.assertEqual(CONF.ldap.query_scope, res.ldap.query_scope)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_3370a1db","line":110,"in_reply_to":"9a80dd14_faf99f80","updated":"2015-03-09 21:09:03.000000000","message":"++","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        res \u003d domain_config.get_domain_conf(domain[\u0027id\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(conf[\u0027ldap\u0027][\u0027url\u0027], res.ldap.url)"},{"line_number":109,"context_line":"        self.assertEqual(conf[\u0027ldap\u0027][\u0027suffix\u0027], res.ldap.suffix)"},{"line_number":110,"context_line":"        self.assertEqual(CONF.ldap.query_scope, res.ldap.query_scope)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_81a492ba","line":110,"in_reply_to":"9a80dd14_faf99f80","updated":"2015-03-10 00:17:28.000000000","message":"So the first part has been added.  With respect to what happens if someone writs an invalid value to an option, this is currently not checked.  I think this is indeed a fair point - and if done anywhere should be done in the domain_config create/update manager calls (so below this level of this patch).  I\u0027ll raise a separate defect for that.","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"0c322864b5c38244f7f05ed8f187ddc9edd85fe8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.load_backends()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":92,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_loading_config_from_database(self):"},{"line_number":95,"context_line":"        CONF.set_override(\u0027domain_configurations_from_database\u0027, True,"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a80dd14_7c30f39e","line":92,"updated":"2015-03-10 19:16:07.000000000","message":"Not sufficeint","commit_id":"6e499b538a24a9c2bb76eed51f96c1655824591d"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"be59d40e79e03ec1613f58271028de9ff4c213dc","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.load_backends()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":92,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_loading_config_from_database(self):"},{"line_number":95,"context_line":"        CONF.set_override(\u0027domain_configurations_from_database\u0027, True,"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a80dd14_d352aa67","line":92,"in_reply_to":"9a80dd14_0d5423c9","updated":"2015-03-10 21:30:43.000000000","message":"Good to go!","commit_id":"6e499b538a24a9c2bb76eed51f96c1655824591d"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8eaf74babfe7e37195c3aa733f82ede082a78b60","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.load_backends()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":92,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_loading_config_from_database(self):"},{"line_number":95,"context_line":"        CONF.set_override(\u0027domain_configurations_from_database\u0027, True,"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a80dd14_0d5423c9","line":92,"in_reply_to":"9a80dd14_7c30f39e","updated":"2015-03-10 20:20:52.000000000","message":"agree that is not sufficient, which is why the test below and the one in test_backend_ldap exist to check in more detail","commit_id":"6e499b538a24a9c2bb76eed51f96c1655824591d"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"be59d40e79e03ec1613f58271028de9ff4c213dc","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                          \u0027identity\u0027)"},{"line_number":119,"context_line":"        domain_config \u003d identity.DomainConfigs()"},{"line_number":120,"context_line":"        domain_config.setup_domain_drivers(fake_standard_driver,"},{"line_number":121,"context_line":"                                           self.resource_api)"},{"line_number":122,"context_line":"        res \u003d domain_config.get_domain_conf(domain[\u0027id\u0027])"},{"line_number":123,"context_line":"        self.assertEqual(CONF.ldap.url, res.ldap.url)"},{"line_number":124,"context_line":"        self.assertEqual(CONF.ldap.suffix, res.ldap.suffix)"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a80dd14_b371b6e2","line":121,"updated":"2015-03-10 21:30:43.000000000","message":"I think you swapped expected and actual on these tests.","commit_id":"6e499b538a24a9c2bb76eed51f96c1655824591d"}],"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":3726,"context_line":"        # If the previous line didn\u0027t raise an exception then the test passes."},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":3729,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":3730,"context_line":""},{"line_number":3731,"context_line":""},{"line_number":3732,"context_line":"class TokenTests(object):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_3af09790","line":3729,"updated":"2015-03-09 14:41:20.000000000","message":"this doesn\u0027t depend on the backend at all... this is a config test not a backend test.","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"12724f536e5968de785d968e36da9cd98947460c","unresolved":false,"context_lines":[{"line_number":3726,"context_line":"        # If the previous line didn\u0027t raise an exception then the test passes."},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":3729,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":3730,"context_line":""},{"line_number":3731,"context_line":""},{"line_number":3732,"context_line":"class TokenTests(object):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_735cd94b","line":3729,"in_reply_to":"9a80dd14_3af09790","updated":"2015-03-09 21:09:03.000000000","message":"++\n\nin the test_backend should be a test to verify if the multiple sql backends exception is being raised","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":3726,"context_line":"        # If the previous line didn\u0027t raise an exception then the test passes."},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":3729,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":3730,"context_line":""},{"line_number":3731,"context_line":""},{"line_number":3732,"context_line":"class TokenTests(object):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_1ea1dd93","line":3729,"in_reply_to":"9a80dd14_3af09790","updated":"2015-03-10 00:17:28.000000000","message":"Agreed.  This should be removed","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":3726,"context_line":"        # If the previous line didn\u0027t raise an exception then the test passes."},{"line_number":3727,"context_line":""},{"line_number":3728,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":3729,"context_line":"        self.assertFalse(CONF.identity.domain_configurations_from_database)"},{"line_number":3730,"context_line":""},{"line_number":3731,"context_line":""},{"line_number":3732,"context_line":"class TokenTests(object):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_beaff17b","line":3729,"in_reply_to":"9a80dd14_735cd94b","updated":"2015-03-10 00:17:28.000000000","message":"we already have a test for that in test_backend_ldap","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"        self.users[\u0027userC\u0027] \u003d self.create_user("},{"line_number":2544,"context_line":"            self.domains[\u0027domain3\u0027][\u0027id\u0027])"},{"line_number":2545,"context_line":""},{"line_number":2546,"context_line":"    def enable_multi_domain(self):"},{"line_number":2547,"context_line":"        self.config_fixture.config("},{"line_number":2548,"context_line":"            group\u003d\u0027identity\u0027, domain_specific_drivers_enabled\u003dTrue,"},{"line_number":2549,"context_line":"            domain_config_dir\u003dtests.TESTCONF + \u0027/domain_configs_multi_ldap\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_9a32635d","line":2546,"updated":"2015-03-09 14:41:20.000000000","message":"add a docstring that says that subclasses should override this.","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"098ecae6188c92b0f2feb8db6ee50555ec7ac430","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"        self.users[\u0027userC\u0027] \u003d self.create_user("},{"line_number":2544,"context_line":"            self.domains[\u0027domain3\u0027][\u0027id\u0027])"},{"line_number":2545,"context_line":""},{"line_number":2546,"context_line":"    def enable_multi_domain(self):"},{"line_number":2547,"context_line":"        self.config_fixture.config("},{"line_number":2548,"context_line":"            group\u003d\u0027identity\u0027, domain_specific_drivers_enabled\u003dTrue,"},{"line_number":2549,"context_line":"            domain_config_dir\u003dtests.TESTCONF + \u0027/domain_configs_multi_ldap\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_fecc096c","line":2546,"in_reply_to":"9a80dd14_9a32635d","updated":"2015-03-10 00:17:28.000000000","message":"Done","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ede022219cff995dce39e1adc90dbcc211bd8ae5","unresolved":false,"context_lines":[{"line_number":2815,"context_line":"                                   backward_compatible_ids\u003dFalse)"},{"line_number":2816,"context_line":""},{"line_number":2817,"context_line":"    def test_domain_config_in_database_disabled_by_default(self):"},{"line_number":2818,"context_line":"        self.assertTrue(CONF.identity.domain_configurations_from_database)"},{"line_number":2819,"context_line":""},{"line_number":2820,"context_line":""},{"line_number":2821,"context_line":"class DomainSpecificLDAPandSQLIdentity("}],"source_content_type":"text/x-python","patch_set":29,"id":"9a80dd14_ba33a760","line":2818,"updated":"2015-03-09 14:41:20.000000000","message":"this is asserting that the config is enabled... where the test says it should assert it\u0027s disabled.","commit_id":"be9503dc49c6fc4f75bca8a6e7707f5a42343c1f"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"c6c6f880d14d268db8a5e68e038182e7f133ce08","unresolved":false,"context_lines":[{"line_number":2546,"context_line":"    def enable_multi_domain(self):"},{"line_number":2547,"context_line":"        \"\"\"Enable the chosen form of multi domain configuration support."},{"line_number":2548,"context_line":""},{"line_number":2549,"context_line":"        This method enables the file-based configration support. Child classes"},{"line_number":2550,"context_line":"        that wish to use the database domain configuration support should"},{"line_number":2551,"context_line":"        override this method and set the appropriate config_fixture option."},{"line_number":2552,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"9a80dd14_2743e4af","line":2549,"updated":"2015-03-10 10:54:45.000000000","message":"(nit) s/configration/configuration","commit_id":"99862781e962c7c8195c1f4d1ac6e67b06f9aa59"}]}