)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"cbf907ae5da483defc51a4b90cb3220148103302","unresolved":false,"context_lines":[{"line_number":11,"context_line":"installation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For existing installation, this is not enough and other"},{"line_number":14,"context_line":"action are requested."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id68c3f307f53b6a4de011e2608d899d044aced68"},{"line_number":17,"context_line":"Closes-Bug: 1426334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_aac68f14","line":14,"updated":"2015-02-27 11:51:47.000000000","message":"What actions? Will there be a follow-up for them?","commit_id":"726702398d599dc791cbb60d1e44e1d40be5b91d"},{"author":{"_account_id":10335,"name":"Marco Fargetta","email":"marco.fargetta@ct.infn.it","username":"fmarco76"},"change_message_id":"44b3b074af69630c5cde102a1949eab3438d8488","unresolved":false,"context_lines":[{"line_number":11,"context_line":"installation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For existing installation, this is not enough and other"},{"line_number":14,"context_line":"action are requested."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id68c3f307f53b6a4de011e2608d899d044aced68"},{"line_number":17,"context_line":"Closes-Bug: 1426334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_2d71d977","line":14,"in_reply_to":"ba7be1f8_aac68f14","updated":"2015-02-27 12:03:27.000000000","message":"Changes in the migration script will fix the table for new installation. If the db already exist this will not work and since the error arise before any other migration script I do not know if it is possible to fix with code or some advice in the documentation or other.","commit_id":"726702398d599dc791cbb60d1e44e1d40be5b91d"}],"keystone/common/sql/migration_helpers.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b44a9c186a16802f6ec0374e14fe06e0779726a5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            raise"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def _fix_federation_tables(fix_engine):"},{"line_number":184,"context_line":"    meta \u003d sqlalchemy.MetaData()"},{"line_number":185,"context_line":"    meta.bind \u003d fix_engine"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_b532dc5b","line":183,"updated":"2015-03-03 17:44:30.000000000","message":"I want a lot of documentation added here as to what is going on, why this is needed, the bug it is fixing. Look at the comment on line 166 and docstring in 142.\n\nI also want a clear identification of how we got wedged again in this situation so we can either go to the oslo.db team and ask \"why is this happening\" and/or fix this in our code.\n\nThis should *never* happen again.","commit_id":"60120d4f20e5ce92cd7f93781e3ea8068bcd1795"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d173c09f33eefb136f386a1a0542d396cd4821b5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            raise"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"def _fix_federation_tables(fix_engine):"},{"line_number":184,"context_line":"    meta \u003d sqlalchemy.MetaData()"},{"line_number":185,"context_line":"    meta.bind \u003d fix_engine"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_a0329ca4","line":183,"updated":"2015-03-03 17:55:00.000000000","message":"Docstring (like the _fix migration 37) still needed explaining this.","commit_id":"59fad71fbef9d505a5452b1d74958a0f7e42c93f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d173c09f33eefb136f386a1a0542d396cd4821b5","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    try:"},{"line_number":288,"context_line":"        migration.db_sync(sql.get_engine(), abs_path, version\u003dversion,"},{"line_number":289,"context_line":"                          init_version\u003dinit_version)"},{"line_number":290,"context_line":"    except ValueError:"},{"line_number":291,"context_line":"        _fix_federation_tables(sql.get_engine())"},{"line_number":292,"context_line":"        migration.db_sync(sql.get_engine(), abs_path, version\u003dversion,"},{"line_number":293,"context_line":"                          init_version\u003dinit_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_601424e9","line":290,"updated":"2015-03-03 17:55:00.000000000","message":"Comment like the fix for 37 also needed here.","commit_id":"59fad71fbef9d505a5452b1d74958a0f7e42c93f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"113e149816fd9cba50d6132d1a9fe4d77e8c0c97","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # was initially created. Bug #1426334 is a scenario where the deployer"},{"line_number":243,"context_line":"        # can get wedged, unable to upgrade or downgrade."},{"line_number":244,"context_line":"        # This is a workaround to \"fix\" that table if we\u0027re under MySQL."},{"line_number":245,"context_line":"        _fix_federation_tables(engine)"},{"line_number":246,"context_line":"        # The migration is applied again after the fix"},{"line_number":247,"context_line":"        migration.db_sync(engine, abs_path, version\u003dversion,"},{"line_number":248,"context_line":"                          init_version\u003dinit_version)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_c021a0fc","line":245,"updated":"2015-03-05 21:22:21.000000000","message":"Minor change needed here, but we need to ensure that the table is only the version that would have this issue, we don;t want this to run down the line now that it\u0027s been fixed. \n\nSo this should only be able to occur at migration 2 for this table? otherwise it should be fixed and/or never had the issue. See line 173 for an example of this.","commit_id":"7ed911f871ae969bcca317a6576fecb53208848a"},{"author":{"_account_id":10335,"name":"Marco Fargetta","email":"marco.fargetta@ct.infn.it","username":"fmarco76"},"change_message_id":"c3b6fa03778e630b7a3a7efcfc8416504d7ed69d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # was initially created. Bug #1426334 is a scenario where the deployer"},{"line_number":243,"context_line":"        # can get wedged, unable to upgrade or downgrade."},{"line_number":244,"context_line":"        # This is a workaround to \"fix\" that table if we\u0027re under MySQL."},{"line_number":245,"context_line":"        _fix_federation_tables(engine)"},{"line_number":246,"context_line":"        # The migration is applied again after the fix"},{"line_number":247,"context_line":"        migration.db_sync(engine, abs_path, version\u003dversion,"},{"line_number":248,"context_line":"                          init_version\u003dinit_version)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_06af3495","line":245,"in_reply_to":"9a80dd14_c021a0fc","updated":"2015-03-06 11:30:55.000000000","message":"Actually, it could be from migration 2 to 5 so I converted in int and considered version previous than 6. Is ok the conversion or it use possible in the future to use not numeri string?","commit_id":"7ed911f871ae969bcca317a6576fecb53208848a"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"48d30c8c8659a1e59c88e9b74112fed7dc2cef11","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    except exception.MigrationNotProvided as e:"},{"line_number":232,"context_line":"        print(e)"},{"line_number":233,"context_line":"        sys.exit(1)"},{"line_number":234,"context_line":"    try:"},{"line_number":235,"context_line":"        migration.db_sync(engine, abs_path, version\u003dversion,"},{"line_number":236,"context_line":"                          init_version\u003dinit_version)"},{"line_number":237,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_e89ad86c","line":234,"updated":"2015-03-06 19:09:59.000000000","message":"This change should be in the Federation migration code, not here.","commit_id":"6dc62fe2899d543e87e635e1c2205b456e400a03"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d02695adeb746108c5c5097f2dc3fcd93a198c46","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    except exception.MigrationNotProvided as e:"},{"line_number":232,"context_line":"        print(e)"},{"line_number":233,"context_line":"        sys.exit(1)"},{"line_number":234,"context_line":"    try:"},{"line_number":235,"context_line":"        migration.db_sync(engine, abs_path, version\u003dversion,"},{"line_number":236,"context_line":"                          init_version\u003dinit_version)"},{"line_number":237,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a80dd14_e801f806","line":234,"in_reply_to":"9a80dd14_e89ad86c","updated":"2015-03-06 19:21:31.000000000","message":"The code can\u0027t go in the migrations, this is because the migration wont work if innodb and utf8 aren\u0027t set (enforced from oslo.db level). There is abug against oslo.db (see below comment) on this. but we still need to fix our current deployers.\n\n\nThis is the same as migration 37 (above) ~line 167","commit_id":"6dc62fe2899d543e87e635e1c2205b456e400a03"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c455c4f05c994b520f2eaf86278e8ba21b42ba9","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # performs verification that tables are in a known state such as"},{"line_number":160,"context_line":"        # utf8 under mysql). If the ValueError is hit and a fix function has"},{"line_number":161,"context_line":"        # been defined in the repository for the version and the engine, run"},{"line_number":162,"context_line":"        # the fix function. Once the fix fn is run, re-run the migration."},{"line_number":163,"context_line":"        curr_version \u003d six.text_type(get_db_version())"},{"line_number":164,"context_line":"        fix_fn \u003d _get_fix_sanity_check_fn(curr_version, migrate_repo, engine)"},{"line_number":165,"context_line":"        # NOTE(morganfainberg): if `version_at` is not None, it signals that"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_c241bf0c","line":162,"updated":"2015-03-11 21:05:00.000000000","message":"function*","commit_id":"a4841afc8f0b29149e695bbb16da23fd485b4ecd"}],"keystone/contrib/federation/migrate_repo/versions/006_convert_tables_utf8.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"cf1cab84459da78e643ee5f52eeeeedc5ae7fb59","unresolved":false,"context_lines":[{"line_number":16,"context_line":"def upgrade(migrate_engine):"},{"line_number":17,"context_line":"    meta \u003d sql.MetaData()"},{"line_number":18,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    idp_table_temp \u003d sql.Table("},{"line_number":21,"context_line":"        \u0027identity_provider\u0027,"},{"line_number":22,"context_line":"        meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_5a662fbc","line":19,"updated":"2015-03-03 17:20:46.000000000","message":"can you extract this to a private method? There is some examples (like in the 044 migration script in the keystone/common/sql) that does a similar thing.","commit_id":"a55021e62b840e6f2d1d4bee6d26df57295b08eb"}]}