)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9729,"name":"Ioram Schechtman Sette","email":"iss@cin.ufpe.br","username":"Ioram7"},"change_message_id":"7a3e6f9ba4c7da3ac84588558725ca407d2c20be","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add oauth and federation authentication to config file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the oauth1, saml2 and oidc methods as default authentication"},{"line_number":10,"context_line":"schemes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2e90bc0ac95698ae79df253c6af8a3c26e7287f8"},{"line_number":13,"context_line":"Closes-bug: 1427509"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_e3d172fc","line":10,"updated":"2015-03-05 11:08:49.000000000","message":"include abfab","commit_id":"b89488b25b46d65e5c1cacd417e508e90ca10351"}],"keystone/common/config.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3e7ac95a2b4395a7d8949919c00c75c90dffa12f","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_DEFAULT_AUTH_METHODS \u003d [\u0027external\u0027, \u0027password\u0027, \u0027token\u0027,"},{"line_number":20,"context_line":"                         \u0027saml2\u0027, \u0027oidc\u0027, \u0027oauth1\u0027]"},{"line_number":21,"context_line":"_CERTFILE \u003d \u0027/etc/keystone/ssl/certs/signing_cert.pem\u0027"},{"line_number":22,"context_line":"_KEYFILE \u003d \u0027/etc/keystone/ssl/private/signing_key.pem\u0027"},{"line_number":23,"context_line":"_SSO_CALLBACK \u003d \u0027/etc/keystone/sso_callback_template.html\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ecb0a3df","line":20,"updated":"2015-03-04 20:12:46.000000000","message":"i\u0027m wondering if we should set these by default.","commit_id":"b89488b25b46d65e5c1cacd417e508e90ca10351"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"b5145e9df737d0bffff8b364213bb61f5ce04cab","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_DEFAULT_AUTH_METHODS \u003d [\u0027external\u0027, \u0027password\u0027, \u0027token\u0027,"},{"line_number":20,"context_line":"                         \u0027saml2\u0027, \u0027oidc\u0027, \u0027oauth1\u0027]"},{"line_number":21,"context_line":"_CERTFILE \u003d \u0027/etc/keystone/ssl/certs/signing_cert.pem\u0027"},{"line_number":22,"context_line":"_KEYFILE \u003d \u0027/etc/keystone/ssl/private/signing_key.pem\u0027"},{"line_number":23,"context_line":"_SSO_CALLBACK \u003d \u0027/etc/keystone/sso_callback_template.html\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_ef2079b2","line":20,"in_reply_to":"9a80dd14_ecb0a3df","updated":"2015-03-05 09:49:59.000000000","message":"I\u0027ll remove the methods that require some modifications of the Apache config.","commit_id":"b89488b25b46d65e5c1cacd417e508e90ca10351"},{"author":{"_account_id":9729,"name":"Ioram Schechtman Sette","email":"iss@cin.ufpe.br","username":"Ioram7"},"change_message_id":"7a3e6f9ba4c7da3ac84588558725ca407d2c20be","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                   help\u003d\u0027The SAML2 auth plugin module.\u0027),"},{"line_number":838,"context_line":"        cfg.StrOpt(\u0027oidc\u0027,"},{"line_number":839,"context_line":"                   default\u003d\u0027keystone.auth.plugins.mapped.Mapped\u0027,"},{"line_number":840,"context_line":"                   help\u003d\u0027The OpenID Connect auth plugin module.\u0027),"},{"line_number":841,"context_line":"        cfg.StrOpt(\u0027oauth1\u0027,"},{"line_number":842,"context_line":"                   default\u003d\u0027keystone.auth.plugins.oauth1.OAuth\u0027,"},{"line_number":843,"context_line":"                   help\u003d\u0027The oAuth1 auth plugin module.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_63a2e2af","line":840,"updated":"2015-03-05 11:08:49.000000000","message":"cfg.StrOpt(\u0027abfab\u0027,\n\t\t\tdefault\u003d\u0027keystone.auth.plugins.mapped.Mapped\u0027,\n\t\t\thelp\u003d\u0027The ABFAB auth plugin module.\u0027),","commit_id":"b89488b25b46d65e5c1cacd417e508e90ca10351"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3e7ac95a2b4395a7d8949919c00c75c90dffa12f","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                   help\u003d\u0027The OpenID Connect auth plugin module.\u0027),"},{"line_number":841,"context_line":"        cfg.StrOpt(\u0027oauth1\u0027,"},{"line_number":842,"context_line":"                   default\u003d\u0027keystone.auth.plugins.oauth1.OAuth\u0027,"},{"line_number":843,"context_line":"                   help\u003d\u0027The oAuth1 auth plugin module.\u0027),"},{"line_number":844,"context_line":"    ],"},{"line_number":845,"context_line":"    \u0027paste_deploy\u0027: ["},{"line_number":846,"context_line":"        cfg.StrOpt(\u0027config_file\u0027, default\u003d\u0027keystone-paste.ini\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_cc94bf39","line":843,"updated":"2015-03-04 20:12:46.000000000","message":"nit: s/oAuth1/OAuth1.0","commit_id":"b89488b25b46d65e5c1cacd417e508e90ca10351"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"b5145e9df737d0bffff8b364213bb61f5ce04cab","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                   help\u003d\u0027The OpenID Connect auth plugin module.\u0027),"},{"line_number":841,"context_line":"        cfg.StrOpt(\u0027oauth1\u0027,"},{"line_number":842,"context_line":"                   default\u003d\u0027keystone.auth.plugins.oauth1.OAuth\u0027,"},{"line_number":843,"context_line":"                   help\u003d\u0027The oAuth1 auth plugin module.\u0027),"},{"line_number":844,"context_line":"    ],"},{"line_number":845,"context_line":"    \u0027paste_deploy\u0027: ["},{"line_number":846,"context_line":"        cfg.StrOpt(\u0027config_file\u0027, default\u003d\u0027keystone-paste.ini\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_af168153","line":843,"in_reply_to":"9a80dd14_cc94bf39","updated":"2015-03-05 09:49:59.000000000","message":"Done","commit_id":"b89488b25b46d65e5c1cacd417e508e90ca10351"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c4b676eca8d6ac2a4e8a8fda5dd7178d934148e2","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                   help\u003d\u0027The OpenID Connect auth plugin module.\u0027),"},{"line_number":840,"context_line":"        cfg.StrOpt(\u0027oauth1\u0027,"},{"line_number":841,"context_line":"                   default\u003d\u0027keystone.auth.plugins.oauth1.OAuth\u0027,"},{"line_number":842,"context_line":"                   help\u003d\u0027The oAuth1 auth plugin module.\u0027),"},{"line_number":843,"context_line":"    ],"},{"line_number":844,"context_line":"    \u0027paste_deploy\u0027: ["},{"line_number":845,"context_line":"        cfg.StrOpt(\u0027config_file\u0027, default\u003d\u0027keystone-paste.ini\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_95d19159","line":842,"updated":"2015-03-06 08:37:29.000000000","message":"s/oAuth1/OAuth 1.0","commit_id":"969b106f46ea93eaa547327648d8a62ce8a90b27"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c4b676eca8d6ac2a4e8a8fda5dd7178d934148e2","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"    for method_name in conf.auth.methods:"},{"line_number":1065,"context_line":"        if method_name not in _DEFAULT_AUTH_METHODS:"},{"line_number":1066,"context_line":"            option \u003d cfg.StrOpt(method_name)"},{"line_number":1067,"context_line":"            # some auth methods are already registered but don\u0027t belong to the"},{"line_number":1068,"context_line":"            # default auth methods, so skip duplication errors silently"},{"line_number":1069,"context_line":"            try:"},{"line_number":1070,"context_line":"                _register_auth_plugin_opt(conf, option)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_758c1d80","line":1067,"updated":"2015-03-06 08:37:29.000000000","message":"what exactly is causing this error? would adding all the options to DEFAULT_AUTH_METHODS resolve the issue?","commit_id":"969b106f46ea93eaa547327648d8a62ce8a90b27"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"4e84c7501c69af200db5e996f9d3f57f99dd6073","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"    for method_name in conf.auth.methods:"},{"line_number":1065,"context_line":"        if method_name not in _DEFAULT_AUTH_METHODS:"},{"line_number":1066,"context_line":"            option \u003d cfg.StrOpt(method_name)"},{"line_number":1067,"context_line":"            # some auth methods are already registered but don\u0027t belong to the"},{"line_number":1068,"context_line":"            # default auth methods, so skip duplication errors silently"},{"line_number":1069,"context_line":"            try:"},{"line_number":1070,"context_line":"                _register_auth_plugin_opt(conf, option)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_fdae2f97","line":1067,"in_reply_to":"9a80dd14_758c1d80","updated":"2015-03-06 10:33:33.000000000","message":"Yes, it is a way of resolving the issue, this is why I declared them in DEFAULT_AUTH_METHODS in a previous version of the patch.\n\nThe cause of the error is that we\u0027re in a rather new situation where some auth methods are not declared as default but already have a default driver. When running setup_authentication, the behavior is to declare a minimal option (line 1066) and add it to the conf, but then we hit a duplicate option error in oslo.config (since the default option is different). Since we hit this in a very specific context, I chose to pass the exception silently. Any other non-default auth method will be registered the usual way.\n\nI think it\u0027s better to leave the auth methods that require some specific apache configuration out of the DEFAULT_AUTH_METHODS and go this way. WDYT ?","commit_id":"969b106f46ea93eaa547327648d8a62ce8a90b27"}]}